IAM: Update create_user_with_policy fixture
#13568
Merged
+6
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dfangl
approved these changes
Dec 29, 2025
Member
dfangl
left a comment
There was a problem hiding this comment.
LGTM! I think this is a safe change, however could you run the pro pipeline as well to make sure we don't miss anything, as this fixture is used in IAM tests in pro as well?
Contributor
Author
|
@dfangl Thanks for the quick review! For sure, I will run the Pro tests now 👍🏼 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
create_user_with_policyto take a username - this helps with snapshot testing as sometimes the error will contain the username which you will want to know ahead of time.Pro AWS Build Test and Push: https://github.com/localstack/localstack-pro/actions/runs/20571377274