Skip to content

fix(pyproject): Make inclusion of additional cfn schemas more permissive#13586

Merged
gregfurman merged 1 commit intomainfrom
update/localstack-manifest-DRG-337
Jan 6, 2026
Merged

fix(pyproject): Make inclusion of additional cfn schemas more permissive#13586
gregfurman merged 1 commit intomainfrom
update/localstack-manifest-DRG-337

Conversation

@gregfurman
Copy link
Contributor

@gregfurman gregfurman commented Jan 6, 2026

Motivation

With the addition of the resource_providers/generated subdirectory, we need to ensure the package data we include is more permissive schema data residing in subdirectories.

Related to #13534

Changes

  • Change pyproject.toml to include JSON schema data within recursive subdirectories of resource_providers

Tests

  • Manually tested this on my local by specifically targeting the commit SHA of this branch as a localstack dependency and validating that the generated/**/aws_sqs_queuepolicy.schema.json file is present i.e

    pip install git+https://github.com/localstack/localstack.git@3043c83fd5ccbc8e1a9216e46ae2e31b48c287e9
    
    test -f ".venv/lib/python3.13/site-packages/localstack/services/sqs/resource_providers/generated/aws_sqs_queuepolicy.schema.json" && echo "aws_sqs_queuepolicy.schema.json exists" || echo "aws_sqs_queuepolicy.schema.json does not exist"

Related

@gregfurman gregfurman added this to the 4.13 milestone Jan 6, 2026
@gregfurman gregfurman requested a review from simonrw January 6, 2026 13:50
@gregfurman gregfurman self-assigned this Jan 6, 2026
@gregfurman gregfurman added type: bug Bug report semver: patch Non-breaking changes which can be included in patch releases docs: skip Pull request does not require documentation changes notes: skip Pull request does not have to be mentioned in the release notes labels Jan 6, 2026
@github-actions
Copy link

github-actions bot commented Jan 6, 2026

Test Results - Preflight, Unit

23 046 tests  ±0   21 201 ✅ ±0   6m 10s ⏱️ -2s
     1 suites ±0    1 845 💤 ±0 
     1 files   ±0        0 ❌ ±0 

Results for commit 3043c83. ± Comparison against base commit a9a6799.

@github-actions
Copy link

github-actions bot commented Jan 6, 2026

LocalStack Community integration with Pro

    2 files  ±0      2 suites  ±0   1h 55m 20s ⏱️ - 1m 59s
5 155 tests ±0  4 758 ✅ ±0  397 💤 ±0  0 ❌ ±0 
5 157 runs  ±0  4 758 ✅ ±0  399 💤 ±0  0 ❌ ±0 

Results for commit 3043c83. ± Comparison against base commit a9a6799.

@gregfurman gregfurman marked this pull request as ready for review January 6, 2026 16:10
@github-actions
Copy link

github-actions bot commented Jan 6, 2026

Test Results (amd64) - Acceptance

7 tests  ±0   5 ✅ ±0   3m 0s ⏱️ -5s
1 suites ±0   2 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit 3043c83. ± Comparison against base commit a9a6799.

@github-actions
Copy link

github-actions bot commented Jan 6, 2026

Test Results (amd64) - Integration, Bootstrap

    5 files  ±0      5 suites  ±0   2h 35m 39s ⏱️ -25s
5 562 tests ±0  5 002 ✅ ±0  560 💤 ±0  0 ❌ ±0 
5 568 runs  ±0  5 002 ✅ ±0  566 💤 ±0  0 ❌ ±0 

Results for commit 3043c83. ± Comparison against base commit a9a6799.

@gregfurman gregfurman merged commit d027a58 into main Jan 6, 2026
80 of 83 checks passed
@gregfurman gregfurman deleted the update/localstack-manifest-DRG-337 branch January 6, 2026 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs: skip Pull request does not require documentation changes notes: skip Pull request does not have to be mentioned in the release notes semver: patch Non-breaking changes which can be included in patch releases type: bug Bug report

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants