Skip to content

Fixing write transaction with ARN as table name #13590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
drauedo merged 12 commits into from
Jan 12, 2026
Merged

Fixing write transaction with ARN as table name #13590

drauedo merged 12 commits into from
Jan 12, 2026
+132 −16

Conversation

@drauedo
Copy link
Contributor

@drauedo drauedo commented Jan 7, 2026 •
edited
Loading

Motivation

This PR addresses #13319. Currently, using ARNs within Transactions causes failures in LocalStack. This is due to a limitation in DynamoDB Local, which does not support ARNs for these specific operations.

Changes

This PR formats the TableName field to extract and send only the table name rather than the full ARN when interacting with DynamoDB Local. This ensures compatibility with the underlying service.

@drauedo drauedo self-assigned this Jan 7, 2026
@localstack-bot
Copy link
Contributor

localstack-bot commented Jan 7, 2026 •
edited
Loading

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

localstack-bot
localstack-bot reviewed Jan 7, 2026
View reviewed changes
Copy link
Contributor

@localstack-bot localstack-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to LocalStack! Thanks for raising your first Pull Request and landing in your contributions. Our team will reach out with any reviews or feedbacks that we have shortly. We recommend joining our Slack Community and share your PR on the #community channel to share your contributions with us. Please make sure you are following our contributing guidelines and our Code of Conduct.

@drauedo
Copy link
Contributor Author

drauedo commented Jan 7, 2026

I have read the CLA Document and I hereby sign the CLA

localstack-bot added a commit that referenced this pull request Jan 7, 2026
@localstack-bot
@drauedo has signed the CLA in #13590
9596789
@github-actions
Copy link

github-actions bot commented Jan 7, 2026 •
edited
Loading

Test Results - Preflight, Unit

23 046 tests  ±0   21 201 ✅ ±0   7m 2s ⏱️ +57s
     1 suites ±0    1 845 💤 ±0 
     1 files   ±0        0 ❌ ±0 

Results for commit 1d35220. ± Comparison against base commit 11f2c45.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Jan 7, 2026 •
edited
Loading

LocalStack Community integration with Pro

    2 files  ±    0      2 suites  ±0   17m 52s ⏱️ - 1h 36m 36s
1 372 tests  - 3 790  1 290 ✅  - 3 474  82 💤  - 316  0 ❌ ±0 
1 374 runs   - 3 790  1 290 ✅  - 3 474  84 💤  - 316  0 ❌ ±0 

Results for commit 1d35220. ± Comparison against base commit 11f2c45.

This pull request removes 3790 tests. 
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_lambda_dynamodb
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_opensearch_crud
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_search_books
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_setup
tests.aws.scenario.kinesis_firehose.test_kinesis_firehose.TestKinesisFirehoseScenario ‑ test_kinesis_firehose_s3
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_destination_sns
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_infra
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_prefill_dynamodb_table
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input0-SUCCEEDED]
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input1-SUCCEEDED]
…

♻️ This comment has been updated with latest results.

@drauedo drauedo added semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases docs: skip Pull request does not require documentation changes notes: skip Pull request does not have to be mentioned in the release notes labels Jan 7, 2026
@drauedo drauedo force-pushed the fix_dynamodb_transact_operation branch from 3162cf4 to 4d7fa78 Compare January 7, 2026 15:09
@github-actions
Copy link

github-actions bot commented Jan 7, 2026 •
edited
Loading

Test Results - Alternative Providers

57 tests   53 ✅  58s ⏱️
 1 suites   4 💤
 1 files     0 ❌

Results for commit 1d35220.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Jan 7, 2026 •
edited
Loading

Test Results (amd64) - Acceptance

7 tests  ±0   5 ✅ ±0   3m 0s ⏱️ -1s
1 suites ±0   2 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit 1d35220. ± Comparison against base commit 11f2c45.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Jan 7, 2026 •
edited
Loading

Test Results (amd64) - Integration, Bootstrap

    5 files      5 suites   36m 38s ⏱️
1 396 tests 1 315 ✅ 81 💤 0 ❌
1 402 runs  1 315 ✅ 87 💤 0 ❌

Results for commit 1d35220.

♻️ This comment has been updated with latest results.

@drauedo drauedo marked this pull request as ready for review January 8, 2026 22:24
viren-nadkarni
viren-nadkarni approved these changes Jan 12, 2026
View reviewed changes
Copy link
Member

@viren-nadkarni viren-nadkarni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @drauedo!

Congrats on your first contribution!

@drauedo drauedo force-pushed the fix_dynamodb_transact_operation branch from 52b66d2 to ff8cdb0 Compare January 12, 2026 13:48
@drauedo drauedo merged commit 7aa1faf into main Jan 12, 2026
43 checks passed
@drauedo drauedo deleted the fix_dynamodb_transact_operation branch January 12, 2026 14:47
@drauedo drauedo added the aws:cognito Amazon Cognito label Feb 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@localstack-bot localstack-bot localstack-bot left review comments

@viren-nadkarni viren-nadkarni viren-nadkarni approved these changes

@giograno giograno Awaiting requested review from giograno giograno is a code owner

Assignees

@drauedo drauedo

Labels

aws:cognito Amazon Cognito docs: skip Pull request does not require documentation changes notes: skip Pull request does not have to be mentioned in the release notes semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@drauedo @localstack-bot @viren-nadkarni