Skip to content

APIGW: fix regional domain name to take into account region#13603

Merged
bentsku merged 1 commit intomainfrom
apigw-fix-domain-name-hash
Jan 13, 2026
Merged

APIGW: fix regional domain name to take into account region#13603
bentsku merged 1 commit intomainfrom
apigw-fix-domain-name-hash

Conversation

@bentsku
Copy link
Contributor

@bentsku bentsku commented Jan 9, 2026 •
edited
Loading

Motivation

When working with Regional Domain Names from APIGW, we had a little flaw: we only used the hash of the custom domain name, but not the region is lived it. This meant that for two Custom Domain Names living in 2 different regions, their regional domain names would be the same, which defeat the purpose.

This PR adapts the utility to take into account the region now.

Changes

  • add the region as a parameter to calculate the regional domain name value (it could also very well be randomly generated to be honest)

Tests

Related

@bentsku bentsku added this to the 4.13 milestone Jan 9, 2026
@bentsku bentsku self-assigned this Jan 9, 2026
@bentsku bentsku added aws:apigateway Amazon API Gateway semver: patch Non-breaking changes which can be included in patch releases docs: skip Pull request does not require documentation changes notes: skip Pull request does not have to be mentioned in the release notes labels Jan 9, 2026
@github-actions
Copy link

github-actions bot commented Jan 10, 2026 •
edited
Loading

Test Results - Preflight, Unit

23 068 tests  ±0   21 223 ✅ ±0   6m 15s ⏱️ +4s
     1 suites ±0    1 845 💤 ±0 
     1 files   ±0        0 ❌ ±0 

Results for commit 81db507. ± Comparison against base commit 98e5406.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Jan 10, 2026 •
edited
Loading

LocalStack Community integration with Pro

    2 files  ±    0      2 suites  ±0   18m 18s ⏱️ - 1h 38m 26s
1 315 tests  - 3 854  1 234 ✅  - 3 537  81 💤  - 317  0 ❌ ±0 
1 317 runs   - 3 854  1 234 ✅  - 3 537  83 💤  - 317  0 ❌ ±0 

Results for commit 81db507. ± Comparison against base commit 98e5406.

This pull request removes 3854 tests. 
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_lambda_dynamodb
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_opensearch_crud
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_search_books
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_setup
tests.aws.scenario.kinesis_firehose.test_kinesis_firehose.TestKinesisFirehoseScenario ‑ test_kinesis_firehose_s3
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_destination_sns
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_infra
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_prefill_dynamodb_table
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input0-SUCCEEDED]
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input1-SUCCEEDED]
…

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Jan 10, 2026 •
edited
Loading

Test Results (amd64) - Acceptance

7 tests  ±0   5 ✅ ±0   2m 59s ⏱️ -7s
1 suites ±0   2 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit 81db507. ± Comparison against base commit 98e5406.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Jan 10, 2026 •
edited
Loading

Test Results (amd64) - Integration, Bootstrap

    5 files      5 suites   35m 56s ⏱️
1 339 tests 1 259 ✅ 80 💤 0 ❌
1 345 runs  1 259 ✅ 86 💤 0 ❌

Results for commit 81db507.

♻️ This comment has been updated with latest results.

@bentsku bentsku marked this pull request as ready for review January 10, 2026 01:53
@bentsku bentsku requested a review from cloutierMat as a code owner January 10, 2026 01:53
cloutierMat
cloutierMat approved these changes Jan 12, 2026
View reviewed changes
Copy link
Member

@cloutierMat cloutierMat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for jumping on that fix 🚀

@bentsku bentsku force-pushed the apigw-fix-domain-name-hash branch from c6cb07b to 81db507 Compare January 13, 2026 14:29
@bentsku bentsku merged commit 547f99f into main Jan 13, 2026
43 checks passed
@bentsku bentsku deleted the apigw-fix-domain-name-hash branch January 13, 2026 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cloutierMat cloutierMat cloutierMat approved these changes

Assignees

@bentsku bentsku

Labels

aws:apigateway Amazon API Gateway docs: skip Pull request does not require documentation changes notes: skip Pull request does not have to be mentioned in the release notes semver: patch Non-breaking changes which can be included in patch releases

Projects

None yet

Milestone

4.13

Development

Successfully merging this pull request may close these issues.

2 participants

@bentsku @cloutierMat