Skip to content

Lambda: validate supported runtimes for managed instances #13656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
anisaoshafi merged 2 commits into from
Jan 29, 2026
Merged

Lambda: validate supported runtimes for managed instances #13656

anisaoshafi merged 2 commits into from
Jan 29, 2026
+43 −4

Conversation

@anisaoshafi
Copy link
Contributor

@anisaoshafi anisaoshafi commented Jan 27, 2026 •
edited
Loading

Motivation

Validate supported runtimes for lambda managed instances.

Changes

  • Validate allowed runtimes on function creation.

  • Changed waiter in the create_function in ParametrizedLambda
    self.lambda_client.get_waiter("function_active_v2").wait() --> _is_not_pending().

    This check doesn't work for multiruntime_lambda fixture which is reused for managed instances.
    The status for a lambda managed instance function becomes ActiveNonInvocable, instead of Active (which the "function_active_v2" expects), so new approach is to check if status is not pending.

Tests

Related

@anisaoshafi anisaoshafi added aws:lambda AWS Lambda semver: patch Non-breaking changes which can be included in patch releases docs: skip Pull request does not require documentation changes notes: needed Pull request should be mentioned in the release notes labels Jan 27, 2026
@github-actions
Copy link

github-actions bot commented Jan 27, 2026 •
edited
Loading

Test Results - Preflight, Unit

23 084 tests  ±0   21 225 ✅ ±0   6m 38s ⏱️ -1s
     1 suites ±0    1 859 💤 ±0 
     1 files   ±0        0 ❌ ±0 

Results for commit d769b53. ± Comparison against base commit 44d1022.

This pull request removes 1 and adds 1 tests. Note that renamed tests count towards both. 
tests.unit.aws.handlers.test_service.TestServiceExceptionSerializer ‑ test_not_implemented_error_uses_catalog_when_message_is_empty[AVAILABLE_WITH_LICENSE_UPGRADE-is not supported with your LocalStack license]

tests.unit.aws.handlers.test_service.TestServiceExceptionSerializer ‑ test_not_implemented_error_uses_catalog_when_message_is_empty[AVAILABLE_WITH_LICENSE_UPGRADE-is not included within your LocalStack license]

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Jan 27, 2026 •
edited
Loading

Test Results (amd64) - Acceptance

7 tests  ±0   5 ✅ ±0   3m 1s ⏱️ -2s
1 suites ±0   2 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit d769b53. ± Comparison against base commit 44d1022.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Jan 27, 2026 •
edited
Loading

Test Results (amd64) - Integration, Bootstrap

    5 files  ±0      5 suites  ±0   2h 36m 25s ⏱️ -2s
5 597 tests ±0  5 039 ✅ ±0  558 💤 ±0  0 ❌ ±0 
5 603 runs  ±0  5 039 ✅ ±0  564 💤 ±0  0 ❌ ±0 

Results for commit d769b53. ± Comparison against base commit 44d1022.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Jan 27, 2026 •
edited
Loading

LocalStack Community integration with Pro

    2 files  ±0      2 suites  ±0   1h 58m 10s ⏱️ +38s
5 176 tests ±0  4 786 ✅  - 2  388 💤 ±0  2 ❌ +2 
5 178 runs  ±0  4 786 ✅  - 2  390 💤 ±0  2 ❌ +2 

For more details on these failures, see this check.

Results for commit d769b53. ± Comparison against base commit 44d1022.

♻️ This comment has been updated with latest results.

@anisaoshafi anisaoshafi marked this pull request as ready for review January 28, 2026 17:54
@anisaoshafi anisaoshafi added this to the Playground milestone Jan 28, 2026
joe4dev
joe4dev approved these changes Jan 29, 2026
View reviewed changes
Copy link
Member

@joe4dev joe4dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Added some comments for minor suggestions.

localstack-core/localstack/testing/aws/lambda_utils.py
CodeSigningConfigArn: str | None = None,
Architectures: Sequence["ArchitectureType"] | None = None,
EphemeralStorage: Optional["EphemeralStorageTypeDef"] = None,
CapacityProviderConfig: Optional["CapacityProviderConfigTypeDef"] = None,
Copy link
Member

@joe4dev joe4dev Jan 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

praise: Thanks for adding these typedefs ✨

@anisaoshafi
Copy link
Contributor Author

anisaoshafi commented Jan 29, 2026

CI failures are on two flaky SNS tests, which didn't recover on rerun. Merging.

@anisaoshafi anisaoshafi merged commit 42a892c into main Jan 29, 2026
66 of 70 checks passed
@anisaoshafi anisaoshafi deleted the drg-147 branch January 29, 2026 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joe4dev joe4dev joe4dev approved these changes

@dfangl dfangl Awaiting requested review from dfangl dfangl is a code owner

Assignees

No one assigned

Labels

aws:lambda AWS Lambda docs: skip Pull request does not require documentation changes notes: needed Pull request should be mentioned in the release notes semver: patch Non-breaking changes which can be included in patch releases

Projects

None yet

Milestone

Playground

Development

Successfully merging this pull request may close these issues.

3 participants

@anisaoshafi @joe4dev