Skip to content

Update scaffolding for AWS::Lambda::Function#13668

Merged
anisaoshafi merged 2 commits intomainfrom
scffld-lmi
Feb 2, 2026
Merged

Update scaffolding for AWS::Lambda::Function#13668
anisaoshafi merged 2 commits intomainfrom
scffld-lmi

Conversation

@anisaoshafi
Copy link
Contributor

@anisaoshafi anisaoshafi commented Jan 30, 2026 •
edited
Loading

Motivation

Update scaffolding for AWS::Lambda::Function.
The scaffolding process was recently revisited in #13513.

Changes

Tests

Related

Closes DRG-276

@anisaoshafi anisaoshafi added aws:cloudformation AWS CloudFormation aws:lambda AWS Lambda semver: patch Non-breaking changes which can be included in patch releases docs: skip Pull request does not require documentation changes notes: skip Pull request does not have to be mentioned in the release notes labels Jan 30, 2026
@github-actions
Copy link

github-actions bot commented Jan 30, 2026 •
edited
Loading

Test Results - Preflight, Unit

23 088 tests  ±0   21 229 ✅ ±0   5m 55s ⏱️ -13s
     1 suites ±0    1 859 💤 ±0 
     1 files   ±0        0 ❌ ±0 

Results for commit f20b935. ± Comparison against base commit 59e81ce.

♻️ This comment has been updated with latest results.

@anisaoshafi anisaoshafi force-pushed the scffld-lmi branch 2 times, most recently from ac97834 to fb4294d Compare January 30, 2026 16:14
@github-actions
Copy link

github-actions bot commented Jan 30, 2026 •
edited
Loading

Test Results (amd64) - Acceptance

7 tests  ±0   5 ✅ ±0   3m 8s ⏱️ +8s
1 suites ±0   2 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit f20b935. ± Comparison against base commit 59e81ce.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Jan 30, 2026 •
edited
Loading

Test Results (amd64) - Integration, Bootstrap

    5 files      5 suites   2h 38m 42s ⏱️
5 599 tests 5 041 ✅ 558 💤 0 ❌
5 605 runs  5 041 ✅ 564 💤 0 ❌

Results for commit f20b935.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Jan 30, 2026 •
edited
Loading

LocalStack Community integration with Pro

    2 files  ±0      2 suites  ±0   1h 58m 22s ⏱️ + 1m 40s
5 178 tests ±0  4 790 ✅ ±0  388 💤 ±0  0 ❌ ±0 
5 180 runs  ±0  4 790 ✅ ±0  390 💤 ±0  0 ❌ ±0 

Results for commit f20b935. ± Comparison against base commit 59e81ce.

♻️ This comment has been updated with latest results.

@anisaoshafi anisaoshafi marked this pull request as ready for review February 2, 2026 09:34
joe4dev
joe4dev approved these changes Feb 2, 2026
View reviewed changes
Copy link
Member

@joe4dev joe4dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from a Lambda service perspective: Neat migration to the new approach without regressions for AWS::Lambda::Function 🚀

I'm not familiar with the new approach yet. Let us know if you have any suggestions @peter-smith-phd

@anisaoshafi anisaoshafi merged commit 89f2366 into main Feb 2, 2026
43 checks passed
@anisaoshafi anisaoshafi deleted the scffld-lmi branch February 2, 2026 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joe4dev joe4dev joe4dev approved these changes

@dominikschubert dominikschubert Awaiting requested review from dominikschubert dominikschubert is a code owner

@dfangl dfangl Awaiting requested review from dfangl dfangl is a code owner

@gregfurman gregfurman Awaiting requested review from gregfurman gregfurman is a code owner

Assignees

No one assigned

Labels

aws:cloudformation AWS CloudFormation aws:lambda AWS Lambda docs: skip Pull request does not require documentation changes notes: skip Pull request does not have to be mentioned in the release notes semver: patch Non-breaking changes which can be included in patch releases

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@anisaoshafi @joe4dev