Skip to content

Conversation

@silv-io
Copy link
Member

@silv-io silv-io commented Feb 2, 2026

Motivation

The ASF upgrades stopped working, because there is a incompatibility with pip==26.0. We'll need to pin pip below 26 until this is resolved in pip-tools (or until we switch to uv)

See: jazzband/pip-tools#2319

Changes

  • Install pip<26.0 in the dependency upgrades to avoid the incompatibility introduced there.
  • Install pip<26.0 in the ASF upgrades for the same reason

Tests

Manual run of the ASF upgrades from this branch:
https://github.com/localstack/localstack/actions/runs/21587809166

Related

FLC-339

@silv-io silv-io added semver: patch Non-breaking changes which can be included in patch releases docs: skip Pull request does not require documentation changes notes: skip Pull request does not have to be mentioned in the release notes labels Feb 2, 2026
@silv-io silv-io requested a review from bentsku February 2, 2026 10:53
@github-actions
Copy link

github-actions bot commented Feb 2, 2026

S3 Image Test Results (AMD64 / ARM64)

    2 files      2 suites   7m 59s ⏱️
  552 tests   500 ✅  52 💤 0 ❌
1 104 runs  1 000 ✅ 104 💤 0 ❌

Results for commit 5cc56aa.

@github-actions
Copy link

github-actions bot commented Feb 2, 2026

Test Results - Preflight, Unit

23 088 tests   21 229 ✅  6m 14s ⏱️
     1 suites   1 859 💤
     1 files         0 ❌

Results for commit 5cc56aa.

@silv-io silv-io changed the title Pin pip to below 26 for ASF updates Pin pip to below 26 for ASF and python dep upgrades Feb 2, 2026
@silv-io silv-io force-pushed the flc-339-fix-asf-update-after-pip-26-release branch from ea45789 to 0d7222e Compare February 2, 2026 11:12
Copy link
Contributor

@bentsku bentsku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just saw the ASF Update PR working 👍 #13675

Thanks for jumping on this 🙏

@silv-io silv-io mentioned this pull request Feb 2, 2026
@silv-io silv-io marked this pull request as ready for review February 2, 2026 11:18
@silv-io silv-io merged commit 1ee8644 into main Feb 2, 2026
21 checks passed
@silv-io silv-io deleted the flc-339-fix-asf-update-after-pip-26-release branch February 2, 2026 11:18
@alexrashed
Copy link
Member

Thanks a lot for jumping on the issue! Now that this PR has been merged, I triggered a run from main to get this week's updates in: https://github.com/localstack/localstack/actions/runs/21621857384

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs: skip Pull request does not require documentation changes notes: skip Pull request does not have to be mentioned in the release notes semver: patch Non-breaking changes which can be included in patch releases

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants