unpin botocore, update minimum version#9667
Merged
alexrashed merged 1 commit intomasterfrom Nov 22, 2023
Merged
Conversation
d981552 to
90aab34
Compare
viren-nadkarni
approved these changes
Nov 22, 2023
Member
viren-nadkarni
left a comment
There was a problem hiding this comment.
LGTM ✔️
you might want to mention the -ext CI run for info.
This was referenced Nov 23, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
With 815d6c7 we pinned
botocoreto version1.31.85to prevent incompatibilities withmoto.These issues were fixed in getmoto/moto#7030.
This PR will coordinate the update of
botocoreto the newest version, once we have themotofix in, which might be addressed in #9624.Changes
botocoreand update the minimum version.Testing
botocoreused basically everywhere. If we're green, we're fine. :)TODO
masterafter the upgrade ofmoto.