Merged
Conversation
alexrashed
reviewed
Dec 19, 2023
Member
alexrashed
left a comment
There was a problem hiding this comment.
Thanks as always for pro-actively updating the version after implementing the fix!
The failing tests are caused by:
- The fork not having the permissions to execute secrets (to execute the pro tests).
- An issue with the upgrade of dynamodblocal, which is addressed in #9910.
From my point of view this PR is looking good and could be merged, but I have limited availability today to take a closer look. So I'll leave it to @dfangl to review / approve / merge. Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://github.com/etspaceman/kinesis-mock/releases/tag/v0.4.5
Motivation
Solves #9884
Changes
Bumps kinesis-mock to 0.4.5