Update dynamodb snapshot to unblock pipeline#9910
Merged
dominikschubert merged 2 commits intomasterfrom Dec 19, 2023
Merged
Conversation
This was referenced Dec 19, 2023
simonrw
approved these changes
Dec 19, 2023
Contributor
simonrw
left a comment
There was a problem hiding this comment.
I think this is a fair change for now. I appreciate you trying to resolve the problem in a more complete way, but with this change we can implement the "proper" solution in our own time.
viren-nadkarni
approved these changes
Dec 19, 2023
| log_listener=_log_listener, | ||
| auto_restart=True, | ||
| name="dynamodb-local", | ||
| env_vars={"DDB_LOCAL_TELEMETRY": "0"}, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
We've started seeing repeatable failures in CI due to a snapshot mismatch for
tests/aws/services/cloudformation/resources/test_lambda.py::TestCfnLambdaIntegrations::test_cfn_lambda_dynamodb_source.My investigation pointed towards a new update of DynamoDB local as the culprit (AWS recently released a 2.2.0 version with support for Table delete protection)
Was running into some issues with the initial PR in #9909
I still want to tackle the problem with a more long-term solution to avoid these unpredictable dependency update but for now this should unblock the pipeline.
Changes
tests/aws/services/cloudformation/resources/test_lambda.py::TestCfnLambdaIntegrations::test_cfn_lambda_dynamodb_source