Fix exception causes all over the codebase#16706
Merged
tacaswell merged 1 commit intomatplotlib:masterfrom Mar 9, 2020
Merged
Conversation
0fc9899 to
40d7449
Compare
Contributor
Author
|
@timhoffm Ready for review |
Member
|
Maybe you could include a few words as to why we want to use this grammar? |
Contributor
Author
jklymak
approved these changes
Mar 9, 2020
Member
jklymak
left a comment
There was a problem hiding this comment.
These all look fine to me. Would be nice if the test coverage was better, but don't expect you to write a bunch of tests that trigger exceptions...
Member
|
Thanks @cool-RR ! |
This was referenced Mar 9, 2020
This was referenced Jun 9, 2020
Merged
This was referenced Jun 12, 2020
Merged
Contributor
Author
|
I just made a blog post about this change here: https://blog.ram.rachum.com/post/621791438475296768/improving-python-exception-chaining-with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
PR Checklist