You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Wow, cool! I have to admit, I do not walk into the depth of distutils, but it does seem great to me. If you want style nitpicks, I think textwrap.dedent() would make for nicer inline code than '\n'.join(...) ;)
EDIT: to be clear, I don't see why not to use this test. Although I am not sure if there are any skip needed potentially?
Wow, cool! I have to admit, I do not walk into the depth of distutils, but it does seem great to me. If you want style nitpicks, I think textwrap.dedent() would make for nicer inline code than '\n'.join(...) ;)
EDIT: to be clear, I don't see why not to use this test. Although I am not sure if there are any skip needed potentially?
I do like dedent better. I had to use a combination of indent/dedent to do the right thing for Fortran 77 (first 6 columns are reserved). The only skips in the numpy random C API tests are for slow (which I have) and if cython/numba/cffi are not present (which aren't used here), so I think we should be good on skips.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See numpy#18295
@seberg Here's a potential test, let me know what you think. It's modeled after this Cython test for the random C API extending examples.
Please suggest improvements, or if it's acceptable then I will merge into the PR branch.