update warning presence in Microsoft.Build.Locator.targets#233
Conversation
rainersigwald
left a comment
There was a problem hiding this comment.
Does this work? It looks like it should hit dotnet/msbuild#1155
+1, this does not build. @YuliiaKovalova, in addition to fixing it could you please also add <Import Project="..\..\src\MSBuildLocator\build\Microsoft.Build.Locator.targets"/>to BuilderApp.csproj so this file is covered by CI? |
I was inspired by https://stackoverflow.com/questions/3289538/is-there-any-msbuild-task-to-check-if-a-string-contains-another-string-similar :) I will doublecheck Should I check it with a regular expression? |
Yes, it works for properties but sadly not for metadata.
I don't think so. Please check this comment. |
a7dc4c3 to
4fdff14
Compare
It works, thank you ! |
ladipro
left a comment
There was a problem hiding this comment.
LGTM. Please wait for @rainersigwald's approval before merging.
|
@rainersigwald , please review the changes. |
rainersigwald
left a comment
There was a problem hiding this comment.
Sorry, I seem to have totally missed this from a couple of weeks ago. LGTM!
Fixes: #89