Add Parameters type to core lib#26042
Closed
anurbol wants to merge 1 commit intomicrosoft:masterfrom
anurbol:patch-2
Closed
Add Parameters type to core lib#26042anurbol wants to merge 1 commit intomicrosoft:masterfrom anurbol:patch-2
anurbol wants to merge 1 commit intomicrosoft:masterfrom
anurbol:patch-2
Conversation
Here: #26019 (comment) I was recommended by @bterlson to add Parameters type to my lib.d.ts as well as ReturnType. When doing so, I found out that ReturnType is already lives in core lib.es5.d.ts. In my case I use Parameters much more than ReturnType, and I guess some other people do as well. So I thought both said types should be in core lib.
Contributor
|
We discussed that before, and chose not to add it. we can discuss it again in the next design meeting. |
Author
|
@mhegazy Thank you for the response! OK, closing this, but I really think that should be in lib. After all ReturnType being in core and Parameters not, seems inconsistent, though you, TS team, of course may have your own reasons. Good luck! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here: #26019 (comment)
I was recommended by @bterlson to add Parameters type to my lib.d.ts as well as ReturnType. When doing so, I found out that ReturnType is already lives in core lib.es5.d.ts. In my case I use Parameters much more than ReturnType, and I guess some other people do as well. So I thought both said types should be in core lib.
Fixes #26019
Sorry, no new tests/docs (I am afraid I am not able for writing good ones), but the code's author is Anders Hejlsberg himself :-)