Set impliedNodeFormat on sourceFiles maufactured in watch mode#46349
Merged
weswigham merged 1 commit intomicrosoft:mainfrom Oct 14, 2021
Merged
Set impliedNodeFormat on sourceFiles maufactured in watch mode#46349weswigham merged 1 commit intomicrosoft:mainfrom
weswigham merged 1 commit intomicrosoft:mainfrom
Conversation
andrewbranch
approved these changes
Oct 13, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #46333
I put quite a bit of effort into testing this in build/incremental mode in the initial PR (that's why
impliedNodeFormatis serialized into the build info file already!) - I naively assumedwatchmode would come for free from that. I was incorrect in that assumption. 😢 In any case, the fix is quite small - just setting theimpliedNodeFormatSourceFilemember on source files made by the watch program. (Which, as a reminder, this field has to be set by the program because you need a full module resolver host to set it, and the program is the first level at which we have one available)