Merged
Conversation
Member
Author
|
@typescript-bot test this |
Collaborator
|
Heya @ahejlsberg, I've started to run the diff-based user code test suite on this PR at 26df65a. You can monitor the build here. Update: The results are in! |
Collaborator
|
Heya @ahejlsberg, I've started to run the parallelized Definitely Typed test suite on this PR at 26df65a. You can monitor the build here. |
Collaborator
|
Heya @ahejlsberg, I've started to run the extended test suite on this PR at 26df65a. You can monitor the build here. |
Collaborator
|
Heya @ahejlsberg, I've started to run the abridged perf test suite on this PR at 26df65a. You can monitor the build here. Update: The results are in! |
Collaborator
|
@ahejlsberg Here they are:Comparison Report - main..49503
System
Hosts
Scenarios
Developer Information: |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Collaborator
|
@ahejlsberg |
Collaborator
|
Heya @ahejlsberg, I've run the RWC suite on this PR - assuming you're on the TS core team, you can view the resulting diff here. |
RyanCavanaugh
approved these changes
Jun 13, 2022
Member
|
What is going on with xstate emit time? @typescript-bot perf test this |
Collaborator
|
Heya @DanielRosenwasser, I've started to run the perf test suite on this PR at 26df65a. You can monitor the build here. Update: The results are in! |
Collaborator
|
@DanielRosenwasser Here they are:Comparison Report - main..49503
System
Hosts
Scenarios
Developer Information: |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
weswigham
approved these changes
Jun 13, 2022
Contributor
|
@DanielRosenwasser is a small drop (2-4%) in XState's emit time concerning here? 🤔 Or do I read those reports all wrong? |
Member
|
I don't know why it's showing a drop, the emit time is identical; only the variability has shrunk if I've understood it correctly (@weswigham @rbuckton) |
Contributor
|
It looks like total time has improved (i.e., is lower) across the board. |
Contributor
|
There's a Stack Overflow question that seems to be related to this PR: interface Baz {
foo: { a: number };
}
const createDefaultExample = <K extends keyof Baz>(x: K): Baz[K] & { x: K; } => {
return { a: 0, x }; // okay in TS4.7, error in TS4.8
}Looks like the fix for #49520 might have broken this. Is it a bug and should this be filed as such? Or is it intended in some way? EDIT: Looks like the above was fixed by #50261 but this one persists: type Foo<K> = K extends unknown ? { a: number } : unknown
const createDefaultExample = <K,>(x: K): Foo<K> & { x: K; } => {
return { a: 1, x: x }; // okay in TS 4.7.4, error in TS 4.8.2
}Same question, I guess... bug? Not bug? New issue? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #49480.
Fixes #49520.