Skip to content

Comments

Clone questionMark and dotdotdot token#58263

Merged
jakebailey merged 2 commits intomicrosoft:mainfrom
armanio123:FixTokenCloning
Apr 24, 2024
Merged

Clone questionMark and dotdotdot token#58263
jakebailey merged 2 commits intomicrosoft:mainfrom
armanio123:FixTokenCloning

Conversation

@armanio123
Copy link
Contributor

@armanio123 armanio123 commented Apr 20, 2024

Fixes #57924 (comment)

CompletionInfo is failing due to a synthetic propertySignature using an incorrect questionToken position which cause the Assert to fail.

The positions are incorrect due to the checker reusing the synthetic node for the questionToken. When assigning positions the value gets overwritten by the latest position update this generating a node that is "not contained" on the parent.

The PR fixes this by always cloning a synthetic questionToken instead of reusing it.

@gabritto
Copy link
Member

gabritto commented Apr 20, 2024

@typescript-bot perf test this

@typescript-bot
Copy link
Collaborator

typescript-bot commented Apr 20, 2024 •
edited
Loading

Starting jobs; this comment will be updated as builds start and complete.

Command Status Results
perf test this ✅ Started

@armanio123 armanio123 mentioned this pull request Apr 20, 2024
Closed
@armanio123
Copy link
Contributor Author

armanio123 commented Apr 20, 2024

@typescript-bot perf test this

@typescript-bot
Copy link
Collaborator

typescript-bot commented Apr 20, 2024 •
edited
Loading

Starting jobs; this comment will be updated as builds start and complete.

Command Status Results
perf test this ✅ Started 👀 Results

@typescript-bot
Copy link
Collaborator

typescript-bot commented Apr 20, 2024

@armanio123
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr
Metric baseline pr Delta Best Worst p-value
Angular - node (v18.15.0, x64)
Memory used 297,480k (± 0.01%) 297,478k (± 0.02%) ~ 297,432k 297,568k p=0.521 n=6
Parse Time 4.08s (± 0.44%) 4.09s (± 0.40%) ~ 4.07s 4.11s p=0.222 n=6
Bind Time 1.21s (± 0.81%) 1.21s (± 0.45%) ~ 1.20s 1.21s p=0.662 n=6
Check Time 12.20s (± 0.29%) 12.19s (± 0.20%) ~ 12.16s 12.22s p=0.869 n=6
Emit Time 10.54s (± 0.28%) 10.53s (± 0.24%) ~ 10.49s 10.57s p=0.935 n=6
Total Time 28.03s (± 0.21%) 28.02s (± 0.13%) ~ 27.98s 28.07s p=1.000 n=6
Compiler-Unions - node (v18.15.0, x64)
Memory used 193,332k (± 0.95%) 193,310k (± 0.96%) ~ 192,085k 195,735k p=0.575 n=6
Parse Time 2.00s (± 1.30%) 2.01s (± 1.46%) ~ 1.97s 2.04s p=0.464 n=6
Bind Time 1.07s (± 1.13%) 1.07s (± 0.92%) ~ 1.06s 1.08s p=0.865 n=6
Check Time 14.05s (± 0.28%) 14.00s (± 0.44%) ~ 13.89s 14.06s p=0.196 n=6
Emit Time 3.88s (± 0.85%) 3.95s (± 3.76%) ~ 3.86s 4.25s p=0.336 n=6
Total Time 21.00s (± 0.17%) 21.03s (± 0.76%) ~ 20.86s 21.32s p=0.936 n=6
mui-docs - node (v18.15.0, x64)
Memory used 1,753,207k (± 0.00%) 1,753,192k (± 0.00%) ~ 1,753,097k 1,753,274k p=1.000 n=6
Parse Time 10.04s (± 0.85%) 9.99s (± 0.34%) ~ 9.97s 10.06s p=0.414 n=6
Bind Time 3.37s (± 0.49%) 3.36s (± 0.40%) ~ 3.34s 3.38s p=0.462 n=6
Check Time 81.72s (± 0.34%) 81.67s (± 0.54%) ~ 81.30s 82.48s p=0.471 n=6
Emit Time 0.20s (± 2.06%) 0.20s (± 2.06%) ~ 0.19s 0.20s p=1.000 n=6
Total Time 95.33s (± 0.32%) 95.22s (± 0.47%) ~ 94.85s 96.04s p=0.378 n=6
self-build-src - node (v18.15.0, x64)
Memory used 2,322,365k (± 0.02%) 2,322,760k (± 0.05%) ~ 2,321,207k 2,323,991k p=0.689 n=6
Parse Time 7.55s (± 0.97%) 7.54s (± 0.85%) ~ 7.47s 7.62s p=1.000 n=6
Bind Time 2.72s (± 0.45%) 2.72s (± 0.56%) ~ 2.70s 2.74s p=0.871 n=6
Check Time 49.31s (± 0.39%) 49.47s (± 0.71%) ~ 49.08s 49.92s p=0.575 n=6
Emit Time 4.01s (± 2.55%) 3.96s (± 2.42%) ~ 3.79s 4.05s p=0.423 n=6
Total Time 63.60s (± 0.42%) 63.68s (± 0.71%) ~ 63.06s 64.28s p=0.810 n=6
self-build-src-public-api - node (v18.15.0, x64)
Memory used 2,396,390k (± 0.02%) 2,397,150k (± 0.03%) ~ 2,396,175k 2,398,650k p=0.078 n=6
Parse Time 7.80s (± 0.47%) 7.79s (± 1.08%) ~ 7.64s 7.90s p=1.000 n=6
Bind Time 2.46s (± 1.07%) 2.45s (± 0.80%) ~ 2.43s 2.48s p=0.872 n=6
Check Time 50.22s (± 0.42%) 49.95s (± 0.24%) -0.26s (- 0.53%) 49.79s 50.11s p=0.045 n=6
Emit Time 4.06s (± 2.89%) 3.91s (± 2.83%) 🟩-0.16s (- 3.90%) 3.80s 4.12s p=0.045 n=6
Total Time 64.55s (± 0.38%) 64.11s (± 0.18%) -0.44s (- 0.67%) 64.00s 64.30s p=0.008 n=6
self-compiler - node (v18.15.0, x64)
Memory used 423,934k (± 0.01%) 423,922k (± 0.01%) ~ 423,863k 423,954k p=0.936 n=6
Parse Time 2.89s (± 0.49%) 2.89s (± 0.96%) ~ 2.86s 2.92s p=1.000 n=6
Bind Time 1.09s (± 0.47%) 1.08s (± 0.77%) ~ 1.07s 1.09s p=0.923 n=6
Check Time 15.38s (± 0.36%) 15.35s (± 0.18%) ~ 15.32s 15.38s p=0.686 n=6
Emit Time 1.17s (± 0.76%) 1.17s (± 0.88%) ~ 1.15s 1.18s p=0.673 n=6
Total Time 20.52s (± 0.29%) 20.50s (± 0.23%) ~ 20.44s 20.56s p=0.466 n=6
ts-pre-modules - node (v18.15.0, x64)
Memory used 369,299k (± 0.03%) 369,295k (± 0.02%) ~ 369,225k 369,402k p=0.936 n=6
Parse Time 2.45s (± 1.43%) 2.47s (± 0.99%) ~ 2.44s 2.51s p=0.520 n=6
Bind Time 1.32s (± 1.39%) 1.33s (± 0.91%) ~ 1.31s 1.34s p=0.800 n=6
Check Time 13.36s (± 0.17%) 13.30s (± 0.38%) -0.05s (- 0.41%) 13.20s 13.34s p=0.016 n=6
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) ~ 0.00s 0.00s p=1.000 n=6
Total Time 17.13s (± 0.30%) 17.10s (± 0.26%) ~ 17.02s 17.15s p=0.226 n=6
vscode - node (v18.15.0, x64)
Memory used 2,920,845k (± 0.00%) 2,920,795k (± 0.00%) ~ 2,920,712k 2,920,860k p=0.128 n=6
Parse Time 16.73s (± 0.47%) 16.70s (± 0.26%) ~ 16.65s 16.76s p=0.872 n=6
Bind Time 5.03s (± 1.81%) 5.02s (± 1.69%) ~ 4.97s 5.19s p=0.627 n=6
Check Time 88.36s (± 0.39%) 88.35s (± 0.40%) ~ 87.97s 88.83s p=0.936 n=6
Emit Time 23.87s (± 0.51%) 23.84s (± 0.59%) ~ 23.61s 23.97s p=0.936 n=6
Total Time 133.97s (± 0.35%) 133.90s (± 0.23%) ~ 133.47s 134.26s p=0.748 n=6
webpack - node (v18.15.0, x64)
Memory used 409,811k (± 0.01%) 409,858k (± 0.01%) ~ 409,829k 409,880k p=0.066 n=6
Parse Time 3.95s (± 1.19%) 3.94s (± 0.74%) ~ 3.89s 3.98s p=0.514 n=6
Bind Time 1.64s (± 0.74%) 1.64s (± 1.22%) ~ 1.60s 1.65s p=0.318 n=6
Check Time 16.93s (± 0.36%) 16.98s (± 0.21%) ~ 16.94s 17.03s p=0.173 n=6
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) ~ 0.00s 0.00s p=1.000 n=6
Total Time 22.51s (± 0.19%) 22.56s (± 0.17%) ~ 22.52s 22.62s p=0.091 n=6
xstate-main - node (v18.15.0, x64)
Memory used 459,364k (± 0.00%) 459,395k (± 0.03%) ~ 459,312k 459,621k p=1.000 n=6
Parse Time 4.00s (± 0.47%) 4.01s (± 0.52%) ~ 3.99s 4.05s p=0.105 n=6
Bind Time 1.47s (± 0.96%) 1.47s (± 1.25%) ~ 1.45s 1.49s p=0.870 n=6
Check Time 22.40s (± 0.35%) 22.43s (± 0.24%) ~ 22.38s 22.52s p=0.297 n=6
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) ~ 0.00s 0.00s p=1.000 n=6
Total Time 27.86s (± 0.32%) 27.92s (± 0.26%) ~ 27.84s 28.03s p=0.298 n=6
System info unknown
Hosts
  • node (v18.15.0, x64)
Scenarios
  • Angular - node (v18.15.0, x64)
  • Compiler-Unions - node (v18.15.0, x64)
  • mui-docs - node (v18.15.0, x64)
  • self-build-src - node (v18.15.0, x64)
  • self-build-src-public-api - node (v18.15.0, x64)
  • self-compiler - node (v18.15.0, x64)
  • ts-pre-modules - node (v18.15.0, x64)
  • vscode - node (v18.15.0, x64)
  • webpack - node (v18.15.0, x64)
  • xstate-main - node (v18.15.0, x64)
Benchmark Name Iterations
Current pr 6
Baseline baseline 6

tsserver

Comparison Report - baseline..pr
Metric baseline pr Delta Best Worst p-value
Compiler-UnionsTSServer - node (v18.15.0, x64)
Req 1 - updateOpen 3,520ms (± 0.60%) 3,508ms (± 0.93%) ~ 3,467ms 3,560ms p=0.378 n=6
Req 2 - geterr 7,570ms (± 0.33%) 7,634ms (± 1.83%) ~ 7,533ms 7,897ms p=0.688 n=6
Req 3 - references 430ms (± 0.77%) 433ms (± 1.38%) ~ 428ms 444ms p=0.467 n=6
Req 4 - navto 342ms (± 1.02%) 340ms (± 0.43%) ~ 338ms 342ms p=0.466 n=6
Req 5 - completionInfo count 1,357 (± 0.00%) 1,357 (± 0.00%) ~ 1,357 1,357 p=1.000 n=6
Req 5 - completionInfo 111ms (± 1.05%) 112ms (± 1.13%) ~ 111ms 114ms p=0.210 n=6
CompilerTSServer - node (v18.15.0, x64)
Req 1 - updateOpen 3,668ms (± 0.47%) 3,682ms (± 0.66%) ~ 3,656ms 3,721ms p=0.575 n=6
Req 2 - geterr 5,721ms (± 1.54%) 5,693ms (± 0.23%) ~ 5,681ms 5,717ms p=0.467 n=6
Req 3 - references 447ms (± 0.66%) 444ms (± 0.51%) ~ 442ms 447ms p=0.124 n=6
Req 4 - navto 341ms (± 1.53%) 340ms (± 1.12%) ~ 338ms 348ms p=0.505 n=6
Req 5 - completionInfo count 1,519 (± 0.00%) 1,519 (± 0.00%) ~ 1,519 1,519 p=1.000 n=6
Req 5 - completionInfo 122ms (± 5.85%) 124ms (± 1.02%) ~ 122ms 125ms p=0.866 n=6
xstate-main-1-tsserver - node (v18.15.0, x64)
Req 1 - updateOpen 5,249ms (± 0.34%) 5,265ms (± 0.57%) ~ 5,224ms 5,302ms p=0.378 n=6
Req 2 - geterr 1,127ms (± 1.19%) 1,142ms (± 0.93%) ~ 1,127ms 1,153ms p=0.054 n=6
Req 3 - references 87ms (± 4.55%) 85ms (± 1.24%) ~ 83ms 86ms p=0.742 n=6
Req 4 - navto 452ms (± 0.99%) 450ms (± 1.08%) ~ 446ms 458ms p=0.466 n=6
Req 5 - completionInfo count 3,413 (± 0.00%) 3,413 (± 0.00%) ~ 3,413 3,413 p=1.000 n=6
Req 5 - completionInfo 855ms (± 2.87%) 845ms (± 2.03%) ~ 830ms 869ms p=0.521 n=6
System info unknown
Hosts
  • node (v18.15.0, x64)
Scenarios
  • CompilerTSServer - node (v18.15.0, x64)
  • Compiler-UnionsTSServer - node (v18.15.0, x64)
  • xstate-main-1-tsserver - node (v18.15.0, x64)
Benchmark Name Iterations
Current pr 6
Baseline baseline 6

startup

Comparison Report - baseline..pr
Metric baseline pr Delta Best Worst p-value
tsc-startup - node (v18.15.0, x64)
Execution time 156.44ms (± 0.15%) 156.19ms (± 0.16%) -0.25ms (- 0.16%) 155.26ms 160.03ms p=0.000 n=600
tsserver-startup - node (v18.15.0, x64)
Execution time 344.67ms (± 0.29%) 344.60ms (± 0.30%) ~ 336.43ms 354.85ms p=0.312 n=600
tsserverlibrary-startup - node (v18.15.0, x64)
Execution time 274.18ms (± 0.28%) 274.05ms (± 0.28%) -0.13ms (- 0.05%) 267.75ms 279.75ms p=0.002 n=600
typescript-startup - node (v18.15.0, x64)
Execution time 336.22ms (± 0.33%) 336.33ms (± 0.31%) ~ 328.00ms 343.55ms p=0.155 n=600
System info unknown
Hosts
  • node (v18.15.0, x64)
Scenarios
  • tsc-startup - node (v18.15.0, x64)
  • tsserver-startup - node (v18.15.0, x64)
  • tsserverlibrary-startup - node (v18.15.0, x64)
  • typescript-startup - node (v18.15.0, x64)
Benchmark Name Iterations
Current pr 6
Baseline baseline 6

Developer Information:

Download Benchmarks

@jakebailey
Copy link
Member

jakebailey commented Apr 20, 2024

This makes sense; getSynthesizedDeepCloneWorker is similar and passes in the token visitor. Makes me wonder if we should try and make the visitor required and see where else we've missed this.

But, this does need a test; the linked issue should come with one that can be minimized.

@jakebailey
Copy link
Member

jakebailey commented Apr 24, 2024

@typescript-bot perf test this

@typescript-bot
Copy link
Collaborator

typescript-bot commented Apr 24, 2024 •
edited
Loading

Starting jobs; this comment will be updated as builds start and complete.

Command Status Results
perf test this ✅ Started 👀 Results

@typescript-bot
Copy link
Collaborator

typescript-bot commented Apr 24, 2024

@jakebailey
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr
Metric baseline pr Delta Best Worst p-value
Compiler-Unions - node (v18.15.0, x64)
Errors 30 (± 0.00%) 30 (± 0.00%) ~ 30 30 p=1.000 n=6
Symbols 62,154 (± 0.00%) 62,154 (± 0.00%) ~ 62,154 62,154 p=1.000 n=6
Types 50,273 (± 0.00%) 50,273 (± 0.00%) ~ 50,273 50,273 p=1.000 n=6
Memory used 192,737k (± 0.77%) 192,107k (± 0.02%) ~ 192,076k 192,178k p=0.128 n=6
Parse Time 1.65s (± 1.08%) 1.64s (± 1.37%) ~ 1.61s 1.67s p=0.806 n=6
Bind Time 0.86s (± 0.47%) 0.87s (± 0.97%) ~ 0.86s 0.88s p=0.527 n=6
Check Time 11.32s (± 0.49%) 11.32s (± 0.47%) ~ 11.22s 11.37s p=0.629 n=6
Emit Time 3.15s (± 0.52%) 3.16s (± 0.37%) ~ 3.15s 3.18s p=0.250 n=6
Total Time 16.98s (± 0.36%) 16.99s (± 0.27%) ~ 16.93s 17.05s p=0.630 n=6
angular-1 - node (v18.15.0, x64)
Errors 5 (± 0.00%) 5 (± 0.00%) ~ 5 5 p=1.000 n=6
Symbols 945,172 (± 0.00%) 945,172 (± 0.00%) ~ 945,172 945,172 p=1.000 n=6
Types 408,068 (± 0.00%) 408,068 (± 0.00%) ~ 408,068 408,068 p=1.000 n=6
Memory used 1,221,850k (± 0.00%) 1,221,869k (± 0.00%) ~ 1,221,803k 1,221,945k p=0.575 n=6
Parse Time 8.30s (± 0.28%) 8.32s (± 0.48%) ~ 8.27s 8.38s p=0.416 n=6
Bind Time 2.23s (± 0.23%) 2.23s (± 0.66%) ~ 2.20s 2.24s p=0.324 n=6
Check Time 36.48s (± 0.43%) 36.39s (± 0.49%) ~ 36.14s 36.58s p=0.575 n=6
Emit Time 17.29s (± 0.54%) 17.39s (± 0.39%) ~ 17.31s 17.48s p=0.065 n=6
Total Time 64.29s (± 0.32%) 64.33s (± 0.22%) ~ 64.16s 64.47s p=1.000 n=6
mui-docs - node (v18.15.0, x64)
Errors 5 (± 0.00%) 5 (± 0.00%) ~ 5 5 p=1.000 n=6
Symbols 1,954,583 (± 0.00%) 1,954,583 (± 0.00%) ~ 1,954,583 1,954,583 p=1.000 n=6
Types 676,355 (± 0.00%) 676,355 (± 0.00%) ~ 676,355 676,355 p=1.000 n=6
Memory used 1,753,237k (± 0.00%) 1,753,286k (± 0.00%) ~ 1,753,179k 1,753,359k p=0.173 n=6
Parse Time 10.03s (± 0.44%) 10.00s (± 0.50%) ~ 9.94s 10.08s p=0.261 n=6
Bind Time 3.38s (± 0.31%) 3.37s (± 0.61%) ~ 3.35s 3.41s p=0.459 n=6
Check Time 82.07s (± 0.37%) 82.04s (± 0.30%) ~ 81.75s 82.35s p=1.000 n=6
Emit Time 0.20s (± 2.62%) 0.19s (± 2.81%) ~ 0.19s 0.20s p=0.640 n=6
Total Time 95.67s (± 0.35%) 95.61s (± 0.29%) ~ 95.26s 96.04s p=0.873 n=6
self-build-src - node (v18.15.0, x64)
Errors 0 (± 0.00%) 0 (± 0.00%) ~ 0 0 p=1.000 n=6
Symbols 1,215,036 (± 0.00%) 1,215,031 (± 0.00%) -5 (- 0.00%) 1,215,031 1,215,031 p=0.001 n=6
Types 257,343 (± 0.00%) 257,343 (± 0.00%) ~ 257,343 257,343 p=1.000 n=6
Memory used 2,323,581k (± 0.01%) 2,323,299k (± 0.05%) ~ 2,321,843k 2,324,661k p=0.689 n=6
Parse Time 7.62s (± 0.74%) 7.58s (± 1.22%) ~ 7.46s 7.67s p=0.575 n=6
Bind Time 2.74s (± 1.01%) 2.75s (± 1.14%) ~ 2.70s 2.78s p=0.418 n=6
Check Time 49.42s (± 0.50%) 49.25s (± 0.49%) ~ 48.92s 49.59s p=0.471 n=6
Emit Time 3.95s (± 2.89%) 4.10s (± 3.30%) ~ 3.95s 4.34s p=0.066 n=6
Total Time 63.73s (± 0.62%) 63.68s (± 0.42%) ~ 63.36s 64.07s p=1.000 n=6
self-build-src-public-api - node (v18.15.0, x64)
Errors 0 (± 0.00%) 0 (± 0.00%) ~ 0 0 p=1.000 n=6
Symbols 1,215,036 (± 0.00%) 1,215,031 (± 0.00%) -5 (- 0.00%) 1,215,031 1,215,031 p=0.001 n=6
Types 257,343 (± 0.00%) 257,343 (± 0.00%) ~ 257,343 257,343 p=1.000 n=6
Memory used 2,398,138k (± 0.03%) 2,397,930k (± 0.02%) ~ 2,397,143k 2,398,440k p=0.575 n=6
Parse Time 7.84s (± 1.04%) 7.84s (± 0.83%) ~ 7.74s 7.92s p=1.000 n=6
Bind Time 2.46s (± 0.95%) 2.47s (± 0.78%) ~ 2.45s 2.50s p=0.195 n=6
Check Time 50.09s (± 0.21%) 50.08s (± 0.27%) ~ 49.96s 50.28s p=0.689 n=6
Emit Time 3.96s (± 1.68%) 4.02s (± 3.90%) ~ 3.84s 4.26s p=0.630 n=6
Total Time 64.36s (± 0.29%) 64.43s (± 0.40%) ~ 64.06s 64.78s p=0.575 n=6
self-compiler - node (v18.15.0, x64)
Errors 0 (± 0.00%) 0 (± 0.00%) ~ 0 0 p=1.000 n=6
Symbols 256,196 (± 0.00%) 256,191 (± 0.00%) -5 (- 0.00%) 256,191 256,191 p=0.001 n=6
Types 103,624 (± 0.00%) 103,624 (± 0.00%) ~ 103,624 103,624 p=1.000 n=6
Memory used 423,918k (± 0.01%) 423,958k (± 0.01%) ~ 423,915k 424,009k p=0.297 n=6
Parse Time 4.34s (± 0.79%) 4.34s (± 0.79%) ~ 4.30s 4.38s p=0.807 n=6
Bind Time 1.59s (± 1.08%) 1.59s (± 1.89%) ~ 1.55s 1.62s p=0.684 n=6
Check Time 22.41s (± 0.33%) 22.50s (± 0.25%) +0.09s (+ 0.42%) 22.45s 22.60s p=0.028 n=6
Emit Time 1.77s (± 1.27%) 1.76s (± 0.51%) ~ 1.75s 1.77s p=0.806 n=6
Total Time 30.10s (± 0.34%) 30.20s (± 0.23%) ~ 30.08s 30.27s p=0.108 n=6
ts-pre-modules - node (v18.15.0, x64)
Errors 34 (± 0.00%) 34 (± 0.00%) ~ 34 34 p=1.000 n=6
Symbols 224,824 (± 0.00%) 224,824 (± 0.00%) ~ 224,824 224,824 p=1.000 n=6
Types 93,390 (± 0.00%) 93,390 (± 0.00%) ~ 93,390 93,390 p=1.000 n=6
Memory used 369,384k (± 0.03%) 369,268k (± 0.01%) ~ 369,210k 369,328k p=0.093 n=6
Parse Time 2.94s (± 0.70%) 2.94s (± 0.93%) ~ 2.92s 2.99s p=1.000 n=6
Bind Time 1.57s (± 1.25%) 1.58s (± 0.74%) ~ 1.56s 1.59s p=0.166 n=6
Check Time 15.66s (± 0.15%) 15.64s (± 0.18%) ~ 15.61s 15.68s p=0.226 n=6
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) ~ 0.00s 0.00s p=1.000 n=6
Total Time 20.17s (± 0.18%) 20.16s (± 0.19%) ~ 20.11s 20.22s p=0.936 n=6
vscode - node (v18.15.0, x64)
Errors 18 (± 0.00%) 18 (± 0.00%) ~ 18 18 p=1.000 n=6
Symbols 2,795,998 (± 0.00%) 2,795,998 (± 0.00%) ~ 2,795,998 2,795,998 p=1.000 n=6
Types 949,921 (± 0.00%) 949,921 (± 0.00%) ~ 949,921 949,921 p=1.000 n=6
Memory used 2,923,882k (± 0.00%) 2,923,894k (± 0.01%) ~ 2,923,370k 2,924,627k p=0.936 n=6
Parse Time 16.73s (± 0.39%) 16.76s (± 0.36%) ~ 16.66s 16.84s p=0.423 n=6
Bind Time 5.03s (± 1.83%) 5.03s (± 1.84%) ~ 4.99s 5.22s p=0.360 n=6
Check Time 88.44s (± 0.55%) 88.51s (± 0.39%) ~ 88.07s 89.05s p=0.936 n=6
Emit Time 26.90s (± 8.73%) 26.31s (± 7.52%) ~ 23.85s 28.53s p=0.521 n=6
Total Time 137.09s (± 1.50%) 136.60s (± 1.43%) ~ 133.94s 138.64s p=0.575 n=6
webpack - node (v18.15.0, x64)
Errors 0 (± 0.00%) 0 (± 0.00%) ~ 0 0 p=1.000 n=6
Symbols 265,593 (± 0.00%) 265,593 (± 0.00%) ~ 265,593 265,593 p=1.000 n=6
Types 108,389 (± 0.00%) 108,389 (± 0.00%) ~ 108,389 108,389 p=1.000 n=6
Memory used 409,798k (± 0.01%) 409,750k (± 0.01%) ~ 409,701k 409,810k p=0.054 n=6
Parse Time 3.28s (± 0.81%) 3.26s (± 0.60%) ~ 3.25s 3.30s p=0.284 n=6
Bind Time 1.36s (± 0.72%) 1.36s (± 1.10%) ~ 1.34s 1.38s p=0.730 n=6
Check Time 14.43s (± 0.12%) 14.43s (± 0.14%) ~ 14.40s 14.45s p=0.807 n=6
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) ~ 0.00s 0.00s p=1.000 n=6
Total Time 19.07s (± 0.24%) 19.05s (± 0.11%) ~ 19.03s 19.08s p=0.629 n=6
xstate-main - node (v18.15.0, x64)
Errors 0 (± 0.00%) 0 (± 0.00%) ~ 0 0 p=1.000 n=6
Symbols 519,608 (± 0.00%) 519,608 (± 0.00%) ~ 519,608 519,608 p=1.000 n=6
Types 178,842 (± 0.00%) 178,842 (± 0.00%) ~ 178,842 178,842 p=1.000 n=6
Memory used 459,394k (± 0.01%) 459,351k (± 0.01%) ~ 459,276k 459,475k p=0.471 n=6
Parse Time 4.02s (± 0.85%) 4.00s (± 0.46%) ~ 3.98s 4.02s p=0.415 n=6
Bind Time 1.47s (± 1.11%) 1.48s (± 0.60%) ~ 1.47s 1.49s p=0.563 n=6
Check Time 22.31s (± 0.76%) 22.30s (± 0.28%) ~ 22.19s 22.35s p=0.378 n=6
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) ~ 0.00s 0.00s p=1.000 n=6
Total Time 27.81s (± 0.50%) 27.78s (± 0.19%) ~ 27.69s 27.84s p=0.470 n=6
System info unknown
Hosts
  • node (v18.15.0, x64)
Scenarios
  • Compiler-Unions - node (v18.15.0, x64)
  • angular-1 - node (v18.15.0, x64)
  • mui-docs - node (v18.15.0, x64)
  • self-build-src - node (v18.15.0, x64)
  • self-build-src-public-api - node (v18.15.0, x64)
  • self-compiler - node (v18.15.0, x64)
  • ts-pre-modules - node (v18.15.0, x64)
  • vscode - node (v18.15.0, x64)
  • webpack - node (v18.15.0, x64)
  • xstate-main - node (v18.15.0, x64)
Benchmark Name Iterations
Current pr 6
Baseline baseline 6

tsserver

Comparison Report - baseline..pr
Metric baseline pr Delta Best Worst p-value
Compiler-UnionsTSServer - node (v18.15.0, x64)
Req 1 - updateOpen 2,352ms (± 0.53%) 2,364ms (± 1.01%) ~ 2,337ms 2,400ms p=0.575 n=6
Req 2 - geterr 5,115ms (± 0.30%) 5,101ms (± 0.62%) ~ 5,065ms 5,149ms p=0.298 n=6
Req 3 - references 286ms (± 0.65%) 287ms (± 1.89%) ~ 282ms 296ms p=1.000 n=6
Req 4 - navto 228ms (± 1.03%) 229ms (± 0.46%) ~ 227ms 230ms p=0.744 n=6
Req 5 - completionInfo count 1,357 (± 0.00%) 1,357 (± 0.00%) ~ 1,357 1,357 p=1.000 n=6
Req 5 - completionInfo 86ms (± 6.39%) 80ms (± 3.31%) ~ 77ms 83ms p=0.119 n=6
CompilerTSServer - node (v18.15.0, x64)
Req 1 - updateOpen 2,483ms (± 0.56%) 2,500ms (± 0.61%) ~ 2,482ms 2,522ms p=0.066 n=6
Req 2 - geterr 3,829ms (± 0.31%) 3,837ms (± 0.20%) ~ 3,825ms 3,846ms p=0.128 n=6
Req 3 - references 301ms (± 0.72%) 300ms (± 0.50%) ~ 299ms 303ms p=1.000 n=6
Req 4 - navto 227ms (± 0.23%) 228ms (± 0.33%) ~ 227ms 229ms p=0.247 n=6
Req 5 - completionInfo count 1,519 (± 0.00%) 1,519 (± 0.00%) ~ 1,519 1,519 p=1.000 n=6
Req 5 - completionInfo 73ms (± 1.35%) 73ms (± 7.70%) ~ 68ms 84ms p=0.454 n=6
xstate-main-1-tsserver - node (v18.15.0, x64)
Req 1 - updateOpen 5,180ms (± 0.14%) 5,190ms (± 0.12%) +10ms (+ 0.20%) 5,179ms 5,196ms p=0.030 n=6
Req 2 - geterr 1,128ms (± 0.89%) 1,133ms (± 1.09%) ~ 1,123ms 1,151ms p=0.470 n=6
Req 3 - references 87ms (± 3.69%) 85ms (± 0.96%) ~ 84ms 86ms p=0.112 n=6
Req 4 - navto 449ms (± 0.53%) 449ms (± 0.74%) ~ 446ms 454ms p=0.935 n=6
Req 5 - completionInfo count 3,413 (± 0.00%) 3,413 (± 0.00%) ~ 3,413 3,413 p=1.000 n=6
Req 5 - completionInfo 849ms (± 2.40%) 842ms (± 1.99%) ~ 829ms 866ms p=0.334 n=6
System info unknown
Hosts
  • node (v18.15.0, x64)
Scenarios
  • CompilerTSServer - node (v18.15.0, x64)
  • Compiler-UnionsTSServer - node (v18.15.0, x64)
  • xstate-main-1-tsserver - node (v18.15.0, x64)
Benchmark Name Iterations
Current pr 6
Baseline baseline 6

startup

Comparison Report - baseline..pr
Metric baseline pr Delta Best Worst p-value
tsc-startup - node (v18.15.0, x64)
Execution time 156.44ms (± 0.16%) 156.40ms (± 0.15%) ~ 155.57ms 159.87ms p=0.464 n=600
tsserver-startup - node (v18.15.0, x64)
Execution time 239.23ms (± 0.13%) 239.18ms (± 0.13%) ~ 237.87ms 241.98ms p=0.142 n=600
tsserverlibrary-startup - node (v18.15.0, x64)
Execution time 235.47ms (± 0.14%) 235.29ms (± 0.15%) -0.18ms (- 0.07%) 233.84ms 240.21ms p=0.000 n=600
typescript-startup - node (v18.15.0, x64)
Execution time 235.23ms (± 0.16%) 235.23ms (± 0.15%) ~ 233.89ms 238.68ms p=0.897 n=600
System info unknown
Hosts
  • node (v18.15.0, x64)
Scenarios
  • tsc-startup - node (v18.15.0, x64)
  • tsserver-startup - node (v18.15.0, x64)
  • tsserverlibrary-startup - node (v18.15.0, x64)
  • typescript-startup - node (v18.15.0, x64)
Benchmark Name Iterations
Current pr 6
Baseline baseline 6

Developer Information:

Download Benchmarks

@jakebailey
Copy link
Member

jakebailey commented Apr 24, 2024

Tested, and the test does actually test the crash, nice.

@jakebailey jakebailey merged commit 5b69fdf into microsoft:main Apr 24, 2024
@microsoft microsoft locked as resolved and limited conversation to collaborators Oct 16, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@andrewbranch andrewbranch andrewbranch approved these changes

@jakebailey jakebailey jakebailey approved these changes

@weswigham weswigham Awaiting requested review from weswigham

@gabritto gabritto Awaiting requested review from gabritto

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[ServerErrors][JavaScript] 5.5.0-dev.20240324

5 participants

@armanio123 @gabritto @typescript-bot @jakebailey @andrewbranch