`visitNodesWithoutCopyingPositions` always makes a new `NodeArray` by iisaduan · Pull Request #59137 · microsoft/TypeScript

iisaduan · 2024-07-03T23:42:54Z

The original call assumed createNodeArray always makes a new NodeArray, however, in some instances (when there are no changes to the NodeArray), the original array returns. Unpacking the array makes sure that a new NodeArray is always created.

(Side note: As a lot of nodeFactory functions make a distinction between when it is always new node vs it is possible to return the old one, ie createT vs updateT, createNodeArray doesn't currently follow that convention. A bigger version of this PR would be to change the behavior of createNodeArray (such as #59135, but it could/would have other side effects), or to make two ___NodeArray functions that makes this distinction)

iisaduan · 2024-07-03T23:43:15Z

@typescript-bot perf test this

typescript-bot · 2024-07-03T23:43:18Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`perf test this`	✅ Started	👀 Results

DanielRosenwasser · 2024-07-03T23:50:42Z

src/compiler/checker.ts

                        if (result.pos !== -1 || result.end !== -1) {
                            if (result === nodes) {
-                                result = factory.createNodeArray(nodes, nodes.hasTrailingComma);
+                                result = factory.createNodeArray([...nodes], nodes.hasTrailingComma);


I believe slice() tends to be a little faster than spreading since engines have to do shenanigans to support non-array iterables.

Suggested change

result = factory.createNodeArray([...nodes], nodes.hasTrailingComma);

result = factory.createNodeArray(nodes.slice(), nodes.hasTrailingComma);

typescript-bot · 2024-07-04T00:22:21Z

@iisaduan
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - node (v18.15.0, x64)}
_Errors	₃₀	₃₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_62,153	_62,153	_~	_~	_~	_{p=1.000 n=6}
_Types	_50,242	_50,242	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{194,051k (± 1.00%)}	_{194,056k (± 1.00%)}	_~	_192,142k	_195,895k	_{p=1.000 n=6}
_{Parse Time}	_{1.58s (± 0.33%)}	_{1.58s (± 0.76%)}	_~	_1.57s	_1.60s	_{p=0.351 n=6}
_{Bind Time}	_{0.85s (± 0.98%)}	_{0.86s (± 1.14%)}	_~	_0.84s	_0.87s	_{p=0.396 n=6}
_{Check Time}	_{11.22s (± 0.26%)}	_{11.23s (± 0.43%)}	_~	_11.15s	_11.29s	_{p=0.627 n=6}
_{Emit Time}	_{3.29s (± 0.41%)}	_{3.28s (± 0.63%)}	_~	_3.25s	_3.31s	_{p=0.119 n=6}
_{Total Time}	_{16.95s (± 0.18%)}	_{16.95s (± 0.37%)}	_~	_16.87s	_17.02s	_{p=0.872 n=6}
_{angular-1 - node (v18.15.0, x64)}
_Errors	₅	₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_944,114	_944,114	_~	_~	_~	_{p=1.000 n=6}
_Types	_407,050	_407,050	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{1,218,295k (± 0.00%)}	_{1,218,348k (± 0.00%)}	_{+53k (+ 0.00%)}	_1,218,311k	_1,218,381k	_{p=0.031 n=6}
_{Parse Time}	_{7.96s (± 0.93%)}	_{7.99s (± 0.45%)}	_~	_7.95s	_8.04s	_{p=0.296 n=6}
_{Bind Time}	_{2.22s (± 0.23%)}	_2.22s	_~	_~	_~	_{p=0.174 n=6}
_{Check Time}	_{35.78s (± 0.29%)}	_{35.85s (± 0.18%)}	_~	_35.76s	_35.92s	_{p=0.297 n=6}
_{Emit Time}	_{16.23s (± 0.46%)}	_{16.13s (± 0.39%)}	_~	_16.06s	_16.21s	_{p=0.066 n=6}
_{Total Time}	_{62.19s (± 0.28%)}	_{62.19s (± 0.16%)}	_~	_62.02s	_62.29s	_{p=0.936 n=6}
_{mui-docs - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,129,960	_2,129,960	_~	_~	_~	_{p=1.000 n=6}
_Types	_927,566	_927,566	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,104,757k (± 0.01%)}	_{2,105,157k (± 0.05%)}	_~	_2,104,631k	_2,107,311k	_{p=0.810 n=6}
_{Parse Time}	_{9.60s (± 0.36%)}	_{9.62s (± 0.51%)}	_~	_9.54s	_9.68s	_{p=0.628 n=6}
_{Bind Time}	_{3.38s (± 0.61%)}	_{3.37s (± 0.35%)}	_~	_3.35s	_3.38s	_{p=0.622 n=6}
_{Check Time}	_{100.60s (± 1.28%)}	_{101.30s (± 1.03%)}	_~	_99.44s	_102.20s	_{p=0.378 n=6}
_{Emit Time}	_{0.20s (± 4.15%)}	_{0.40s (±124.30%)}	_~	_0.19s	_1.41s	_{p=0.666 n=6}
_{Total Time}	_{113.77s (± 1.10%)}	_{114.68s (± 0.57%)}	_~	_113.91s	_115.39s	_{p=0.298 n=6}
_{self-build-src - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,225,496	_1,225,530	_{+34 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_261,459	_261,460	_{+1 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,341,324k (± 0.03%)}	_{2,341,542k (± 0.07%)}	_~	_2,339,616k	_2,343,996k	_{p=0.936 n=6}
_{Parse Time}	_{7.56s (± 0.51%)}	_{7.48s (± 0.50%)}	_{-0.08s (- 1.04%)}	_7.44s	_7.54s	_{p=0.013 n=6}
_{Bind Time}	_{2.80s (± 0.61%)}	_{2.80s (± 0.89%)}	_~	_2.77s	_2.83s	_{p=0.688 n=6}
_{Check Time}	_{49.71s (± 0.70%)}	_{49.68s (± 0.44%)}	_~	_49.38s	_49.91s	_{p=0.936 n=6}
_{Emit Time}	_{3.98s (± 3.19%)}	_{3.89s (± 5.07%)}	_~	_3.65s	_4.19s	_{p=0.298 n=6}
_{Total Time}	_{64.07s (± 0.56%)}	_{63.87s (± 0.52%)}	_~	_63.39s	_64.20s	_{p=0.689 n=6}
_{self-build-src-public-api - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,225,496	_1,225,530	_{+34 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_261,459	_261,460	_{+1 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,415,743k (± 0.03%)}	_{2,416,019k (± 0.02%)}	_~	_2,415,233k	_2,416,512k	_{p=0.471 n=6}
_{Parse Time}	_{7.77s (± 0.85%)}	_{7.76s (± 1.11%)}	_~	_7.62s	_7.85s	_{p=1.000 n=6}
_{Bind Time}	_{2.52s (± 0.70%)}	_{2.52s (± 1.22%)}	_~	_2.48s	_2.55s	_{p=0.744 n=6}
_{Check Time}	_{50.21s (± 0.19%)}	_{50.27s (± 0.68%)}	_~	_49.84s	_50.87s	_{p=0.936 n=6}
_{Emit Time}	_{3.88s (± 1.12%)}	_{3.95s (± 3.15%)}	_~	_3.81s	_4.12s	_{p=0.810 n=6}
_{Total Time}	_{64.38s (± 0.30%)}	_{64.52s (± 0.72%)}	_~	_64.00s	_65.37s	_{p=0.689 n=6}
_{self-compiler - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_258,194	_258,228	_{+34 (+ 0.01%)}	_~	_~	_{p=0.001 n=6}
_Types	_104,737	_104,738	_{+1 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{427,499k (± 0.01%)}	_{427,532k (± 0.02%)}	_~	_427,470k	_427,715k	_{p=0.630 n=6}
_{Parse Time}	_{3.28s (± 0.52%)}	_{3.29s (± 0.63%)}	_~	_3.27s	_3.32s	_{p=0.287 n=6}
_{Bind Time}	_{1.33s (± 0.78%)}	_{1.32s (± 0.62%)}	_~	_1.31s	_1.33s	_{p=0.546 n=6}
_{Check Time}	_{17.86s (± 0.35%)}	_{17.84s (± 0.29%)}	_~	_17.78s	_17.92s	_{p=0.748 n=6}
_{Emit Time}	_{1.26s (± 1.64%)}	_{1.25s (± 1.34%)}	_~	_1.23s	_1.27s	_{p=0.570 n=6}
_{Total Time}	_{23.73s (± 0.32%)}	_{23.71s (± 0.18%)}	_~	_23.67s	_23.77s	_{p=0.688 n=6}
_{ts-pre-modules - node (v18.15.0, x64)}
_Errors	₃₅	₃₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_224,565	_224,565	_~	_~	_~	_{p=1.000 n=6}
_Types	_93,734	_93,734	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{369,451k (± 0.02%)}	_{369,472k (± 0.04%)}	_~	_369,337k	_369,749k	_{p=0.936 n=6}
_{Parse Time}	_{2.76s (± 0.84%)}	_{2.78s (± 0.99%)}	_~	_2.74s	_2.81s	_{p=0.195 n=6}
_{Bind Time}	_{1.59s (± 0.74%)}	_{1.58s (± 0.40%)}	_~	_1.57s	_1.59s	_{p=0.179 n=6}
_{Check Time}	_{15.50s (± 0.38%)}	_{15.46s (± 0.35%)}	_~	_15.39s	_15.54s	_{p=0.261 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{19.85s (± 0.34%)}	_{19.82s (± 0.29%)}	_~	_19.73s	_19.88s	_{p=0.335 n=6}
_{vscode - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,881,144	_2,881,144	_~	_~	_~	_{p=1.000 n=6}
_Types	_975,520	_975,520	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{3,044,034k (± 0.00%)}	_{3,044,033k (± 0.00%)}	_~	_3,043,945k	_3,044,074k	_{p=1.000 n=6}
_{Parse Time}	_{13.63s (± 0.25%)}	_{13.72s (± 0.32%)}	_{+0.09s (+ 0.66%)}	_13.67s	_13.78s	_{p=0.005 n=6}
_{Bind Time}	_{4.22s (± 2.70%)}	_{4.25s (± 2.94%)}	_~	_4.13s	_4.38s	_{p=0.746 n=6}
_{Check Time}	_{74.22s (± 2.20%)}	_{72.86s (± 0.42%)}	_~	_72.55s	_73.31s	_{p=0.148 n=6}
_{Emit Time}	_{22.73s (± 6.78%)}	_{24.07s (± 0.37%)}	_{🔻+1.34s (+ 5.90%)}	_23.95s	_24.15s	_{p=0.031 n=6}
_{Total Time}	_{114.80s (± 0.38%)}	_{114.90s (± 0.37%)}	_~	_114.41s	_115.49s	_{p=0.936 n=6}
_{webpack - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_267,117	_267,117	_~	_~	_~	_{p=1.000 n=6}
_Types	_108,775	_108,775	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{411,555k (± 0.01%)}	_{411,516k (± 0.01%)}	_~	_411,443k	_411,622k	_{p=0.230 n=6}
_{Parse Time}	_{3.17s (± 0.68%)}	_{3.18s (± 0.54%)}	_~	_3.15s	_3.20s	_{p=0.746 n=6}
_{Bind Time}	_{1.42s (± 0.82%)}	_{1.42s (± 0.39%)}	_~	_1.41s	_1.42s	_{p=0.859 n=6}
_{Check Time}	_{14.20s (± 0.27%)}	_{14.17s (± 0.32%)}	_~	_14.11s	_14.25s	_{p=0.366 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{18.79s (± 0.22%)}	_{18.76s (± 0.30%)}	_~	_18.72s	_18.87s	_{p=0.198 n=6}
_{xstate-main - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_525,251	_525,251	_~	_~	_~	_{p=1.000 n=6}
_Types	_178,574	_178,574	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{462,881k (± 0.08%)}	_{462,908k (± 0.08%)}	_~	_462,420k	_463,306k	_{p=0.575 n=6}
_{Parse Time}	_{2.65s (± 0.41%)}	_{2.65s (± 0.48%)}	_~	_2.63s	_2.66s	_{p=0.869 n=6}
_{Bind Time}	_{0.98s (± 0.77%)}	_{0.98s (± 0.42%)}	_~	_0.97s	_0.98s	_{p=1.000 n=6}
_{Check Time}	_{15.16s (± 0.35%)}	_{15.20s (± 0.39%)}	_~	_15.14s	_15.30s	_{p=0.375 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{18.79s (± 0.26%)}	_{18.83s (± 0.33%)}	_~	_18.77s	_18.93s	_{p=0.422 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Compiler-Unions - node (v18.15.0, x64)
angular-1 - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-build-src-public-api - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
ts-pre-modules - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate-main - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

tsserver

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-UnionsTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{2,755ms (± 0.96%)}	_{2,780ms (± 0.53%)}	_~	_2,757ms	_2,797ms	_{p=0.065 n=6}
_{Req 2 - geterr}	_{6,497ms (±11.04%)}	_{6,691ms (±10.58%)}	_~	_5,989ms	_7,370ms	_{p=0.810 n=6}
_{Req 3 - references}	_{357ms (±11.34%)}	_{374ms (± 8.91%)}	_~	_319ms	_396ms	_{p=0.419 n=6}
_{Req 4 - navto}	_{317ms (± 9.39%)}	_{329ms (± 7.32%)}	_~	_280ms	_340ms	_{p=0.744 n=6}
_{Req 5 - completionInfo count}	_1,357	_1,357	_~	_~	_~	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{125ms (± 8.73%)}	_{128ms (± 8.49%)}	_~	_107ms	_139ms	_{p=1.000 n=6}
_{CompilerTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{2,408ms (± 0.76%)}	_{2,426ms (± 0.44%)}	_~	_2,408ms	_2,437ms	_{p=0.149 n=6}
_{Req 2 - geterr}	_{3,789ms (± 0.31%)}	_{3,793ms (± 0.49%)}	_~	_3,776ms	_3,824ms	_{p=1.000 n=6}
_{Req 3 - references}	_{276ms (± 0.15%)}	_{276ms (± 0.49%)}	_~	_275ms	_278ms	_{p=0.929 n=6}
_{Req 4 - navto}	_{226ms (± 0.18%)}	_{226ms (± 0.52%)}	_~	_225ms	_228ms	_{p=0.858 n=6}
_{Req 5 - completionInfo count}	_1,519	_1,519	_~	_~	_~	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{71ms (± 3.65%)}	_{75ms (± 5.67%)}	_~	_72ms	_83ms	_{p=0.161 n=6}
_{xstate-main-1-tsserver - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{5,202ms (± 0.59%)}	_{5,223ms (± 0.82%)}	_~	_5,157ms	_5,275ms	_{p=0.230 n=6}
_{Req 2 - geterr}	_{1,132ms (± 1.19%)}	_{1,129ms (± 0.89%)}	_~	_1,119ms	_1,145ms	_{p=0.872 n=6}
_{Req 3 - references}	_{77ms (± 3.67%)}	_{76ms (± 2.10%)}	_~	_75ms	_79ms	_{p=1.000 n=6}
_{Req 4 - navto}	_{457ms (± 0.29%)}	_{458ms (± 0.18%)}	_~	_457ms	_459ms	_{p=0.619 n=6}
_{Req 5 - completionInfo count}	_3,413	_3,413	_~	_~	_~	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{833ms (± 0.82%)}	_{831ms (± 1.34%)}	_~	_812ms	_843ms	_{p=0.936 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

CompilerTSServer - node (v18.15.0, x64)
Compiler-UnionsTSServer - node (v18.15.0, x64)
xstate-main-1-tsserver - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

startup

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{tsc-startup - node (v18.15.0, x64)}
_{Execution time}	_{157.75ms (± 0.16%)}	_{157.70ms (± 0.18%)}	_{-0.05ms (- 0.03%)}	_156.64ms	_162.20ms	_{p=0.009 n=600}
_{tsserver-startup - node (v18.15.0, x64)}
_{Execution time}	_{230.65ms (± 0.12%)}	_{230.65ms (± 0.19%)}	_~	_229.19ms	_241.67ms	_{p=0.075 n=600}
_{tsserverlibrary-startup - node (v18.15.0, x64)}
_{Execution time}	_{227.26ms (± 0.13%)}	_{227.31ms (± 0.16%)}	_~	_225.76ms	_231.35ms	_{p=0.454 n=600}
_{typescript-startup - node (v18.15.0, x64)}
_{Execution time}	_{226.80ms (± 0.14%)}	_{226.86ms (± 0.16%)}	_~	_225.46ms	_229.48ms	_{p=0.214 n=600}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

tsc-startup - node (v18.15.0, x64)
tsserver-startup - node (v18.15.0, x64)
tsserverlibrary-startup - node (v18.15.0, x64)
typescript-startup - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

iisaduan · 2024-07-05T23:05:01Z

@typescript-bot perf test this

typescript-bot · 2024-07-05T23:05:05Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`perf test this`	✅ Started	👀 Results

typescript-bot · 2024-07-05T23:41:12Z

@iisaduan
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - node (v18.15.0, x64)}
_Errors	₃₀	₃₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_62,153	_62,153	_~	_~	_~	_{p=1.000 n=6}
_Types	_50,242	_50,242	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{193,308k (± 0.99%)}	_{193,804k (± 1.01%)}	_~	_191,794k	_195,683k	_{p=0.936 n=6}
_{Parse Time}	_{1.95s (± 0.78%)}	_{1.95s (± 0.82%)}	_~	_1.93s	_1.97s	_{p=0.568 n=6}
_{Bind Time}	_{1.07s (± 0.97%)}	_{1.06s (± 1.54%)}	_~	_1.04s	_1.08s	_{p=0.286 n=6}
_{Check Time}	_{13.84s (± 0.56%)}	_{13.79s (± 0.53%)}	_~	_13.71s	_13.91s	_{p=0.229 n=6}
_{Emit Time}	_{4.05s (± 2.25%)}	_{4.13s (± 4.47%)}	_~	_3.99s	_4.39s	_{p=0.628 n=6}
_{Total Time}	_{20.91s (± 0.53%)}	_{20.93s (± 1.22%)}	_~	_20.71s	_21.28s	_{p=0.689 n=6}
_{angular-1 - node (v18.15.0, x64)}
_Errors	₅	₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_944,114	_944,114	_~	_~	_~	_{p=1.000 n=6}
_Types	_407,050	_407,050	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{1,218,357k (± 0.00%)}	_{1,218,356k (± 0.00%)}	_~	_1,218,306k	_1,218,408k	_{p=0.936 n=6}
_{Parse Time}	_{7.94s (± 0.58%)}	_{7.99s (± 0.62%)}	_~	_7.92s	_8.05s	_{p=0.126 n=6}
_{Bind Time}	_{2.22s (± 0.18%)}	_{2.22s (± 0.44%)}	_~	_2.21s	_2.23s	_{p=0.930 n=6}
_{Check Time}	_{35.75s (± 0.26%)}	_{35.83s (± 0.35%)}	_~	_35.66s	_35.97s	_{p=0.298 n=6}
_{Emit Time}	_{16.19s (± 0.35%)}	_{16.17s (± 0.57%)}	_~	_16.06s	_16.28s	_{p=0.873 n=6}
_{Total Time}	_{62.09s (± 0.23%)}	_{62.21s (± 0.25%)}	_~	_62.05s	_62.47s	_{p=0.335 n=6}
_{mui-docs - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,130,140	_2,130,140	_~	_~	_~	_{p=1.000 n=6}
_Types	_927,634	_927,634	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,106,234k (± 0.01%)}	_{2,106,183k (± 0.01%)}	_~	_2,105,900k	_2,106,342k	_{p=0.936 n=6}
_{Parse Time}	_{9.68s (± 0.49%)}	_{9.67s (± 0.71%)}	_~	_9.58s	_9.77s	_{p=1.000 n=6}
_{Bind Time}	_{3.39s (± 0.61%)}	_{3.41s (± 0.66%)}	_~	_3.39s	_3.45s	_{p=0.122 n=6}
_{Check Time}	_{101.62s (± 1.22%)}	_{100.97s (± 1.57%)}	_~	_99.23s	_102.66s	_{p=0.471 n=6}
_{Emit Time}	_{0.20s (± 3.79%)}	_{0.39s (±122.26%)}	_~	_0.19s	_1.37s	_{p=1.000 n=6}
_{Total Time}	_{114.88s (± 1.05%)}	_{114.44s (± 1.22%)}	_~	_112.64s	_115.95s	_{p=0.873 n=6}
_{self-build-src - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,225,497	_1,225,497	_~	_~	_~	_{p=1.000 n=6}
_Types	_261,459	_261,459	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,341,676k (± 0.03%)}	_{2,342,668k (± 0.04%)}	_~	_2,341,420k	_2,344,373k	_{p=0.128 n=6}
_{Parse Time}	_{7.50s (± 0.50%)}	_{7.55s (± 0.49%)}	_{+0.06s (+ 0.78%)}	_7.51s	_7.60s	_{p=0.031 n=6}
_{Bind Time}	_{2.79s (± 0.69%)}	_{2.79s (± 0.67%)}	_~	_2.78s	_2.83s	_{p=0.628 n=6}
_{Check Time}	_{49.48s (± 0.27%)}	_{49.59s (± 0.17%)}	_~	_49.47s	_49.70s	_{p=0.173 n=6}
_{Emit Time}	_{3.84s (± 3.16%)}	_{3.85s (± 4.12%)}	_~	_3.68s	_4.14s	_{p=0.936 n=6}
_{Total Time}	_{63.61s (± 0.26%)}	_{63.80s (± 0.19%)}	_~	_63.55s	_63.88s	_{p=0.066 n=6}
_{self-build-src-public-api - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,225,497	_1,225,497	_~	_~	_~	_{p=1.000 n=6}
_Types	_261,459	_261,459	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,415,097k (± 0.04%)}	_{2,415,467k (± 0.03%)}	_~	_2,414,558k	_2,416,497k	_{p=0.471 n=6}
_{Parse Time}	_{6.29s (± 0.98%)}	_{6.28s (± 0.97%)}	_~	_6.19s	_6.35s	_{p=0.936 n=6}
_{Bind Time}	_{2.03s (± 0.76%)}	_{2.01s (± 0.68%)}	_~	_1.99s	_2.03s	_{p=0.079 n=6}
_{Check Time}	_{40.84s (± 0.67%)}	_{40.88s (± 0.74%)}	_~	_40.55s	_41.44s	_{p=0.936 n=6}
_{Emit Time}	_{3.17s (± 2.66%)}	_{3.15s (± 3.69%)}	_~	_3.01s	_3.31s	_{p=0.936 n=6}
_{Total Time}	_{52.34s (± 0.62%)}	_{52.34s (± 0.70%)}	_~	_52.04s	_53.05s	_{p=0.936 n=6}
_{self-compiler - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_258,195	_258,195	_~	_~	_~	_{p=1.000 n=6}
_Types	_104,737	_104,737	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{427,483k (± 0.01%)}	_{427,457k (± 0.01%)}	_~	_427,402k	_427,484k	_{p=0.575 n=6}
_{Parse Time}	_{4.08s (± 0.43%)}	_{4.08s (± 0.48%)}	_~	_4.05s	_4.10s	_{p=0.867 n=6}
_{Bind Time}	_{1.62s (± 1.54%)}	_{1.63s (± 1.01%)}	_~	_1.61s	_1.65s	_{p=1.000 n=6}
_{Check Time}	_{22.00s (± 0.30%)}	_{21.94s (± 0.31%)}	_~	_21.87s	_22.05s	_{p=0.148 n=6}
_{Emit Time}	_{1.55s (± 1.03%)}	_{1.54s (± 1.27%)}	_~	_1.52s	_1.57s	_{p=0.557 n=6}
_{Total Time}	_{29.25s (± 0.25%)}	_{29.18s (± 0.31%)}	_~	_29.10s	_29.33s	_{p=0.199 n=6}
_{ts-pre-modules - node (v18.15.0, x64)}
_Errors	₃₅	₃₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_224,565	_224,565	_~	_~	_~	_{p=1.000 n=6}
_Types	_93,734	_93,734	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{369,533k (± 0.02%)}	_{369,511k (± 0.03%)}	_~	_369,367k	_369,724k	_{p=0.575 n=6}
_{Parse Time}	_{2.77s (± 1.34%)}	_{2.77s (± 0.55%)}	_~	_2.75s	_2.79s	_{p=0.681 n=6}
_{Bind Time}	_{1.58s (± 1.23%)}	_{1.59s (± 1.08%)}	_~	_1.57s	_1.61s	_{p=0.408 n=6}
_{Check Time}	_{15.48s (± 0.31%)}	_{15.47s (± 0.43%)}	_~	_15.39s	_15.54s	_{p=1.000 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{19.83s (± 0.28%)}	_{19.83s (± 0.35%)}	_~	_19.74s	_19.90s	_{p=1.000 n=6}
_{vscode - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,882,184	_2,882,184	_~	_~	_~	_{p=1.000 n=6}
_Types	_975,716	_975,716	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{3,045,406k (± 0.00%)}	_{3,045,434k (± 0.00%)}	_~	_3,045,350k	_3,045,596k	_{p=0.575 n=6}
_{Parse Time}	_{13.75s (± 0.36%)}	_{13.72s (± 0.08%)}	_~	_13.70s	_13.73s	_{p=0.746 n=6}
_{Bind Time}	_{4.19s (± 0.47%)}	_{4.22s (± 1.94%)}	_~	_4.17s	_4.38s	_{p=0.935 n=6}
_{Check Time}	_{73.72s (± 0.44%)}	_{73.81s (± 1.00%)}	_~	_73.34s	_75.28s	_{p=0.689 n=6}
_{Emit Time}	_{23.96s (± 0.50%)}	_{23.66s (± 3.49%)}	_~	_21.98s	_24.11s	_{p=1.000 n=6}
_{Total Time}	_{115.61s (± 0.35%)}	_{115.40s (± 0.21%)}	_~	_115.13s	_115.84s	_{p=0.378 n=6}
_{webpack - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_267,117	_267,117	_~	_~	_~	_{p=1.000 n=6}
_Types	_108,775	_108,775	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{411,552k (± 0.01%)}	_{411,521k (± 0.02%)}	_~	_411,435k	_411,607k	_{p=0.423 n=6}
_{Parse Time}	_{3.17s (± 0.69%)}	_{3.18s (± 0.31%)}	_~	_3.17s	_3.19s	_{p=0.622 n=6}
_{Bind Time}	_{1.41s (± 0.29%)}	_{1.42s (± 0.53%)}	_~	_1.41s	_1.43s	_{p=0.100 n=6}
_{Check Time}	_{14.20s (± 0.30%)}	_{14.18s (± 0.37%)}	_~	_14.12s	_14.26s	_{p=0.747 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{18.78s (± 0.30%)}	_{18.78s (± 0.28%)}	_~	_18.72s	_18.87s	_{p=0.872 n=6}
_{xstate-main - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_525,251	_525,251	_~	_~	_~	_{p=1.000 n=6}
_Types	_178,574	_178,574	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{462,817k (± 0.07%)}	_{462,939k (± 0.07%)}	_~	_462,433k	_463,358k	_{p=0.378 n=6}
_{Parse Time}	_{2.64s (± 0.70%)}	_{2.64s (± 0.50%)}	_~	_2.62s	_2.66s	_{p=0.452 n=6}
_{Bind Time}	_0.98s	_{0.98s (± 0.64%)}	_~	_0.97s	_0.99s	_{p=1.000 n=6}
_{Check Time}	_{15.17s (± 0.37%)}	_{15.16s (± 0.30%)}	_~	_15.10s	_15.22s	_{p=0.630 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{18.79s (± 0.27%)}	_{18.77s (± 0.26%)}	_~	_18.72s	_18.86s	_{p=0.573 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Compiler-Unions - node (v18.15.0, x64)
angular-1 - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-build-src-public-api - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
ts-pre-modules - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate-main - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

tsserver

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-UnionsTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{3,426ms (± 0.43%)}	_{3,415ms (± 0.56%)}	_~	_3,387ms	_3,439ms	_{p=0.422 n=6}
_{Req 2 - geterr}	_{7,480ms (± 0.56%)}	_{7,476ms (± 0.33%)}	_~	_7,438ms	_7,514ms	_{p=1.000 n=6}
_{Req 3 - references}	_{393ms (± 0.37%)}	_{394ms (± 0.34%)}	_~	_392ms	_396ms	_{p=0.112 n=6}
_{Req 4 - navto}	_{337ms (± 0.63%)}	_{338ms (± 0.15%)}	_~	_338ms	_339ms	_{p=0.242 n=6}
_{Req 5 - completionInfo count}	_1,357	_1,357	_~	_~	_~	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{130ms (± 1.37%)}	_{129ms (± 1.14%)}	_~	_128ms	_131ms	_{p=0.411 n=6}
_{CompilerTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{2,417ms (± 0.36%)}	_{2,421ms (± 1.09%)}	_~	_2,378ms	_2,451ms	_{p=0.630 n=6}
_{Req 2 - geterr}	_{3,801ms (± 0.36%)}	_{3,796ms (± 0.19%)}	_~	_3,787ms	_3,805ms	_{p=0.378 n=6}
_{Req 3 - references}	_{276ms (± 0.85%)}	_{277ms (± 0.42%)}	_~	_275ms	_278ms	_{p=1.000 n=6}
_{Req 4 - navto}	_{229ms (± 2.45%)}	_{226ms (± 0.23%)}	_~	_226ms	_227ms	_{p=0.437 n=6}
_{Req 5 - completionInfo count}	_1,519	_1,519	_~	_~	_~	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{73ms (± 7.50%)}	_{74ms (± 7.96%)}	_~	_67ms	_85ms	_{p=0.805 n=6}
_{xstate-main-1-tsserver - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{5,183ms (± 0.40%)}	_{5,185ms (± 0.38%)}	_~	_5,162ms	_5,221ms	_{p=0.630 n=6}
_{Req 2 - geterr}	_{1,124ms (± 0.81%)}	_{1,127ms (± 1.26%)}	_~	_1,107ms	_1,147ms	_{p=0.573 n=6}
_{Req 3 - references}	_{77ms (± 6.31%)}	_{76ms (± 4.35%)}	_~	_74ms	_83ms	_{p=0.737 n=6}
_{Req 4 - navto}	_{459ms (± 1.07%)}	_{457ms (± 0.16%)}	_~	_456ms	_458ms	_{p=0.797 n=6}
_{Req 5 - completionInfo count}	_3,413	_3,413	_~	_~	_~	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{833ms (± 2.29%)}	_{834ms (± 2.09%)}	_~	_816ms	_865ms	_{p=0.936 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

CompilerTSServer - node (v18.15.0, x64)
Compiler-UnionsTSServer - node (v18.15.0, x64)
xstate-main-1-tsserver - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

startup

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{tsc-startup - node (v18.15.0, x64)}
_{Execution time}	_{157.05ms (± 0.17%)}	_{157.19ms (± 0.21%)}	_{+0.14ms (+ 0.09%)}	_156.08ms	_162.18ms	_{p=0.000 n=600}
_{tsserver-startup - node (v18.15.0, x64)}
_{Execution time}	_{232.18ms (± 0.13%)}	_{232.01ms (± 0.14%)}	_{-0.16ms (- 0.07%)}	_230.73ms	_237.68ms	_{p=0.000 n=600}
_{tsserverlibrary-startup - node (v18.15.0, x64)}
_{Execution time}	_{226.89ms (± 0.16%)}	_{226.93ms (± 0.15%)}	_~	_225.56ms	_229.27ms	_{p=0.096 n=600}
_{typescript-startup - node (v18.15.0, x64)}
_{Execution time}	_{225.65ms (± 0.15%)}	_{225.71ms (± 0.18%)}	_~	_224.23ms	_232.81ms	_{p=0.128 n=600}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

tsc-startup - node (v18.15.0, x64)
tsserver-startup - node (v18.15.0, x64)
tsserverlibrary-startup - node (v18.15.0, x64)
typescript-startup - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

DanielRosenwasser · 2024-07-08T17:09:48Z

@typescript-bot cherry pick this to release-5.5

DanielRosenwasser · 2024-07-08T17:33:22Z

@typescript-bot cherry-pick this to release-5.5

typescript-bot · 2024-07-08T17:33:25Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`cherry-pick this to release-5.5`	✅ Started	✅ Results

typescript-bot · 2024-07-08T17:35:52Z

Hey, @DanielRosenwasser! I've created #59179 for you.

…e-5.5 (#59179) Co-authored-by: Isabel Duan <isabelduan@microsoft.com>

fix checker call

2761af7

typescript-bot assigned iisaduan Jul 3, 2024

typescript-bot added Author: Team For Milestone Bug PRs that fix a bug with a specific milestone labels Jul 3, 2024

iisaduan mentioned this pull request Jul 3, 2024

createNodeArray always makes a new nodeArray when given a nodeArray #59135

Draft

DanielRosenwasser reviewed Jul 3, 2024

View reviewed changes

iisaduan requested review from andrewbranch and weswigham July 4, 2024 22:03

change to slice for perf test

9aeb8a3

andrewbranch approved these changes Jul 8, 2024

View reviewed changes

weswigham approved these changes Jul 8, 2024

View reviewed changes

typescript-bot mentioned this pull request Jul 8, 2024

🤖 Pick PR #59137 (visitNodesWithoutCopyingPositions...) into release-5.5 #59179

Merged

armanio123 mentioned this pull request Jul 8, 2024

[ServerErrors][TypeScript] 5.6.0-dev.20240630 #59085

Closed

DanielRosenwasser added this to the TypeScript 5.5.4 milestone Jul 16, 2024

DanielRosenwasser merged commit 66a762f into microsoft:main Jul 16, 2024

DanielRosenwasser pushed a commit that referenced this pull request Jul 16, 2024

🤖 Pick PR #59137 (visitNodesWithoutCopyingPositions...) into releas…

381e609

…e-5.5 (#59179) Co-authored-by: Isabel Duan <isabelduan@microsoft.com>

iisaduan deleted the nodeArrayCrash2 branch July 16, 2024 20:51

sandersn removed this from PR Backlog Apr 22, 2025

microsoft locked as resolved and limited conversation to collaborators Oct 16, 2025

	result = factory.createNodeArray([...nodes], nodes.hasTrailingComma);
	result = factory.createNodeArray(nodes.slice(), nodes.hasTrailingComma);

Conversation

iisaduan commented Jul 3, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

iisaduan commented Jul 3, 2024

Uh oh!

typescript-bot commented Jul 3, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

DanielRosenwasser Jul 3, 2024

Choose a reason for hiding this comment

Uh oh!

typescript-bot commented Jul 4, 2024

tsc

tsserver

startup

Uh oh!

iisaduan commented Jul 5, 2024

Uh oh!

typescript-bot commented Jul 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Jul 5, 2024

tsc

tsserver

startup

Uh oh!

DanielRosenwasser commented Jul 8, 2024

Uh oh!

DanielRosenwasser commented Jul 8, 2024

Uh oh!

typescript-bot commented Jul 8, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Jul 8, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Comments

iisaduan commented Jul 3, 2024 •

edited

Loading

typescript-bot commented Jul 3, 2024 •

edited

Loading

typescript-bot commented Jul 5, 2024 •

edited

Loading

typescript-bot commented Jul 8, 2024 •

edited

Loading