Skip to content

Comments

Add SignatureInformation#activeParameter support#975

Closed
KamasamaK wants to merge 1 commit intomicrosoft:gh-pagesfrom
KamasamaK:signatureInformation-activeParameter-support
Closed

Add SignatureInformation#activeParameter support#975
KamasamaK wants to merge 1 commit intomicrosoft:gh-pagesfrom
KamasamaK:signatureInformation-activeParameter-support

Conversation

@KamasamaK
Copy link
Contributor

Fixes #974

@rcjsuen
Copy link
Contributor

rcjsuen commented May 8, 2020

@KamasamaK This diff (971b2cf) is massive. Did the newline characters get changed or something?

@KamasamaK
Copy link
Contributor Author

It's unclear to me why it's doing that in the GitHub source diff. I've never had an issue with newline changes before and I'm not sure how to verify if that were the issue. I thought that Git normalized those, anyway. I've verified that I have "core.autocrlf" set to "true". The commit diff within VS Code only shows my 3 changes and I do not have it configured to ignore whitespace changes. If you are able to swap the GitHub diff from "source diff" to "rich diff" it becomes more clear what the 3 changes are.

@dbaeumer
Copy link
Member

@KamasamaK thanks for the PR. Did the changes by hand to due the massive diff.

@dbaeumer dbaeumer closed this May 11, 2020
@KamasamaK
Copy link
Contributor Author

KamasamaK commented May 11, 2020

Ok. I noticed some wording changes and commented on 5565f27 about an incorrect description. It's also missing the addition to the change log.

What is the meaning of "proposed state"? It's already shipped in the latest stable vscode.d.ts and the change seems trivial enough that I don't see it possibly changing for LSP.

@dbaeumer
Copy link
Member

It is proposed in LSP. This is to signal that we still might change it. I always try to do it this way.

@KamasamaK KamasamaK deleted the signatureInformation-activeParameter-support branch May 22, 2020 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants