Add SignatureInformation#activeParameter support#975
Add SignatureInformation#activeParameter support#975KamasamaK wants to merge 1 commit intomicrosoft:gh-pagesfrom
Conversation
|
@KamasamaK This diff (971b2cf) is massive. Did the newline characters get changed or something? |
|
It's unclear to me why it's doing that in the GitHub source diff. I've never had an issue with newline changes before and I'm not sure how to verify if that were the issue. I thought that Git normalized those, anyway. I've verified that I have "core.autocrlf" set to "true". The commit diff within VS Code only shows my 3 changes and I do not have it configured to ignore whitespace changes. If you are able to swap the GitHub diff from "source diff" to "rich diff" it becomes more clear what the 3 changes are. |
|
@KamasamaK thanks for the PR. Did the changes by hand to due the massive diff. |
|
Ok. I noticed some wording changes and commented on 5565f27 about an incorrect description. It's also missing the addition to the change log. What is the meaning of "proposed state"? It's already shipped in the latest stable |
|
It is proposed in LSP. This is to signal that we still might change it. I always try to do it this way. |
Fixes #974