fix: memory leak in chat session tracker#269027
Merged
alexr00 merged 16 commits intomicrosoft:mainfrom Nov 6, 2025
Merged
Conversation
osortega
requested changes
Oct 10, 2025
src/vs/workbench/contrib/chat/browser/chatSessions/chatSessionTracker.ts
Outdated
Show resolved
Hide resolved
alexr00
previously approved these changes
Oct 15, 2025
Tyriar
previously approved these changes
Oct 15, 2025
Tyriar
reviewed
Oct 15, 2025
src/vs/workbench/contrib/chat/browser/chatSessions/chatSessionTracker.ts
Outdated
Show resolved
Hide resolved
osortega
previously approved these changes
Oct 15, 2025
15518f5
alexr00
approved these changes
Oct 16, 2025
Tyriar
requested changes
Oct 16, 2025
src/vs/workbench/contrib/chat/browser/chatSessions/chatSessionTracker.ts
Outdated
Show resolved
Hide resolved
alexr00
requested changes
Oct 16, 2025
src/vs/workbench/contrib/chat/browser/chatSessions/chatSessionTracker.ts
Outdated
Show resolved
Hide resolved
Tyriar
previously approved these changes
Oct 16, 2025
alexr00
previously approved these changes
Oct 16, 2025
Member
|
Merge conflict. |
alexr00
previously approved these changes
Oct 27, 2025
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: @bpaseroMatched files:
|
alexr00
approved these changes
Nov 3, 2025
osortega
approved these changes
Nov 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a memory leak in the chat session tracker.
Overview
The chat session tracker registers a listener to a group each time a group is added. But when a group is removed, the listener doesn't seem to be disposed.
Change
The change is to also listen for group removal events and dispose the group change listener for the group when the group is removed:
Results after change
After the change there seem to be no more chat session tracker leaks.