Fix #89900 - improve text on editor.showFoldingControls setting#89919
Fix #89900 - improve text on editor.showFoldingControls setting#89919aeschli merged 1 commit intomicrosoft:masterfrom
Conversation
That does not accord with behaviour. Expand (">") is shown regardless. I'm guessing that behaviour is a bug, but have held off reporting it until I understand this muddled area more e.g. why there's second expand button at the line end ("...") - with no corresponding collapse button. Meanwhile I'm pointing this out in case you, like I, think it better for the labelling to accord with erroneos behavior meanwhile. |
@chrisjj good point. I suggest "Hide 'Fold' controls unless the mouse is over the gutter. 'Unfold' controls are always shown." My suggestion avoids using 'expand' and 'collapse' because those would be inconsistent with documentation and command names. |
In this context, Fold for Collapse is very ambiguous. And control is needlessly unspecific. I suggest: Hide Collapse buttons unless the mouse pointer is over the gutter. Expand buttons are always shown. |
|
The name of the setting itself refers to them as controls. Nor do they have the conventional appearance of buttons. Indeed there are two distinct forms of the Unfold controls, one being the > chevron and the other the end-of-line ellipsis. I disagree about the ambiguity of Fold in this context, since it contrasts with Unfold in the second sentence. Also, Fold and Unfold are the standard terms in VS Code documentation and the command names. |
Hardly an authority, right? :).
Only because the border shown in the docs has been removed for some reason. However, that doesn't change the fact they are buttons.
OK, so your "@chrisjj good point." above is cancelled, right? Because your 'folding' there was excluing my Expand.
... relying on expand and collapse for clarification :) e.g. "Fold (Ctrl+Shift+[) folds the innermost uncollapsed region at the cursor." |
|
Sorry for the inconsistency of terms.
|
|
Thanks @gjsjohnmurray ! |
Where please? I don't see that in https://code.visualstudio.com/docs/editor/codebasics Folding. |
|
Sorry, folding icons. |
|
Thanks. I agree that folding controls is better than folding icons. Though still I think folding buttons is best :) |
This PR fixes #89900
As well as clarifying the meaning of the setting, descriptions have been added to the two values it can take.