Clear workspace pull state on document close to prevent stale diagnostics#1674
Merged
dbaeumer merged 2 commits intomicrosoft:mainfrom Oct 10, 2025
Merged
Clear workspace pull state on document close to prevent stale diagnostics#1674dbaeumer merged 2 commits intomicrosoft:mainfrom
dbaeumer merged 2 commits intomicrosoft:mainfrom
Conversation
JoeRobich
reviewed
Oct 7, 2025
Co-authored-by: Joey Robichaud <joseph.robichaud@microsoft.com>
Member
|
@dibarbet actually the change does make sense. |
dbaeumer
approved these changes
Oct 9, 2025
Member
|
@dibarbet thanks for fixing this. |
alexr00
approved these changes
Oct 9, 2025
Member
Author
|
Thanks! Think I need help triggering CI / merging |
Member
|
I think CI doesn't run when it's from a fork. |
Member
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
fannheyward
added a commit
to neoclide/coc.nvim
that referenced
this pull request
Oct 21, 2025
fannheyward
added a commit
to neoclide/coc.nvim
that referenced
this pull request
Oct 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Took a stab at fixing #1673
Not completely sure if this is the right solution, but doesn't seem unreasonable. When forgetting a document, also forget the workspace pull state for it to ensure new workspace diagnostics are sent from the server. The document pull may have changed the set of diagnostics, meaning the client no longer has the same set of diagnostics that map to the previous workspace pull.