feature: set amdLoaderGlobal to globalThis in case this is not defined#58
Merged
alexdima merged 1 commit intomicrosoft:mainfrom Aug 21, 2024
SimonSiefke:feature/amd-loader-global-this
Merged
feature: set amdLoaderGlobal to globalThis in case this is not defined#58alexdima merged 1 commit intomicrosoft:mainfrom SimonSiefke:feature/amd-loader-global-this
amdLoaderGlobal to globalThis in case this is not defined#58alexdima merged 1 commit intomicrosoft:mainfrom
SimonSiefke:feature/amd-loader-global-this
Conversation
this is not defined
this is not definedamdLoaderGlobal to globalThis in case this is not defined
alexdima
approved these changes
Aug 21, 2024
Member
|
Thank you! |
chrmarti
approved these changes
Aug 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Helps with microsoft/vscode#160416.
This PR changes the
_amdLoaderGlobalto fall back toglobalThiswhenthisis undefined. This would be useful for using the AMD loader with ESM, becausethisat the top level of an ESM module is undefined.