Fix pip-requirements filename patterns#18487
Merged
brettcannon merged 1 commit intomicrosoft:mainfrom Feb 16, 2022
Merged
Conversation
ab4238a to
2719efe
Compare
brettcannon
suggested changes
Feb 10, 2022
package.json
Outdated
Comment on lines
1577
to
1578
| "**/*requirements{/**,*}.{txt,in}", | ||
| "**/*constraints{/**,*}.txt" |
Member
There was a problem hiding this comment.
We have to be careful to not over-fit on file patterns as we don't want to try and highlight files that are not requirements files.
Suggested change
| "**/*requirements{/**,*}.{txt,in}", | |
| "**/*constraints{/**,*}.txt" | |
| "*-requirements.{txt, in}", | |
| "*-contstraints.txt", | |
| "requirements-*.{txt, in}", | |
| "constraints-*.txt", | |
| "requirements/*.{txt,in}", | |
| "constraints/*.txt" |
Let us know if this still highlights files as expected for you.
Member
|
@batisteo any chance you can look at my proposed changes this week? We are feature freezing at the end of the week. |
2719efe to
47eebb6
Compare
Author
|
Thanks @brettcannon for the heads up! What do you think? |
brettcannon
approved these changes
Feb 16, 2022
Member
|
@batisteo thanks! |
levrik
reviewed
Mar 4, 2022
| "requirements-*.txt" | ||
| ], | ||
| "**/*-requirements.{txt, in}", | ||
| "**/*-contstraints.txt", |
There was a problem hiding this comment.
Fixed in #18646, thanks for bringing to our attention.
wesm
pushed a commit
to posit-dev/positron
that referenced
this pull request
Mar 28, 2024
…aints/` sub-directories (microsoft/vscode-python#18487)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fix is for projects that uses a
requirementsfolder with files namedbase.txt,production.txtand such.Fixes #18498.