More clear error message for invalid debug configuration#19436
Merged
paulacamargo25 merged 2 commits intomicrosoft:mainfrom Jul 21, 2022
Merged
More clear error message for invalid debug configuration#19436paulacamargo25 merged 2 commits intomicrosoft:mainfrom
paulacamargo25 merged 2 commits intomicrosoft:mainfrom
Conversation
karthiknadig
previously approved these changes
Jul 14, 2022
Member
|
@scottshambaugh The changes look good, only thing is you might have to run prettier on the tsfile: |
e442054 to
39485f5
Compare
39485f5 to
297b2d4
Compare
Author
|
Thanks @karthiknadig, I'm having issues running prettifier locally but this checks out in the playground now. Not sure how to rerun the workflow to get it to check it. |
Member
|
@scottshambaugh I pushed a linting fix to your branch. It should pass now. |
Author
|
@karthiknadig thank you! |
paulacamargo25
approved these changes
Jul 21, 2022
wesm
pushed a commit
to posit-dev/positron
that referenced
this pull request
Mar 28, 2024
…scode-python#19436) * More clear error message for invalid debug configuration * Address linting issues. Co-authored-by: Scott Shambaugh <scottshambaugh@users.noreply.github.com> Co-authored-by: Karthik Nadig <kanadig@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This closes #18963, and actually resolves #17150, by updating an error message string.