Refactor code to remove unused JSDoc types#24300
Merged
karthiknadig merged 2 commits intomicrosoft:mainfrom Oct 14, 2024
Merged
Refactor code to remove unused JSDoc types#24300karthiknadig merged 2 commits intomicrosoft:mainfrom
karthiknadig merged 2 commits intomicrosoft:mainfrom
Conversation
Author
|
@microsoft-github-policy-service agree |
karthiknadig
approved these changes
Oct 14, 2024
Member
|
Thanks for cleaning up the JSDocs. We will merge this after tests pass and review. Happy Coding!! |
|
Thank you for doing this @brokoli777 :) |
anthonykim1
approved these changes
Oct 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #24077
Removes redundant type annotations from JSDocs in TypeScript files where the type is already inferred by TypeScript.
For example:
Here I removed JSDoc types but I still kept all the useful information.
I tried to be on the liberal side to avoid removing any comments that provide useful context or clarify behavior. If I missed any or if more can be removed, I’m happy to go over it again.
Additionally, if this issue only applies to a specific folder or scope, please let me know so I can make the necessary adjustments.