[docker-29.x backport] Allow configured address with no configured subnet#51583
Merged
vvoland merged 2 commits intomoby:docker-29.xfrom Nov 24, 2025
Merged
[docker-29.x backport] Allow configured address with no configured subnet#51583vvoland merged 2 commits intomoby:docker-29.xfrom
vvoland merged 2 commits intomoby:docker-29.xfrom
Conversation
Pick up fixes for: - test_create_with_ipv6_address - test_connect_with_ipv6_address https://github.com/docker/docker-py/compare/65f7f0c..df3f8e2 Signed-off-by: Rob Murray <rob.murray@docker.com> (cherry picked from commit 7e14b4d) Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
Signed-off-by: Rob Murray <rob.murray@docker.com> (cherry picked from commit 84a251d) Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
When a network is configured with no explicit
--subnet,daemon.validateEndpointIPAddresstries to prevent a container from being started with a--ipaddress - with error "user specified IP address is supported only when connecting to networks with user configured subnets".But the check didn't work in 28.x and older because, until #51134, IPAM config always contained a copy of the network's subnet - whether the user configured it, or it was allocated from the default pools.
So, it was possible to inspect (or guess!) a network's subnet and create a container with a specific address ... restore that behaviour.
- How I did it
- How to verify it
New integration test that fails without the fix.
- Human readable description for the release notes