Skip to content

Commit 2939950

Browse files
IlyasShabiaduh95
authored andcommitted
test: add implicit test for fs dispose handling with using
PR-URL: #61140 Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
1 parent 4bbbe75 commit 2939950

File tree

1 file changed

+25
-1
lines changed

1 file changed

+25
-1
lines changed

test/parallel/test-fs-promises-file-handle-dispose.js

Lines changed: 25 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,5 +22,29 @@ async function explicitCall() {
2222
assert.throws(() => dhSync.readSync(), { code: 'ERR_DIR_CLOSED' });
2323
}
2424

25+
async function implicitCall() {
26+
let fh;
27+
{
28+
await using openHandle = await fs.open(__filename);
29+
fh = openHandle;
30+
fh.on('close', common.mustCall());
31+
}
32+
assert.strictEqual(fh.fd, -1);
33+
34+
let dh;
35+
{
36+
await using dirHandle = await fs.opendir(__dirname);
37+
dh = dirHandle;
38+
}
39+
await assert.rejects(dh.read(), { code: 'ERR_DIR_CLOSED' });
40+
41+
let dhSync;
42+
{
43+
using dirHandleSync = opendirSync(__dirname);
44+
dhSync = dirHandleSync;
45+
}
46+
assert.throws(() => dhSync.readSync(), { code: 'ERR_DIR_CLOSED' });
47+
}
48+
2549
explicitCall().then(common.mustCall());
26-
// TODO(aduh95): add test for implicit calls, with `await using` syntax.
50+
implicitCall().then(common.mustCall());

0 commit comments

Comments
 (0)