quic: copy options.certs buffer instead of detaching

legendecas · aduh95 · commit 62d71eb28d6c · 2026-01-25T00:07:38.000+01:00
The certs could be allocated in a pooled buffer, like `Buffer.from`, and `Buffer.allocUnsafe` (used by `fs.readFileSync`, etc). PR-URL: #61403 Refs: #61372 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
diff --git a/src/quic/data.cc b/src/quic/data.cc
@@ -115,6 +115,29 @@ Maybe<Store> Store::From(Local<ArrayBufferView> view, Local<Value> detach_key) {
   return Just(Store(std::move(backing), length, offset));
 }
 
+Store Store::CopyFrom(Local<ArrayBuffer> buffer) {
+  v8::Isolate* isolate = v8::Isolate::GetCurrent();
+  auto backing = buffer->GetBackingStore();
+  auto length = buffer->ByteLength();
+  auto dest = ArrayBuffer::NewBackingStore(
+      isolate, length, v8::BackingStoreInitializationMode::kUninitialized);
+  // copy content
+  memcpy(dest->Data(), backing->Data(), length);
+  return Store(std::move(dest), length, 0);
+}
+
+Store Store::CopyFrom(Local<ArrayBufferView> view) {
+  v8::Isolate* isolate = v8::Isolate::GetCurrent();
+  auto backing = view->Buffer()->GetBackingStore();
+  auto length = view->ByteLength();
+  auto offset = view->ByteOffset();
+  auto dest = ArrayBuffer::NewBackingStore(
+      isolate, length, v8::BackingStoreInitializationMode::kUninitialized);
+  // copy content
+  memcpy(dest->Data(), static_cast<char*>(backing->Data()) + offset, length);
+  return Store(std::move(dest), length, 0);
+}
+
 Local<Uint8Array> Store::ToUint8Array(Environment* env) const {
   return !store_
              ? Uint8Array::New(ArrayBuffer::New(env->isolate(), 0), 0, 0)
diff --git a/src/quic/data.h b/src/quic/data.h
@@ -70,6 +70,14 @@ class Store final : public MemoryRetainer {
       v8::Local<v8::ArrayBufferView> view,
       v8::Local<v8::Value> detach_key = v8::Local<v8::Value>());
 
+  // Creates a Store from the contents of an ArrayBuffer, always copying the
+  // content.
+  static Store CopyFrom(v8::Local<v8::ArrayBuffer> buffer);
+
+  // Creates a Store from the contents of an ArrayBufferView, always copying the
+  // content.
+  static Store CopyFrom(v8::Local<v8::ArrayBufferView> view);
+
   v8::Local<v8::Uint8Array> ToUint8Array(Environment* env) const;
   inline v8::Local<v8::Uint8Array> ToUint8Array(Realm* realm) const {
     return ToUint8Array(realm->env());
diff --git a/src/quic/endpoint.cc b/src/quic/endpoint.cc
@@ -154,10 +154,7 @@ bool SetOption(Environment* env,
           env, "The %s option must be an ArrayBufferView", nameStr);
       return false;
     }
-    Store store;
-    if (!Store::From(value.As<ArrayBufferView>()).To(&store)) {
-      return false;
-    }
+    Store store = Store::CopyFrom(value.As<ArrayBufferView>());
     if (store.length() != TokenSecret::QUIC_TOKENSECRET_LEN) {
       Utf8Value nameStr(env->isolate(), name);
       THROW_ERR_INVALID_ARG_VALUE(
diff --git a/src/quic/tlscontext.cc b/src/quic/tlscontext.cc
@@ -133,16 +133,10 @@ bool SetOption(Environment* env,
         }
       } else if constexpr (std::is_same<T, Store>::value) {
         if (item->IsArrayBufferView()) {
-          Store store;
-          if (!Store::From(item.As<v8::ArrayBufferView>()).To(&store)) {
-            return false;
-          }
+          Store store = Store::CopyFrom(item.As<v8::ArrayBufferView>());
           (options->*member).push_back(std::move(store));
         } else if (item->IsArrayBuffer()) {
-          Store store;
-          if (!Store::From(item.As<ArrayBuffer>()).To(&store)) {
-            return false;
-          }
+          Store store = Store::CopyFrom(item.As<ArrayBuffer>());
           (options->*member).push_back(std::move(store));
         } else {
           Utf8Value namestr(env->isolate(), name);
@@ -168,16 +162,10 @@ bool SetOption(Environment* env,
       }
     } else if constexpr (std::is_same<T, Store>::value) {
       if (value->IsArrayBufferView()) {
-        Store store;
-        if (!Store::From(value.As<v8::ArrayBufferView>()).To(&store)) {
-          return false;
-        }
+        Store store = Store::CopyFrom(value.As<v8::ArrayBufferView>());
         (options->*member).push_back(std::move(store));
       } else if (value->IsArrayBuffer()) {
-        Store store;
-        if (!Store::From(value.As<ArrayBuffer>()).To(&store)) {
-          return false;
-        }
+        Store store = Store::CopyFrom(value.As<ArrayBuffer>());
         (options->*member).push_back(std::move(store));
       } else {
         Utf8Value namestr(env->isolate(), name);
diff --git a/test/parallel/test-quic-handshake-ipv6-only.mjs b/test/parallel/test-quic-handshake-ipv6-only.mjs
@@ -47,6 +47,8 @@ const serverEndpoint = await listen(mustCall((serverSession) => {
   },
   ipv6Only: true,
 } });
+// Buffer is not detached.
+assert.strictEqual(certs.buffer.detached, false);
 
 // The server must have an address to connect to after listen resolves.
 assert.ok(serverEndpoint.address !== undefined);
diff --git a/test/parallel/test-quic-handshake.mjs b/test/parallel/test-quic-handshake.mjs
@@ -38,6 +38,9 @@ const serverEndpoint = await listen(mustCall((serverSession) => {
   }).then(mustCall());
 }), { keys, certs });
 
+// Buffer is not detached.
+assert.strictEqual(certs.buffer.detached, false);
+
 // The server must have an address to connect to after listen resolves.
 assert.ok(serverEndpoint.address !== undefined);
 
diff --git a/test/parallel/test-quic-internal-endpoint-listen-defaults.mjs b/test/parallel/test-quic-internal-endpoint-listen-defaults.mjs
@@ -28,15 +28,23 @@ assert.strictEqual(endpoint.address, undefined);
 await assert.rejects(listen(123, { keys, certs, endpoint }), {
   code: 'ERR_INVALID_ARG_TYPE',
 });
+// Buffer is not detached.
+assert.strictEqual(certs.buffer.detached, false);
 
 await assert.rejects(listen(() => {}, 123), {
   code: 'ERR_INVALID_ARG_TYPE',
 });
 
 await listen(() => {}, { keys, certs, endpoint });
+// Buffer is not detached.
+assert.strictEqual(certs.buffer.detached, false);
+
 await assert.rejects(listen(() => {}, { keys, certs, endpoint }), {
   code: 'ERR_INVALID_STATE',
 });
+// Buffer is not detached.
+assert.strictEqual(certs.buffer.detached, false);
+
 assert.ok(state.isBound);
 assert.ok(state.isReceiving);
 assert.ok(state.isListening);
@@ -58,6 +66,9 @@ assert.ok(endpoint.destroyed);
 await assert.rejects(listen(() => {}, { keys, certs, endpoint }), {
   code: 'ERR_INVALID_STATE',
 });
+// Buffer is not detached.
+assert.strictEqual(certs.buffer.detached, false);
+
 assert.throws(() => { endpoint.busy = true; }, {
   code: 'ERR_INVALID_STATE',
 });
