doc: fixes a typo in the async_hooks documentation#13666
Closed
chris--young wants to merge 2 commits intonodejs:masterfrom
Closed
doc: fixes a typo in the async_hooks documentation#13666chris--young wants to merge 2 commits intonodejs:masterfrom
chris--young wants to merge 2 commits intonodejs:masterfrom
Conversation
refack
approved these changes
Jun 13, 2017
Contributor
|
Minor nit to whomever lands this, 'fixes:' should probably be 'Fixes:' in the commit message. Otherwise LGTM. |
01f9ad7 to
fb7ca40
Compare
> Generally it will correspond the name of the resource's constructor. should read "will correspond with..." Fixes: nodejs#13663
fb7ca40 to
dff842a
Compare
cjihrig
approved these changes
Jun 14, 2017
TimothyGu
reviewed
Jun 14, 2017
doc/api/async_hooks.md
Outdated
| The `type` is a string that represents the type of resource that caused | ||
| `init` to be called. Generally it will correspond the name of the resource's | ||
| constructor. | ||
| `init` to be called. Generally it will correspond with the name of the |
Member
There was a problem hiding this comment.
While we're in here, can you put a comma after Generally?
> Generally it will correspond the name of the resource's constructor. should read "Generally, it will correspond to the name..." Fixes: nodejs#13663
refack
approved these changes
Jun 14, 2017
jasnell
approved these changes
Jun 15, 2017
tniessen
approved these changes
Jun 15, 2017
Member
|
Landed in 386f53f, thank you for your first contribution! 🎉 |
tniessen
pushed a commit
that referenced
this pull request
Jun 15, 2017
> Generally it will correspond the name of the resource's constructor. should read "Generally, it will correspond to the name..." PR-URL: #13666 Fixes: #13663 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
addaleax
pushed a commit
that referenced
this pull request
Jun 17, 2017
> Generally it will correspond the name of the resource's constructor. should read "Generally, it will correspond to the name..." PR-URL: #13666 Fixes: #13663 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Merged
addaleax
pushed a commit
that referenced
this pull request
Jun 21, 2017
> Generally it will correspond the name of the resource's constructor. should read "Generally, it will correspond to the name..." PR-URL: #13666 Fixes: #13663 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a minor typo as described by @mscdex in #13663
should read "will correspond with..."
fixes: #13663
Checklist
Affected core subsystem(s)
doc