test: replace common.fixturesDir#15834
Closed
shawn-mcginty wants to merge 2 commits intonodejs:masterfrom
Closed
Conversation
In test/parallel/test-tls-junk-closes-server.js, replaced common.fixtruesDir with usage of the common.fixtrues module.
pawelgolda
reviewed
Oct 6, 2017
| const options = { | ||
| key: fs.readFileSync(`${common.fixturesDir}/keys/agent2-key.pem`), | ||
| cert: fs.readFileSync(`${common.fixturesDir}/keys/agent2-cert.pem`) | ||
| key: fixtures.readSync('/keys/agent2-key.pem'), |
Contributor
There was a problem hiding this comment.
This could be using method fixtures.readKey to get the key.
Use fixtrues.readKey instead of fixtrues.readSync.
rmg
approved these changes
Oct 6, 2017
Contributor
rmg
left a comment
There was a problem hiding this comment.
This looks great! Thanks for the contribution!
benjamingr
approved these changes
Oct 7, 2017
cjihrig
approved these changes
Oct 7, 2017
tniessen
approved these changes
Oct 7, 2017
jasnell
approved these changes
Oct 10, 2017
gireeshpunathil
approved these changes
Oct 10, 2017
gireeshpunathil
pushed a commit
that referenced
this pull request
Oct 11, 2017
In test/parallel/test-tls-junk-closes-server.js, replaced common.fixtruesDir with usage of the common.fixtrues module. PR-URL: #15834 Reviewed-By: Ryan Graham <r.m.graham@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Member
Contributor
No Problem - I'm just collecting a batch to CI together. |
addaleax
pushed a commit
to addaleax/ayo
that referenced
this pull request
Oct 12, 2017
In test/parallel/test-tls-junk-closes-server.js, replaced common.fixtruesDir with usage of the common.fixtrues module. PR-URL: nodejs/node#15834 Reviewed-By: Ryan Graham <r.m.graham@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
MylesBorins
pushed a commit
that referenced
this pull request
Oct 23, 2017
In test/parallel/test-tls-junk-closes-server.js, replaced common.fixtruesDir with usage of the common.fixtrues module. PR-URL: #15834 Reviewed-By: Ryan Graham <r.m.graham@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
MylesBorins
pushed a commit
that referenced
this pull request
Nov 16, 2017
In test/parallel/test-tls-junk-closes-server.js, replaced common.fixtruesDir with usage of the common.fixtrues module. PR-URL: #15834 Reviewed-By: Ryan Graham <r.m.graham@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Nov 21, 2017
In test/parallel/test-tls-junk-closes-server.js, replaced common.fixtruesDir with usage of the common.fixtrues module. PR-URL: #15834 Reviewed-By: Ryan Graham <r.m.graham@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
MylesBorins
pushed a commit
that referenced
this pull request
Nov 28, 2017
In test/parallel/test-tls-junk-closes-server.js, replaced common.fixtruesDir with usage of the common.fixtrues module. PR-URL: #15834 Reviewed-By: Ryan Graham <r.m.graham@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
13 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In test/parallel/test-tls-junk-closes-server.js, replaced
common.fixtruesDir with usage of the common.fixtrues module.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test