test: replaced fixturesDir with common.fixtures module#15836
Closed
dtoki wants to merge 2 commits intonodejs:masterfrom
Closed
test: replaced fixturesDir with common.fixtures module#15836dtoki wants to merge 2 commits intonodejs:masterfrom
dtoki wants to merge 2 commits intonodejs:masterfrom
Conversation
rmg
reviewed
Oct 6, 2017
Contributor
rmg
left a comment
There was a problem hiding this comment.
Thanks for making Node.js better!
Contributor
There was a problem hiding this comment.
This could be cleaned up further by making use of fixtures.readSync() to replace the fs.readFileSuync and the path.join!
Something like key: fixtures.readSync('test_key.pem'),
Contributor
Author
There was a problem hiding this comment.
Ahh thanks for pointing that out, will make changes now.
fd41c22 to
db07d1f
Compare
Contributor
Author
|
should I squash the commit's into one or is this okay? |
Contributor
|
@dtoki technically whoever lands it could take care of that, but if you've got the time/energy it's highly appreciated :-) |
lance
approved these changes
Oct 7, 2017
lance
approved these changes
Oct 7, 2017
benjamingr
approved these changes
Oct 7, 2017
jasnell
approved these changes
Oct 10, 2017
gireeshpunathil
approved these changes
Oct 10, 2017
lpinca
approved these changes
Oct 11, 2017
| 'use strict'; | ||
|
|
||
| const common = require('../common'); | ||
| const fixtures = require('../common/fixtures'); |
Member
There was a problem hiding this comment.
Nit: can you please move this after the common.hasCrypto check?
Member
|
Landed in c42cdd4 with #15836 (review) fixed. Thanks for the contribution! |
joyeecheung
pushed a commit
that referenced
this pull request
Oct 13, 2017
PR-URL: #15836 Reviewed-By: Lance Ball <lball@redhat.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
addaleax
pushed a commit
to ayojs/ayo
that referenced
this pull request
Oct 15, 2017
PR-URL: nodejs/node#15836 Reviewed-By: Lance Ball <lball@redhat.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos
pushed a commit
that referenced
this pull request
Oct 18, 2017
PR-URL: #15836 Reviewed-By: Lance Ball <lball@redhat.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Nov 16, 2017
PR-URL: #15836 Reviewed-By: Lance Ball <lball@redhat.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Nov 21, 2017
PR-URL: #15836 Reviewed-By: Lance Ball <lball@redhat.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Nov 28, 2017
PR-URL: #15836 Reviewed-By: Lance Ball <lball@redhat.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)