test-tls-inception: replaced common.fixturesDir with the common.fixtures.path method#15872
Closed
LancePTB wants to merge 4 commits intonodejs:masterfrom
Closed
test-tls-inception: replaced common.fixturesDir with the common.fixtures.path method#15872LancePTB wants to merge 4 commits intonodejs:masterfrom
LancePTB wants to merge 4 commits intonodejs:masterfrom
Conversation
Member
jasnell
reviewed
Oct 10, 2017
test/parallel/test-tls-inception.js
Outdated
| key: fs.readFileSync(path.join(common.fixturesDir, 'test_key.pem')), | ||
| cert: fs.readFileSync(path.join(common.fixturesDir, 'test_cert.pem')) | ||
| key: fs.readFileSync(fixtures.path('test_key.pem')), | ||
| cert: fs.readFileSync(fixtures.path('test_cert.pem')) |
Member
There was a problem hiding this comment.
this can be:
key: fixtures.readSync('test_key.pem'),
cert: fixtures.readSync('test_cert.pem')
Member
There was a problem hiding this comment.
If there is no reaction soon, I will just change it while landing.
Contributor
Author
There was a problem hiding this comment.
My apologies for not following through; i pushed those changes, but i see that you have a separate branch already that had the same thing, so we could use either branch to merge.
Member
There was a problem hiding this comment.
Oh, it is still great to have the correct change in the PR! The way we merge things would result in the same right now.
Member
|
Ping @LancePTB |
BridgeAR
approved these changes
Oct 18, 2017
Member
gireeshpunathil
approved these changes
Oct 19, 2017
Member
|
and ping @jasnell |
BridgeAR
pushed a commit
that referenced
this pull request
Oct 19, 2017
PR-URL: #15872 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Member
|
Landed in 5887d80 Thanks for the PR, and congratulations on becoming a Node.js Contributor 🎉 ! |
MylesBorins
pushed a commit
that referenced
this pull request
Oct 23, 2017
PR-URL: #15872 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
addaleax
pushed a commit
to ayojs/ayo
that referenced
this pull request
Oct 26, 2017
PR-URL: nodejs/node#15872 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MylesBorins
pushed a commit
that referenced
this pull request
Nov 16, 2017
PR-URL: #15872 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Nov 21, 2017
PR-URL: #15872 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MylesBorins
pushed a commit
that referenced
this pull request
Nov 28, 2017
PR-URL: #15872 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
addaleax
pushed a commit
to ayojs/ayo
that referenced
this pull request
Dec 7, 2017
PR-URL: nodejs/node#15872 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)