update test messages for assert.strictEqual#15995
Closed
tisAliG wants to merge 2 commits intonodejs:masterfrom
Closed
update test messages for assert.strictEqual#15995tisAliG wants to merge 2 commits intonodejs:masterfrom
tisAliG wants to merge 2 commits intonodejs:masterfrom
Conversation
dcc461e to
baf7373
Compare
BridgeAR
reviewed
Oct 6, 2017
| txt += decipher.final('utf8'); | ||
|
|
||
| assert.strictEqual(txt, plaintext, 'encryption and decryption'); | ||
| assert.strictEqual(txt, plaintext, `${txt} is encrypted, ${plaintext} is unencrypted`); |
Member
There was a problem hiding this comment.
I personally would prefer to just remove the error message overall instead of using the individual ones in all these cases. The reason is that it could theoretically be a different case than the description value (the test should pass and we do not know the real reason why the test would not pass).
Member
There was a problem hiding this comment.
I agree with @BridgeAR. I think it's better to just remove the custom messages (third argument) here and use the default one.
…sages are a better option
joyeecheung
approved these changes
Oct 14, 2017
Member
jasnell
approved these changes
Oct 14, 2017
lpinca
approved these changes
Oct 14, 2017
hiroppy
approved these changes
Oct 14, 2017
Member
|
Landed in f4cab35, thank you for the contribution! |
joyeecheung
pushed a commit
that referenced
this pull request
Oct 14, 2017
Remove test messages for assert.strictEqual, as the default messages are a better option. PR-URL: #15995 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
addaleax
pushed a commit
to ayojs/ayo
that referenced
this pull request
Oct 15, 2017
Remove test messages for assert.strictEqual, as the default messages are a better option. PR-URL: nodejs/node#15995 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
targos
pushed a commit
that referenced
this pull request
Oct 18, 2017
Remove test messages for assert.strictEqual, as the default messages are a better option. PR-URL: #15995 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
MylesBorins
pushed a commit
that referenced
this pull request
Nov 16, 2017
Remove test messages for assert.strictEqual, as the default messages are a better option. PR-URL: #15995 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Nov 21, 2017
Remove test messages for assert.strictEqual, as the default messages are a better option. PR-URL: #15995 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
MylesBorins
pushed a commit
that referenced
this pull request
Nov 28, 2017
Remove test messages for assert.strictEqual, as the default messages are a better option. PR-URL: #15995 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
test-crypto