test: update assert error messages to be more descriptive#16035
Closed
s9tpepper wants to merge 1 commit intonodejs:masterfrom
Closed
test: update assert error messages to be more descriptive#16035s9tpepper wants to merge 1 commit intonodejs:masterfrom
s9tpepper wants to merge 1 commit intonodejs:masterfrom
Conversation
BridgeAR
approved these changes
Oct 6, 2017
| assert.strictEqual(res.value, 'val', `Expected res.value to equal 'val', got '${res.value}' instead.`); | ||
| assert.strictEqual(res.configurable, false, `Expected res.configurable to equal false, got ${res.configurable} instead.`); | ||
| assert.strictEqual(res.enumerable, false, `Expected res.enumerable to equal false, got ${res.enumerable} instead.`); | ||
| assert.strictEqual(res.writable, false, `Expected res.writable to equal false, got ${res.writable} instead.`); |
Member
There was a problem hiding this comment.
The line length is to long and has to be fixed before landing.
Member
There was a problem hiding this comment.
I would actually just remove the message.
jasnell
approved these changes
Oct 9, 2017
Member
jasnell
left a comment
There was a problem hiding this comment.
LGTM with the error messages just removed.
Member
|
Ping @s9tpepper Can you remove the error message? |
Member
|
Ping @s9tpepper |
BridgeAR
pushed a commit
that referenced
this pull request
Oct 19, 2017
PR-URL: #16035 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>
Member
|
I decided to just land this and to remove the messages on my own while landing. Landed in cf02981 Thanks for the PR, and congratulations on becoming a Node.js Contributor 🎉 ! |
MylesBorins
pushed a commit
that referenced
this pull request
Oct 23, 2017
PR-URL: #16035 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax
pushed a commit
to ayojs/ayo
that referenced
this pull request
Oct 26, 2017
PR-URL: nodejs/node#16035 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Nov 16, 2017
PR-URL: #16035 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Nov 21, 2017
PR-URL: #16035 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Nov 28, 2017
PR-URL: #16035 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax
pushed a commit
to ayojs/ayo
that referenced
this pull request
Dec 7, 2017
PR-URL: nodejs/node#16035 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
test