Closed
Conversation
__xrange()__ was removed in Python 3 in favor of __range()__. This PR ensures similar functionality on both Python 2 and Python 3. Discovered via https://travis-ci.com/nodejs/node/builds/79706150 (nodejs#21942)
Member
|
Refs: google/styleguide#332 |
addaleax
approved these changes
Jul 23, 2018
Member
Member
|
By the way, your author name in this commit is given as “cclauss”. Is that intended or do you prefer to be listed (changelog, git log, AUTHORS file) with some other name? People typically prefer their full name, but ultimately it’s up to you. |
Contributor
Author
|
cclauss is fine as the author name |
Contributor
Author
|
I can not make sense of these error reports. Please help. |
Member
|
@cclauss Re-running the failed CI. |
TimothyGu
approved these changes
Jul 24, 2018
Member
|
Let's try again. https://ci.nodejs.org/job/node-test-commit-windows-fanned/19457/ |
Member
|
Seems like everything passes now! |
jasnell
approved these changes
Jul 27, 2018
Member
|
Landed in bade0fe, thanks for the contribution! 🎉 |
addaleax
pushed a commit
that referenced
this pull request
Jul 27, 2018
__xrange()__ was removed in Python 3 in favor of __range()__. This PR ensures similar functionality on both Python 2 and Python 3. Discovered via https://travis-ci.com/nodejs/node/builds/79706150 (#21942). PR-URL: #21945 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jul 31, 2018
__xrange()__ was removed in Python 3 in favor of __range()__. This PR ensures similar functionality on both Python 2 and Python 3. Discovered via https://travis-ci.com/nodejs/node/builds/79706150 (#21942). PR-URL: #21945 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
This was referenced Aug 1, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
xrange() was removed in Python 3 in favor of range(). This PR ensures similar functionality on both Python 2 and Python 3.
Discovered via https://travis-ci.com/nodejs/node/builds/79706150 (#21942)
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes