tools: print a better message for unexpected use of globals#27083
Closed
targos wants to merge 2 commits intonodejs:masterfrom
Closed
tools: print a better message for unexpected use of globals#27083targos wants to merge 2 commits intonodejs:masterfrom
targos wants to merge 2 commits intonodejs:masterfrom
Conversation
Collaborator
BridgeAR
approved these changes
Apr 4, 2019
richardlau
approved these changes
Apr 4, 2019
ZYSzys
approved these changes
Apr 4, 2019
lpinca
approved these changes
Apr 4, 2019
cjihrig
approved these changes
Apr 4, 2019
Member
Author
|
Landed in dd89a11 |
targos
added a commit
that referenced
this pull request
Apr 6, 2019
PR-URL: #27083 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This was referenced Apr 23, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The error looks like this now: