tools: prohibit assert.doesNotReject() in Node.js core#27402
Closed
BridgeAR wants to merge 1 commit intonodejs:masterfrom
Closed
tools: prohibit assert.doesNotReject() in Node.js core#27402BridgeAR wants to merge 1 commit intonodejs:masterfrom
assert.doesNotReject() in Node.js core#27402BridgeAR wants to merge 1 commit intonodejs:masterfrom
Conversation
This makes sure we do not use `assert.doesNotReject()` anywhere in our code base. This is just a simple wrapper that catches the rejection and then rejects it again in case of an error. Thus, it is not useful to do that. The error message for `assert.doesNotThrow()` is also improved.
Collaborator
Trott
approved these changes
Apr 25, 2019
Collaborator
4 tasks
benjamingr
approved these changes
Apr 25, 2019
Member
benjamingr
left a comment
There was a problem hiding this comment.
I never got the point of doesNotReject but I presumed it's fine and people liked it 🤷
BethGriggs
approved these changes
Apr 25, 2019
jasnell
approved these changes
Apr 26, 2019
BridgeAR
added a commit
to BridgeAR/node
that referenced
this pull request
Apr 27, 2019
This makes sure we do not use `assert.doesNotReject()` anywhere in our code base. This is just a simple wrapper that catches the rejection and then rejects it again in case of an error. Thus, it is not useful to do that. The error message for `assert.doesNotThrow()` is also improved. PR-URL: nodejs#27402 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Member
Author
|
Landed in 31b3dd2 🎉 |
targos
pushed a commit
that referenced
this pull request
Apr 29, 2019
This makes sure we do not use `assert.doesNotReject()` anywhere in our code base. This is just a simple wrapper that catches the rejection and then rejects it again in case of an error. Thus, it is not useful to do that. The error message for `assert.doesNotThrow()` is also improved. PR-URL: #27402 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
This was referenced May 7, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes sure we do not use
assert.doesNotReject()anywhere inour code base. This is just a simple wrapper that catches the
rejection and then rejects it again in case of an error. Thus, it is
not useful to do that.
The error message for
assert.doesNotThrow()is also improved.@nodejs/linting PTAL
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes