Closed
Conversation
Original commit message:
[ic] Fix handling of +0/-0 when constant field tracking is enabled
... and ensure that runtime behaviour is in sync with the IC code.
Bug: chromium:950747, v8:9113
Change-Id: Ied66c9514cbe3a4d75fc71d4fc3b19ea1538f9b2
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1561319
Reviewed-by: Toon Verwaest <verwaest@chromium.org>
Commit-Queue: Igor Sheludko <ishell@chromium.org>
Cr-Commit-Position: refs/heads/master@{nodejs#60768}
Refs: v8/v8@94c87fe
Collaborator
Collaborator
BridgeAR
approved these changes
May 21, 2019
bnoordhuis
approved these changes
May 21, 2019
addaleax
approved these changes
May 21, 2019
devsnek
approved these changes
May 21, 2019
Member
|
I would like to fast track this PR to get it into a patch release tomorrow. Please +1 if you agree. |
Collaborator
Member
|
@addaleax @devsnek @targos @bnoordhuis @nodejs/v8-update are you fine to fast track this for the patch release today? This seems like a pretty bad bug to me that should be fixed soon. |
Merged
Member
|
Landed in f2fe1e5 🎉 |
BridgeAR
pushed a commit
to BridgeAR/node
that referenced
this pull request
May 22, 2019
Original commit message:
[ic] Fix handling of +0/-0 when constant field tracking is enabled
... and ensure that runtime behaviour is in sync with the IC code.
Bug: chromium:950747, v8:9113
Change-Id: Ied66c9514cbe3a4d75fc71d4fc3b19ea1538f9b2
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1561319
Reviewed-by: Toon Verwaest <verwaest@chromium.org>
Commit-Queue: Igor Sheludko <ishell@chromium.org>
Cr-Commit-Position: refs/heads/master@{nodejs#60768}
PR-URL: nodejs#27792
Fixes: nodejs#27784
Refs: v8/v8@94c87fe
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gus Caplan <me@gus.host>
Member
Author
|
I don't know if it's related but the linux-perf test failed: https://ci.nodejs.org/job/node-test-commit-v8-linux/2293/nodes=benchmark-ubuntu1604-intel-64,v8test=v8test/console |
BridgeAR
pushed a commit
that referenced
this pull request
May 22, 2019
Original commit message:
[ic] Fix handling of +0/-0 when constant field tracking is enabled
... and ensure that runtime behaviour is in sync with the IC code.
Bug: chromium:950747, v8:9113
Change-Id: Ied66c9514cbe3a4d75fc71d4fc3b19ea1538f9b2
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1561319
Reviewed-by: Toon Verwaest <verwaest@chromium.org>
Commit-Queue: Igor Sheludko <ishell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#60768}
PR-URL: #27792
Fixes: #27784
Refs: v8/v8@94c87fe
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gus Caplan <me@gus.host>
Member
|
@targos those already failed before. There is some issue around the benchmark test currently. |
BridgeAR
added a commit
to BridgeAR/node
that referenced
this pull request
May 22, 2019
Notable changes
* deps:
* Fix handling of +0/-0 when constant field tracking is enabled
(Michaël Zasso) nodejs#27792
* Fix `os.freemem()` and `os.totalmem` correctness (cjihrig)
nodejs#27718
* src:
* Fix v12.3.0 regression that prevents native addons from compiling
nodejs#27804
PR-URL: nodejs#27814
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original commit message:
Refs: v8/v8@94c87fe
Fixes: #27784