lib: add parent to ERR_UNKNOWN_FILE_EXTENSION message#30728
Closed
qualitymanifest wants to merge 4 commits intonodejs:masterfrom
qualitymanifest:add-parent-err-unknown-file-ext
Closed
lib: add parent to ERR_UNKNOWN_FILE_EXTENSION message#30728qualitymanifest wants to merge 4 commits intonodejs:masterfrom qualitymanifest:add-parent-err-unknown-file-ext
qualitymanifest wants to merge 4 commits intonodejs:masterfrom
qualitymanifest:add-parent-err-unknown-file-ext
Conversation
guybedford
reviewed
Nov 30, 2019
guybedford
approved these changes
Nov 30, 2019
Contributor
guybedford
left a comment
There was a problem hiding this comment.
Thanks for taking this one on, looks great.
trivikr
approved these changes
Nov 30, 2019
guybedford
reviewed
Nov 30, 2019
BridgeAR
approved these changes
Dec 2, 2019
jasnell
approved these changes
Dec 2, 2019
Collaborator
addaleax
approved these changes
Dec 3, 2019
Collaborator
Member
|
Windows CI rebuild: https://ci.nodejs.org/job/node-test-commit-windows-fanned/31957/ |
Collaborator
Collaborator
- default_resolve updated to pass parentURL into error - ERR_UNKNOWN_FILE_EXTENSION updated to include parentURL - test added to check for import message in error Fixes: #30721
Collaborator
Member
|
Windows CI rebuild: https://ci.nodejs.org/job/node-test-commit-windows-fanned/32003/ |
lpinca
approved these changes
Dec 6, 2019
Collaborator
Collaborator
Collaborator
guybedford
pushed a commit
that referenced
this pull request
Dec 7, 2019
- default_resolve updated to pass parentURL into error - ERR_UNKNOWN_FILE_EXTENSION updated to include parentURL - test added to check for import message in error PR-URL: #30728 Fixes: #30721 Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Contributor
|
Landed in 7ab21b2. |
targos
pushed a commit
that referenced
this pull request
Dec 9, 2019
- default_resolve updated to pass parentURL into error - ERR_UNKNOWN_FILE_EXTENSION updated to include parentURL - test added to check for import message in error PR-URL: #30728 Fixes: #30721 Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Jan 12, 2020
- default_resolve updated to pass parentURL into error - ERR_UNKNOWN_FILE_EXTENSION updated to include parentURL - test added to check for import message in error PR-URL: #30728 Fixes: #30721 Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
BethGriggs
pushed a commit
that referenced
this pull request
Feb 6, 2020
- default_resolve updated to pass parentURL into error - ERR_UNKNOWN_FILE_EXTENSION updated to include parentURL - test added to check for import message in error PR-URL: #30728 Fixes: #30721 Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
default_resolve.jsupdated to passparentURLinto errorERR_UNKNOWN_FILE_EXTENSIONupdated to includeparentURLFixes: #30721
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes