tools: use `is None` consistently in Python by Trott · Pull Request #36606 · nodejs/node

Trott · 2020-12-22T16:49:48Z

We use is None instead of == None everywhere (which mostly just
means test.py) except in one place in genv8constants.py. Switch to is None in genv8constants.py. This is slightly more efficient, although I
can't imagine that makes a measurable difference here.

Related Issues

Fixes: https://github.com/nodejs/node/issues/<issue_number>

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
commit message follows commit guidelines

Trott · 2020-12-22T17:07:19Z

I added two more minor changes: An explicit file close at the end of the script, and correcting the usage message.

Trott · 2020-12-22T17:54:18Z

I'm trying to test to make sure the script still works. Does it require a debug build? Do we not use this anymore and the right thing to do is delete it?

richardlau · 2020-12-22T18:05:13Z

I'm trying to test to make sure the script still works. Does it require a debug build? Do we not use this anymore and the right thing to do is delete it?

It's used in

node/node.gyp

Lines 1160 to 1178 in 5bd1eec

    
           'target_name': 'node_dtrace_ustack', 
        
           'type': 'none', 
        
           'conditions': [ 
        
             [ 'node_use_dtrace=="true" and OS!="mac" and OS!="linux"', { 
        
               'actions': [ 
        
                 { 
        
                   'action_name': 'node_dtrace_ustack_constants', 
        
                   'inputs': [ 
        
                     '<(obj_dir)/tools/v8_gypfiles/<(STATIC_LIB_PREFIX)v8_base_without_compiler<(STATIC_LIB_SUFFIX)' 
        
                   ], 
        
                   'outputs': [ 
        
                     '<(SHARED_INTERMEDIATE_DIR)/v8constants.h' 
        
                   ], 
        
                   'action': [ 
        
                     'tools/genv8constants.py', 
        
                     '<@(_outputs)', 
        
                     '<@(_inputs)' 
        
                   ] 
        
                 },

which requires dtrace to be enabled via configure. This looks to be the default for macOS and smartOS (according to configure):

node/configure.py

Line 514 in 083abe2

help='build with DTrace (default is true on sunos and darwin)')

Trott · 2020-12-22T18:22:36Z

This looks to be the default for macOS and smartOS

And because line 1163 excludes Mac and Linux unconditionally, this is probably only used on SmartOS?

node/node.gyp

Line 1163 in 5bd1eec

[ 'node_use_dtrace=="true" and OS!="mac" and OS!="linux"', {

nodejs-github-bot · 2020-12-24T02:26:14Z

CI: https://ci.nodejs.org/job/node-test-pull-request/35057/

We use `is None` instead of `== None` everywhere (which mostly just means test.py) except in one place in genv8constants.py. Switch to `is None` in genv8constants.py. This is slightly more efficient, although I can't imagine that makes a measurable difference here. PR-URL: nodejs#36606 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

PR-URL: nodejs#36606 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

Trott · 2020-12-25T12:29:20Z

Landed in 73a21e4...e068eec

We use `is None` instead of `== None` everywhere (which mostly just means test.py) except in one place in genv8constants.py. Switch to `is None` in genv8constants.py. This is slightly more efficient, although I can't imagine that makes a measurable difference here. PR-URL: #36606 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

PR-URL: #36606 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

We use `is None` instead of `== None` everywhere (which mostly just means test.py) except in one place in genv8constants.py. Switch to `is None` in genv8constants.py. This is slightly more efficient, although I can't imagine that makes a measurable difference here. PR-URL: #36606 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

PR-URL: #36606 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

nodejs-github-bot added the build Issues and PRs related to build files or the CI. label Dec 22, 2020

Trott added the python PRs and issues that require attention from people who are familiar with Python. label Dec 22, 2020

aduh95 approved these changes Dec 22, 2020

View reviewed changes

lpinca approved these changes Dec 22, 2020

View reviewed changes

Trott added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 24, 2020

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 24, 2020

Trott added 3 commits December 25, 2020 04:28

tools: call close() explicitly in genv8constants.py

18fc50f

PR-URL: nodejs#36606 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

tools: correct usage message for genv8constants.py

e068eec

PR-URL: nodejs#36606 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

Trott force-pushed the is-none branch from 2f51840 to e068eec Compare December 25, 2020 12:29

Trott merged commit e068eec into nodejs:master Dec 25, 2020

Trott deleted the is-none branch December 25, 2020 12:29

danielleadams pushed a commit that referenced this pull request Jan 12, 2021

tools: call close() explicitly in genv8constants.py

37b39a2

PR-URL: #36606 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

danielleadams pushed a commit that referenced this pull request Jan 12, 2021

tools: correct usage message for genv8constants.py

10f1c89

PR-URL: #36606 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

danielleadams mentioned this pull request Jan 12, 2021

v15.6.0 proposal #36889

Merged

targos pushed a commit that referenced this pull request May 1, 2021

tools: call close() explicitly in genv8constants.py

9990ec7

PR-URL: #36606 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

targos pushed a commit that referenced this pull request May 1, 2021

tools: correct usage message for genv8constants.py

d85ea61

PR-URL: #36606 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

danielleadams mentioned this pull request May 3, 2021

v14.17.0 proposal #38507

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

tools: use `is None` consistently in Python#36606

tools: use `is None` consistently in Python#36606
Trott merged 3 commits intonodejs:masterfrom
Trott:is-none

Trott commented Dec 22, 2020

Uh oh!

Trott commented Dec 22, 2020

Uh oh!

Trott commented Dec 22, 2020

Uh oh!

richardlau commented Dec 22, 2020

Uh oh!

Trott commented Dec 22, 2020 •

edited

Loading

Uh oh!

nodejs-github-bot commented Dec 24, 2020

Uh oh!

Trott commented Dec 25, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

Trott commented Dec 22, 2020

Related Issues

Checklist

Uh oh!

Trott commented Dec 22, 2020

Uh oh!

Trott commented Dec 22, 2020

Uh oh!

richardlau commented Dec 22, 2020

Uh oh!

Trott commented Dec 22, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nodejs-github-bot commented Dec 24, 2020

Uh oh!

Trott commented Dec 25, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Trott commented Dec 22, 2020 •

edited

Loading