doc: add missing semis after classes#38931
Closed
RaisinTen wants to merge 1 commit intonodejs:masterfrom
Closed
Conversation
Signed-off-by: Darshan Sen <raisinten@gmail.com>
bl-ue
approved these changes
Jun 4, 2021
Contributor
bl-ue
left a comment
There was a problem hiding this comment.
But this should be caught by the linter. 🤔
jasnell
approved these changes
Jun 4, 2021
Member
JS linter runs on the docs but not the C++ linter. |
Trott
approved these changes
Jun 4, 2021
Lxxyx
approved these changes
Jun 5, 2021
lpinca
approved these changes
Jun 8, 2021
Contributor
|
Landed in cf609cc...ad27e0e |
nodejs-github-bot
pushed a commit
that referenced
this pull request
Jun 10, 2021
Signed-off-by: Darshan Sen <raisinten@gmail.com> PR-URL: #38931 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Contributor
|
May I please ask: why |
Member
Actually because I was using my phone and not my computer at the time |
targos
pushed a commit
that referenced
this pull request
Jun 11, 2021
Signed-off-by: Darshan Sen <raisinten@gmail.com> PR-URL: #38931 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Contributor
Ah, simple enough! 😆 Thanks! |
Merged
danielleadams
pushed a commit
that referenced
this pull request
Jun 17, 2021
Signed-off-by: Darshan Sen <raisinten@gmail.com> PR-URL: #38931 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
richardlau
pushed a commit
that referenced
this pull request
Jul 19, 2021
Signed-off-by: Darshan Sen <raisinten@gmail.com> PR-URL: #38931 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
richardlau
pushed a commit
that referenced
this pull request
Jul 20, 2021
Signed-off-by: Darshan Sen <raisinten@gmail.com> PR-URL: #38931 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
foxxyz
pushed a commit
to foxxyz/node
that referenced
this pull request
Oct 18, 2021
Signed-off-by: Darshan Sen <raisinten@gmail.com> PR-URL: nodejs#38931 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Darshan Sen raisinten@gmail.com