src: remove OnScopeLeaveImpl's move assignment overload#48732
Merged
nodejs-github-bot merged 3 commits intonodejs:mainfrom Jul 16, 2023
Merged
src: remove OnScopeLeaveImpl's move assignment overload#48732nodejs-github-bot merged 3 commits intonodejs:mainfrom
nodejs-github-bot merged 3 commits intonodejs:mainfrom
Conversation
RaisinTen
reviewed
Jul 11, 2023
RaisinTen
approved these changes
Jul 12, 2023
Member
RaisinTen
left a comment
There was a problem hiding this comment.
LGTM. Do you mind updating the PR title, description and the first commit message (requires a force push, so if you're not okay with doing that, let me know and this could be fixed manually while landing your change) to describe the latest change (the deletion of the operator overload and the reasoning)?
Contributor
Author
|
I'll do that |
08692d7 to
ba93f28
Compare
Contributor
Author
|
@RaisinTen done |
Member
|
Thanks @CGQAQ! The |
... as it's not valid implementation and also has not been used
ba93f28 to
750f797
Compare
Contributor
Author
|
@RaisinTen done |
RaisinTen
approved these changes
Jul 12, 2023
Collaborator
Contributor
Author
|
@RaisinTen Is there anything else I need to do? |
Member
|
Nope. :) This change should be good to land after this has been open for a week. However, if someone else approves this PR, it can land instantly. (for reference - https://github.com/nodejs/node/blob/main/doc/contributing/pull-requests.md#step-10-landing) |
lpinca
approved these changes
Jul 15, 2023
Collaborator
|
Landed in 373848a |
Ceres6
pushed a commit
to Ceres6/node
that referenced
this pull request
Aug 14, 2023
... as it's not valid implementation and also has not been used PR-URL: nodejs#48732 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Ceres6
pushed a commit
to Ceres6/node
that referenced
this pull request
Aug 14, 2023
... as it's not valid implementation and also has not been used PR-URL: nodejs#48732 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
UlisesGascon
pushed a commit
to UlisesGascon/node
that referenced
this pull request
Aug 14, 2023
... as it's not valid implementation and also has not been used PR-URL: nodejs#48732 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
RafaelGSS
pushed a commit
that referenced
this pull request
Aug 15, 2023
... as it's not valid implementation and also has not been used PR-URL: #48732 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
targos
pushed a commit
that referenced
this pull request
Nov 27, 2023
... as it's not valid implementation and also has not been used PR-URL: #48732 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
sercher
added a commit
to sercher/graaljs
that referenced
this pull request
Apr 25, 2024
... as it's not valid implementation and also has not been used PR-URL: nodejs/node#48732 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
sercher
added a commit
to sercher/graaljs
that referenced
this pull request
Apr 25, 2024
... as it's not valid implementation and also has not been used PR-URL: nodejs/node#48732 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes OnScopeLeaveImpl's move assignment overload as it's not valid implementation and also has not been used