fs: add support for URL for fs.glob's cwd option#58182
Merged
nodejs-github-bot merged 3 commits intonodejs:mainfrom May 11, 2025
Merged
fs: add support for URL for fs.glob's cwd option#58182nodejs-github-bot merged 3 commits intonodejs:mainfrom
URL for fs.glob's cwd option#58182nodejs-github-bot merged 3 commits intonodejs:mainfrom
Conversation
cjihrig
approved these changes
May 5, 2025
Collaborator
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #58182 +/- ##
=======================================
Coverage 90.14% 90.14%
=======================================
Files 630 630
Lines 186784 186785 +1
Branches 36653 36654 +1
=======================================
+ Hits 168377 168379 +2
- Misses 11205 11210 +5
+ Partials 7202 7196 -6
🚀 New features to boost your workflow:
|
anonrig
reviewed
May 5, 2025
| constructor(pattern, options = kEmptyObject) { | ||
| validateObject(options, 'options'); | ||
| const { exclude, cwd, withFileTypes } = options; | ||
| this.#root = cwd ?? '.'; |
Member
There was a problem hiding this comment.
Nit: These additions make optimizations extremely hard. We should avoid adding them.
Contributor
Author
There was a problem hiding this comment.
You're commenting on a deleted line, it's not very clear what you mean
Member
There was a problem hiding this comment.
Adding a URL support to input field
aduh95
commented
May 5, 2025
Collaborator
LiviaMedeiros
approved these changes
May 6, 2025
This comment was marked as outdated.
This comment was marked as outdated.
Collaborator
jasnell
approved these changes
May 7, 2025
Collaborator
Collaborator
jazelly
approved these changes
May 7, 2025
Collaborator
Collaborator
|
Landed in 3ad7362 |
targos
pushed a commit
that referenced
this pull request
May 16, 2025
PR-URL: #58182 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jason Zhang <xzha4350@gmail.com>
aduh95
added a commit
that referenced
this pull request
Jun 10, 2025
PR-URL: #58182 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jason Zhang <xzha4350@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For the sake of consistency, all the Node.js APIs that take a path also accept
URLinstances.