Render “About this documentation” on the docs landing page#60673
Closed
Han5991 wants to merge 1 commit intonodejs:mainfrom
Closed
Render “About this documentation” on the docs landing page#60673Han5991 wants to merge 1 commit intonodejs:mainfrom
Han5991 wants to merge 1 commit intonodejs:mainfrom
Conversation
Collaborator
|
Review requested:
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #60673 +/- ##
==========================================
- Coverage 88.53% 88.01% -0.53%
==========================================
Files 703 703
Lines 208077 208077
Branches 40078 39995 -83
==========================================
- Hits 184224 183131 -1093
- Misses 15888 16923 +1035
- Partials 7965 8023 +58 🚀 New features to boost your workflow:
|
Contributor
|
I'm not sure this is desirable, it current behavior is a much better UX for mobile users IMO |
Contributor
Author
I’d stick with the current layout. The duplicate TOC isn’t great on desktop, but on phones/tablets that list |
Contributor
|
COuldn't have said it better myself, I guess we can close this then |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #60667
introduction instead of a duplicated TOC
anchor tags without href, replacing the TOC picker markup, and keeping anchor validation intact