[v25.x] v8: changing total_allocated_bytes to avoid ABI changes #60800

caiolima · 2025-11-21T14:24:02Z

As noted by @targos in #60429 (comment), the implementation of total_allocated_bytes changes the ABI. This PR changes original V8 implementation to a version where there's no addition of HeapStatistics::total_allocated_bytes_ to V8's HeapStatistics, and instead we get such values using Isolate::GetTotalAllocatedBytes. This also changes code introduced by #60573 to use this new API on either v8.getHeapStatistics() and Worker::GetHeapStatistics. The goal here is to make total_allocated_bytes back portable to previous versions, but keeping the v8.getHeapStatistics() API stable once users transition from v25 to future versions. It also solves the ABI change introduced by https://github.com/nodejs/node/pull/60429/files

There's also a fix on documentation text with missing . and updating the code snippet to include total_allocated_bytes on output.

nodejs-github-bot · 2025-11-21T14:24:09Z

Review requested:

@nodejs/gyp
@nodejs/security-wg
@nodejs/v8-update

RafaelGSS

LGTM.

nodejs-github-bot · 2025-11-23T00:07:26Z

CI: https://ci.nodejs.org/job/node-test-pull-request/70277/

caiolima · 2025-11-25T11:51:04Z

Hi all, could someone help me trigger CI again, please?

caiolima · 2025-12-01T15:59:29Z

Up

nodejs-github-bot · 2025-12-08T11:53:56Z

CI: https://ci.nodejs.org/job/node-test-pull-request/70419/

caiolima · 2025-12-17T11:14:07Z

I'm getting permission errors to look what is failing on CI. Probably it already expired. Does any of you have permission to see what's failing?

github-actions · 2026-01-16T01:16:59Z

Failed to start CI

   ⚠  Commits were pushed since the last approving review:
   ⚠  - tools: fix linter warning in `test-shared.yml`
   ⚠  - doc: correct concurrency wording in test() documentation
   ⚠  - build: fix OpenSSL version parsing for OpenSSL < 3
   ⚠  - test_runner: simplify code and make it more consistent
   ⚠  - repl: tab completion targets `` instead of `new `
   ⚠  - tools: bump js-yaml from 4.1.0 to 4.1.1 in /tools/lint-md
   ⚠  - deps: update brotli to 1.2.0
   ⚠  - deps: upgrade npm to 11.6.3
   ⚠  - tools: dump config.gypi as json
   ⚠  - lib: prefer `call()` over `apply()` if argument list is not array
   ⚠  - src: rename config file testRunner to test
   ⚠  - src: add test flag to config file
   ⚠  - src: add permission flag to config file
   ⚠  - doc: fix webstorage config file property
   ⚠  - src: implicitly enable namespace in config
   ⚠  - doc: keep sidebar module visible when navigating docs
   ⚠  - deps: update sqlite to 3.51.0
   ⚠  - deps: add temporal_rs 0.1.0
   ⚠  - build: add temporal_capi gyp
   ⚠  - test: add basic temporal presence check
   ⚠  - build: ignore built-in temporal when building with shared lib
   ⚠  - url: remove array.reduce usage
   ⚠  - test_runner: fix line feed escaping in JUnit
   ⚠  - test: use `RegExp.escape` to improve test reliability
   ⚠  - doc: add additional codemods for deprecation
   ⚠  - test: prefer major GC in cppgc-object teardown
   ⚠  - test: ensure assertions are reached on more tests
   ⚠  - test: ensure assertions are reached on more tests
   ⚠  - test: ensure assertions are reached on more tests
   ⚠  - test: ensure assertions are reached on more tests
   ⚠  - tools: add temporal updater
   ⚠  - test: replace deprecated regex test assertions in http trailers test
   ⚠  - doc: add fullName property to SuiteContext
   ⚠  - test: add lint rule to forbid use of `assert.ok(/regex/.test(…))`
   ⚠  - events: repurpose `events.listenerCount()` to accept EventTargets
   ⚠  - src: mark unused private field as such
   ⚠  - src: simply uint32 to string as it must not fail
   ⚠  - lib: add lint rules for reflective function calls
   ⚠  - test: ensure assertions are reached on all tests
   ⚠  - test: fix debug test crashes caused by sea tests
   ⚠  - doc: mark module.register as active development
   ⚠  - util: safely inspect getter errors whose message throws
   ⚠  - node-api: fix data race and use-after-free in napi_threadsafe_function
   ⚠  - src: handle indexed properties in `process.env`
   ⚠  - deps: upgrade npm to 11.6.4
   ⚠  - doc: fix typos in changelogs
   ⚠  - doc: correct 'event handle' to 'event handler' in Utf8Stream drop event
   ⚠  - test: skip failing tests when compiled without amaro
   ⚠  - doc: update debuglog examples to use 'foo-bar' instead of 'foo'
   ⚠  - src: use static_cast instead of C-style cast
   ⚠  - test: fix embedtest in debug windows
   ⚠  - doc: correct spelling in BUILDING.md
   ⚠  - doc: replace column with columnNumber in example of `util.getCallSites`
   ⚠  - deps: update corepack to 0.34.5
   ⚠  - test: use `assert.match` for non-literal regexp tests
   ⚠  - doc: show the use of string expressions in the SQLTagStore example
   ⚠  - lib,test: fix jsdoc comments
   ⚠  - test: lint more `assert(regexp.test(...))` cases
   ⚠  - doc: clarify fileURLToPath security considerations
   ⚠  - util: improve textencoder encodeInto performance
   ⚠  - src: handle DER decoding errors from system certificates
   ⚠  - tools: don't fetch V8 deps in the source tree
   ⚠  - build: run embedtest with node_g when BUILDTYPE=Debug
   ⚠  - test: update WPT for WebCryptoAPI to 1e4933113d
   ⚠  - deps: update zlib to 1.3.1-63d7e16
   ⚠  - deps: update sqlite to 3.51.1
   ⚠  - deps,src: prepare for cpplint update
   ⚠  - tools: disable some new cpplint rules before update
   ⚠  - tools: update cpplint to 2.0.2
   ⚠  - tools: refloat 10 Node.js patches to cpplint.py
   ⚠  - src: fix off-thread cert loading in bundled cert mode
   ⚠  - test: skip SEA inspect test if inspector is not available
   ⚠  - tools: update ESLint dependencies
   ⚠  - tools: remove deprecated ESLint plugins
   ⚠  - tools: replace deprecated eslint-plugin-markdown
   ⚠  - doc: add missing `zstd` to mjs example of zlib
   ⚠  - benchmark: fix incorrect base64 input in byteLength benchmark
   ⚠  - tools: run tests `--without-amaro` on test-shared macOS
   ⚠  - stream: fix isErrored/isWritable for WritableStreams
   ⚠  - tools: enforce trailing commas in `test/sequential`
   ⚠  - tools: enforce trailing commas in `test/es-module`
   ⚠  - tools: ignore more paths in GHA CI
   ⚠  - util: assert getCallSites does not invoke Error.prepareStackTrace
   ⚠  - meta: bump peter-evans/create-pull-request from 7.0.8 to 7.0.9
   ⚠  - meta: bump actions/checkout from 5.0.1 to 6.0.0
   ⚠  - meta: bump github/codeql-action from 4.31.3 to 4.31.6
   ⚠  - meta: bump actions/setup-python from 6.0.0 to 6.1.0
   ⚠  - module: allow subpath imports that start with `#/`
   ⚠  - tools: bump mdast-util-to-hast from 13.2.0 to 13.2.1 in /tools/doc
   ⚠  - src: implement Windows-1252 encoding support and update related tests
   ⚠  - http2,zlib: prefer `call()` over `apply()` if argument list is not array
   ⚠  - test: improve config-file permission test coverage
   ⚠  - esm: improve error messages for ambiguous module syntax
   ⚠  - doc: add File modes cross-references in fs methods
   ⚠  - tools: add some options and comments to `shell.nix`
   ⚠  - test: skip tests not passing without `NODE_OPTIONS` support
   ⚠  - deps: V8: cherry-pick 72b0e27bd936
   ⚠  - lib: do not provide an empty Proxy from localStorage getter
   ⚠  - v8: changing total_allocated_bytes to avoid ABI changes
   ⚠  - increasing node embedder number
   ✘  Refusing to run CI on potentially unsafe PR

https://github.com/nodejs/node/actions/runs/21052182155

aduh95 · 2026-01-20T12:43:02Z

This needs a rebase

caiolima · 2026-01-20T16:14:33Z

Done. Thanks for the ping.

caiolima · 2026-01-21T14:16:09Z

The error seems unrelated to this PR. Could anybody trigger the CI again please?

nodejs-github-bot · 2026-01-22T14:33:30Z

CI: https://ci.nodejs.org/job/node-test-pull-request/70962/

nodejs-github-bot · 2026-01-23T11:01:49Z

CI: https://ci.nodejs.org/job/node-test-pull-request/70981/

nodejs-github-bot · 2026-01-23T22:38:14Z

CI: https://ci.nodejs.org/job/node-test-pull-request/70991/

nodejs-github-bot · 2026-01-23T22:54:26Z

CI: https://ci.nodejs.org/job/node-test-pull-request/70992/

aduh95 · 2026-01-24T00:49:19Z

Landed in e88dd01

caiolima · 2026-01-26T14:48:25Z

Thank you very much!

This MR contains the following updates: | Package | Update | Change | |---|---|---| | [node](https://nodejs.org) ([source](https://github.com/nodejs/node)) | minor | `25.4.0` → `25.5.0` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>nodejs/node (node)</summary> ### [`v25.5.0`](https://github.com/nodejs/node/releases/tag/v25.5.0): 2026-01-26, Version 25.5.0 (Current), @aduh95 [Compare Source](nodejs/node@v25.4.0...v25.5.0) ##### Notable Changes - \[[`99a4e51f93`](nodejs/node@99a4e51f93)] - **crypto**: update root certificates to NSS 3.119 (Node.js GitHub Bot) [#61419](nodejs/node#61419) - \[[`fbe4da5725`](nodejs/node@fbe4da5725)] - **(SEMVER-MINOR)** **deps**: add LIEF as a dependency (Joyee Cheung) [#61167](nodejs/node#61167) - \[[`0feab0f083`](nodejs/node@0feab0f083)] - **(SEMVER-MINOR)** **deps**: add tools and scripts to pull LIEF as a dependency (Joyee Cheung) [#61167](nodejs/node#61167) - \[[`e91b296001`](nodejs/node@e91b296001)] - **(SEMVER-MINOR)** **fs**: add ignore option to fs.watch (Matteo Collina) [#61433](nodejs/node#61433) - \[[`b351910af1`](nodejs/node@b351910af1)] - **(SEMVER-MINOR)** **sea**: add `--build-sea` to generate SEA directly with Node.js binary (Joyee Cheung) [#61167](nodejs/node#61167) - \[[`957292e233`](nodejs/node@957292e233)] - **(SEMVER-MINOR)** **sea**: split sea binary manipulation code (Joyee Cheung) [#61167](nodejs/node#61167) - \[[`f289817ff8`](nodejs/node@f289817ff8)] - **(SEMVER-MINOR)** **sqlite**: enable defensive mode by default (Bart Louwers) [#61266](nodejs/node#61266) - \[[`069f3603e2`](nodejs/node@069f3603e2)] - **(SEMVER-MINOR)** **sqlite**: add sqlite prepare options args (Guilherme Araújo) [#61311](nodejs/node#61311) - \[[`5a984b9a09`](nodejs/node@5a984b9a09)] - **src**: use node- prefix on thread names (Stewart X Addison) [#61307](nodejs/node#61307) - \[[`75c06bc2a8`](nodejs/node@75c06bc2a8)] - **(SEMVER-MINOR)** **test**: migrate to `--build-sea` in existing SEA tests (Joyee Cheung) [#61167](nodejs/node#61167) - \[[`cabd58f1cb`](nodejs/node@cabd58f1cb)] - **(SEMVER-MINOR)** **test**: use fixture directories for sea tests (Joyee Cheung) [#61167](nodejs/node#61167) - \[[`ff1fcabfc9`](nodejs/node@ff1fcabfc9)] - **(SEMVER-MINOR)** **test\_runner**: support expecting a test-case to fail (Jacob Smith) [#60669](nodejs/node#60669) ##### Commits - \[[`778a56f3c9`](nodejs/node@778a56f3c9)] - **assert,util**: fix deep comparison for sets and maps with mixed types (Ruben Bridgewater) [#61388](nodejs/node#61388) - \[[`32cd18e37f`](nodejs/node@32cd18e37f)] - **async\_hooks**: enabledHooksExist shall return if hooks are enabled (Gerhard Stöbich) [#61054](nodejs/node#61054) - \[[`482b2568bc`](nodejs/node@482b2568bc)] - **benchmark**: add SQLite benchmarks (Guilherme Araújo) [#61401](nodejs/node#61401) - \[[`e9a34263bb`](nodejs/node@e9a34263bb)] - **buffer**: make methods work on Uint8Array instances (Neal Beeken) [#56578](nodejs/node#56578) - \[[`8255cdefcf`](nodejs/node@8255cdefcf)] - **build**: add `--shared-nbytes` configure flag (Antoine du Hamel) [#61341](nodejs/node#61341) - \[[`8dd379d110`](nodejs/node@8dd379d110)] - **build**: update android-patches/trap-handler.h.patch (Mo Luo) [#60369](nodejs/node#60369) - \[[`1b4b5eb0e4`](nodejs/node@1b4b5eb0e4)] - **build**: update devcontainer.json to use paired nix env (Joyee Cheung) [#61414](nodejs/node#61414) - \[[`86e2a763ad`](nodejs/node@86e2a763ad)] - **build**: infer cargo mode with gyp var build\_type directly (Chengzhong Wu) [#61354](nodejs/node#61354) - \[[`7e211e6942`](nodejs/node@7e211e6942)] - **build**: add embedtest into native suite (Joyee Cheung) [#61357](nodejs/node#61357) - \[[`637470e79f`](nodejs/node@637470e79f)] - **build**: fix misplaced comma in ldflags (hqzing) [#61294](nodejs/node#61294) - \[[`a1a0f77a45`](nodejs/node@a1a0f77a45)] - **build**: fix crate vendor file checksums on windows (Chengzhong Wu) [#61329](nodejs/node#61329) - \[[`d597b8e342`](nodejs/node@d597b8e342)] - **build,tools**: fix addon build deadlock on errors (Vladimir Morozov) [#61321](nodejs/node#61321) - \[[`b5cdc27ba4`](nodejs/node@b5cdc27ba4)] - **build,win**: improve logs when ClangCL is missing (Mike McCready) [#61438](nodejs/node#61438) - \[[`ef01f0c033`](nodejs/node@ef01f0c033)] - **build,win**: update WinGet configurations to Python 3.14 (Mike McCready) [#61431](nodejs/node#61431) - \[[`d8a1cdeefe`](nodejs/node@d8a1cdeefe)] - **child\_process**: treat ipc length header as unsigned uint32 (Ryuhei Shima) [#61344](nodejs/node#61344) - \[[`588b00fafa`](nodejs/node@588b00fafa)] - **cluster**: fix port reuse between cluster (Ryuhei Shima) [#60141](nodejs/node#60141) - \[[`99a4e51f93`](nodejs/node@99a4e51f93)] - **crypto**: update root certificates to NSS 3.119 (Node.js GitHub Bot) [#61419](nodejs/node#61419) - \[[`048f7a5c9c`](nodejs/node@048f7a5c9c)] - **deps**: upgrade npm to 11.8.0 (npm team) [#61466](nodejs/node#61466) - \[[`fbe4da5725`](nodejs/node@fbe4da5725)] - **(SEMVER-MINOR)** **deps**: add LIEF as a dependency (Joyee Cheung) [#61167](nodejs/node#61167) - \[[`0feab0f083`](nodejs/node@0feab0f083)] - **(SEMVER-MINOR)** **deps**: add tools and scripts to pull LIEF as a dependency (Joyee Cheung) [#61167](nodejs/node#61167) - \[[`4bb00d7e3c`](nodejs/node@4bb00d7e3c)] - **deps**: update googletest to [`8508785`](nodejs/node@8508785) (Node.js GitHub Bot) [#61417](nodejs/node#61417) - \[[`6a3c614f27`](nodejs/node@6a3c614f27)] - **deps**: update sqlite to 3.51.2 (Node.js GitHub Bot) [#61339](nodejs/node#61339) - \[[`13c0397d6d`](nodejs/node@13c0397d6d)] - **deps**: update icu to 78.2 (Node.js GitHub Bot) [#60523](nodejs/node#60523) - \[[`098ec6f196`](nodejs/node@098ec6f196)] - **deps**: update ada to v3.4.0 (Yagiz Nizipli) [#61315](nodejs/node#61315) - \[[`320b576125`](nodejs/node@320b576125)] - **deps**: update zlib to 1.3.1-e00f703 (Node.js GitHub Bot) [#61135](nodejs/node#61135) - \[[`98f5e7cf51`](nodejs/node@98f5e7cf51)] - **deps**: V8: cherry-pick [highway@`dcc0ca1`](https://github.com/highway/node/commit/dcc0ca1cd42) (Richard Lau) [#61008](nodejs/node#61008) - \[[`e326df79c9`](nodejs/node@e326df79c9)] - **deps**: V8: backport [`209d2db`](nodejs/node@209d2db9e24a) (Zhijin Zeng) [#61322](nodejs/node#61322) - \[[`ccfd9d9b30`](nodejs/node@ccfd9d9b30)] - **doc**: remove `v` prefix for version references (Mike McCready) [#61488](nodejs/node#61488) - \[[`b6cc5d77a1`](nodejs/node@b6cc5d77a1)] - **doc**: mention constructor comparison in assert.deepStrictEqual (Hamza Kargin) [#60253](nodejs/node#60253) - \[[`236d7ee635`](nodejs/node@236d7ee635)] - **doc**: add CVE delay mention (Rafael Gonzaga) [#61465](nodejs/node#61465) - \[[`0729fb6ee7`](nodejs/node@0729fb6ee7)] - **doc**: update previous version links in BUILDING (Mike McCready) [#61457](nodejs/node#61457) - \[[`0fb464252f`](nodejs/node@0fb464252f)] - **doc**: include OpenJSF handle for security stewards (Rafael Gonzaga) [#61454](nodejs/node#61454) - \[[`3331bdca7c`](nodejs/node@3331bdca7c)] - **doc**: clarify process.argv\[1] behavior for -e/--eval (Jeevankumar S) [#61366](nodejs/node#61366) - \[[`94b34c38e2`](nodejs/node@94b34c38e2)] - **doc**: remove Windows Dev Home instructions from BUILDING (Mike McCready) [#61434](nodejs/node#61434) - \[[`a17016ee81`](nodejs/node@a17016ee81)] - **doc**: clarify TypedArray properties on Buffer (Roman Reiss) [#61355](nodejs/node#61355) - \[[`214fac9d7e`](nodejs/node@214fac9d7e)] - **doc**: update Python 3.14 manual install instructions (Windows) (Mike McCready) [#61428](nodejs/node#61428) - \[[`6a32a685a6`](nodejs/node@6a32a685a6)] - **doc**: note resume build should not be done on node-test-commit (Stewart X Addison) [#61373](nodejs/node#61373) - \[[`2a8e8dfaf3`](nodejs/node@2a8e8dfaf3)] - **doc**: refine WebAssembly error documentation (sangwook) [#61382](nodejs/node#61382) - \[[`f3caf27f8b`](nodejs/node@f3caf27f8b)] - **doc**: add deprecation history for url.parse (Eng Zer Jun) [#61389](nodejs/node#61389) - \[[`5ab8057856`](nodejs/node@5ab8057856)] - **doc**: add marco and rafael in last sec release (Marco Ippolito) [#61383](nodejs/node#61383) - \[[`f83cb1e785`](nodejs/node@f83cb1e785)] - **doc**: packages: example of private import switch to internal (coderaiser) [#61343](nodejs/node#61343) - \[[`3d23bcd0e2`](nodejs/node@3d23bcd0e2)] - **doc**: add esm and cjs examples to node:v8 (Alfredo González) [#61328](nodejs/node#61328) - \[[`1d159550e0`](nodejs/node@1d159550e0)] - **doc**: added 'secure' event to tls.TLSSocket (ikeyan) [#61066](nodejs/node#61066) - \[[`90080d2892`](nodejs/node@90080d2892)] - **doc**: restore [@watilde](https://github.com/watilde) to collaborators (Daijiro Wachi) [#61350](nodejs/node#61350) - \[[`a87f7a50f8`](nodejs/node@a87f7a50f8)] - **doc**: run license-builder (github-actions\[bot]) [#61348](nodejs/node#61348) - \[[`adf5c84701`](nodejs/node@adf5c84701)] - **doc**: clean up writing-and-running-benchmarks.md (Hardanish Singh) [#61345](nodejs/node#61345) - \[[`2be98add0c`](nodejs/node@2be98add0c)] - **doc**: document ALPNCallback option for TLSSocket constructor (ikeyan) [#61331](nodejs/node#61331) - \[[`2db4893c8d`](nodejs/node@2db4893c8d)] - **esm**: ensure watch mode restarts after syntax errors (Xavier Stouder) [#61232](nodejs/node#61232) - \[[`828feb2e6b`](nodejs/node@828feb2e6b)] - **events**: remove redundant todo (Gürgün Dayıoğlu) [#60595](nodejs/node#60595) - \[[`e91b296001`](nodejs/node@e91b296001)] - **(SEMVER-MINOR)** **fs**: add ignore option to fs.watch (Matteo Collina) [#61433](nodejs/node#61433) - \[[`606184fae5`](nodejs/node@606184fae5)] - **fs**: remove duplicate getValidatedPath calls (Mert Can Altin) [#61359](nodejs/node#61359) - \[[`434fcd7f8f`](nodejs/node@434fcd7f8f)] - **fs**: fix errorOnExist behavior for directory copy in fs.cp (Nicholas Paun) [#60946](nodejs/node#60946) - \[[`bacba16f5e`](nodejs/node@bacba16f5e)] - **fs**: fix ENOTDIR in globSync when file is treated as dir (sangwook) [#61259](nodejs/node#61259) - \[[`7697ce0310`](nodejs/node@7697ce0310)] - **fs**: remove duplicate fd validation in sync functions (Mert Can Altin) [#61361](nodejs/node#61361) - \[[`8abd54f597`](nodejs/node@8abd54f597)] - **gyp**: aix: change gcc version detection so CXX="ccache g++" works (Stewart X Addison) [#61464](nodejs/node#61464) - \[[`24033ee7ea`](nodejs/node@24033ee7ea)] - **http**: fix rawHeaders exceeding maxHeadersCount limit (Max Harari) [#61285](nodejs/node#61285) - \[[`cf56327939`](nodejs/node@cf56327939)] - **http2**: validate initialWindowSize per HTTP/2 spec (Matteo Collina) [#61402](nodejs/node#61402) - \[[`696935eeeb`](nodejs/node@696935eeeb)] - **inspector**: initial support storage inspection (Ryuhei Shima) [#61139](nodejs/node#61139) - \[[`3d5e718e38`](nodejs/node@3d5e718e38)] - **lib**: fix typo in `util.js` comment (Taejin Kim) [#61365](nodejs/node#61365) - \[[`f55a5fea00`](nodejs/node@f55a5fea00)] - **lib**: fix TypeScript support check in jitless mode (sangwook) [#61382](nodejs/node#61382) - \[[`b3fbc3c375`](nodejs/node@b3fbc3c375)] - **meta**: do not fast-track npm updates (Antoine du Hamel) [#61475](nodejs/node#61475) - \[[`2423ecdaef`](nodejs/node@2423ecdaef)] - **meta**: fix typos in issue template config (Daijiro Wachi) [#61399](nodejs/node#61399) - \[[`e2df85a33a`](nodejs/node@e2df85a33a)] - **meta**: label v8 module MRs (René) [#61325](nodejs/node#61325) - \[[`bc9e5f7d4d`](nodejs/node@bc9e5f7d4d)] - **node-api**: fix node\_api\_create\_object\_with\_properties name (Vladimir Morozov) [#61319](nodejs/node#61319) - \[[`4f30c21c59`](nodejs/node@4f30c21c59)] - **node-api**: use Node-API in comments (Vladimir Morozov) [#61320](nodejs/node#61320) - \[[`62d71eb28d`](nodejs/node@62d71eb28d)] - **quic**: copy options.certs buffer instead of detaching (Chengzhong Wu) [#61403](nodejs/node#61403) - \[[`4bbbe75ba1`](nodejs/node@4bbbe75ba1)] - **quic**: move quic behind compile time flag (Matteo Collina) [#61444](nodejs/node#61444) - \[[`b351910af1`](nodejs/node@b351910af1)] - **(SEMVER-MINOR)** **sea**: add --build-sea to generate SEA directly with Node.js binary (Joyee Cheung) [#61167](nodejs/node#61167) - \[[`957292e233`](nodejs/node@957292e233)] - **(SEMVER-MINOR)** **sea**: split sea binary manipulation code (Joyee Cheung) [#61167](nodejs/node#61167) - \[[`f289817ff8`](nodejs/node@f289817ff8)] - **(SEMVER-MINOR)** **sqlite**: enable defensive mode by default (Bart Louwers) [#61266](nodejs/node#61266) - \[[`6442229880`](nodejs/node@6442229880)] - **sqlite**: add some tests (Guilherme Araújo) [#61410](nodejs/node#61410) - \[[`069f3603e2`](nodejs/node@069f3603e2)] - **(SEMVER-MINOR)** **sqlite**: add sqlite prepare options args (Guilherme Araújo) [#61311](nodejs/node#61311) - \[[`df02d00d61`](nodejs/node@df02d00d61)] - **src**: improve StringBytes::Encode perf on UTF8 (Сковорода Никита Андреевич) [#61131](nodejs/node#61131) - \[[`e35814ba80`](nodejs/node@e35814ba80)] - **src**: add missing override specifier to Clean() (Tobias Nießen) [#61429](nodejs/node#61429) - \[[`803ff7d3de`](nodejs/node@803ff7d3de)] - **src**: cache context lookup in vectored io loops (Mert Can Altin) [#61387](nodejs/node#61387) - \[[`58abe99cbf`](nodejs/node@58abe99cbf)] - **src**: cache missing package.json files in the C++ package config cache (Michael Smith) [#60425](nodejs/node#60425) - \[[`2a542094e4`](nodejs/node@2a542094e4)] - **src**: use starts\_with instead of rfind/find (Tobias Nießen) [#61426](nodejs/node#61426) - \[[`77cacf6d9d`](nodejs/node@77cacf6d9d)] - **src**: use C++ nullptr in sqlite (Tobias Nießen) [#61416](nodejs/node#61416) - \[[`344cc629d4`](nodejs/node@344cc629d4)] - **src**: use C++ nullptr in webstorage (Tobias Nießen) [#61407](nodejs/node#61407) - \[[`9f25cad26c`](nodejs/node@9f25cad26c)] - **src**: fix pointer alignment (jhofstee) [#61336](nodejs/node#61336) - \[[`5a984b9a09`](nodejs/node@5a984b9a09)] - **src**: use node- prefix on thread names (Stewart X Addison) [#61307](nodejs/node#61307) - \[[`d4cf423a65`](nodejs/node@d4cf423a65)] - **stream**: export namespace object from internal end-of-stream module (René) [#61455](nodejs/node#61455) - \[[`7d8232e34c`](nodejs/node@7d8232e34c)] - **test**: add some validation for JSON doc output (Antoine du Hamel) [#61413](nodejs/node#61413) - \[[`75c06bc2a8`](nodejs/node@75c06bc2a8)] - **(SEMVER-MINOR)** **test**: migrate to --build-sea in existing SEA tests (Joyee Cheung) [#61167](nodejs/node#61167) - \[[`cabd58f1cb`](nodejs/node@cabd58f1cb)] - **(SEMVER-MINOR)** **test**: use fixture directories for sea tests (Joyee Cheung) [#61167](nodejs/node#61167) - \[[`bcffca8911`](nodejs/node@bcffca8911)] - **test**: aix: mark test\_threadsafe\_function/test flaky on AIX (Stewart X Addison) [#61452](nodejs/node#61452) - \[[`29399501c1`](nodejs/node@29399501c1)] - **test**: add implicit test for fs dispose handling with using (Ilyas Shabi) [#61140](nodejs/node#61140) - \[[`3bb481571a`](nodejs/node@3bb481571a)] - **test**: reveal wpt evaluation errors in status files (Chengzhong Wu) [#61358](nodejs/node#61358) - \[[`a132be7f71`](nodejs/node@a132be7f71)] - **test**: check new WebCryptoAPI enum values (Filip Skokan) [#61406](nodejs/node#61406) - \[[`72f1463735`](nodejs/node@72f1463735)] - **test**: split test-esm-loader-hooks (Joyee Cheung) [#61374](nodejs/node#61374) - \[[`39105e4c5f`](nodejs/node@39105e4c5f)] - **test**: aix: mark test-emit-on-destroyed as flaky (Stewart X Addison) [#61381](nodejs/node#61381) - \[[`3f17acfb1c`](nodejs/node@3f17acfb1c)] - **test**: add webidl web-platform tests (Yagiz Nizipli) [#61316](nodejs/node#61316) - \[[`89983cf747`](nodejs/node@89983cf747)] - **test**: update url web-platform tests (Yagiz Nizipli) [#61315](nodejs/node#61315) - \[[`73c0a242d7`](nodejs/node@73c0a242d7)] - **test**: forbid use of named imports for fixtures (Antoine du Hamel) [#61228](nodejs/node#61228) - \[[`a49d54308e`](nodejs/node@a49d54308e)] - **test**: enforce better never-settling-promise detection (Antoine du Hamel) [#60976](nodejs/node#60976) - \[[`335cb0b5cc`](nodejs/node@335cb0b5cc)] - **test**: ensure assertions are reached on all tests (Antoine du Hamel) [#60845](nodejs/node#60845) - \[[`5ee02c789a`](nodejs/node@5ee02c789a)] - **test**: ensure assertions are reached on more tests (Antoine du Hamel) [#60763](nodejs/node#60763) - \[[`141fb82ffb`](nodejs/node@141fb82ffb)] - **test**: ensure assertions are reached on more tests (Antoine du Hamel) [#60760](nodejs/node#60760) - \[[`edf90ce457`](nodejs/node@edf90ce457)] - **test**: use `RegExp.escape` to improve test reliability (Antoine du Hamel) [#60803](nodejs/node#60803) - \[[`f5f9b2dcf6`](nodejs/node@f5f9b2dcf6)] - **test**: ensure assertions are reached on more tests (Antoine du Hamel) [#60728](nodejs/node#60728) - \[[`ec1cbbe0b6`](nodejs/node@ec1cbbe0b6)] - **test\_runner**: fix memory leaks in runner (Abhishek Kv. Savani) [#60860](nodejs/node#60860) - \[[`399ac68427`](nodejs/node@399ac68427)] - **test\_runner**: fix coverage report when a directory is named file (Heath Dutton🕴️) [#61169](nodejs/node#61169) - \[[`6e1beda333`](nodejs/node@6e1beda333)] - **test\_runner**: print info when test restarts (Xavier Stouder) [#61160](nodejs/node#61160) - \[[`f5803ccb86`](nodejs/node@f5803ccb86)] - **test\_runner**: fix rerun ambiguous test failures (Moshe Atlow) [#61392](nodejs/node#61392) - \[[`a5a4c3eb44`](nodejs/node@a5a4c3eb44)] - **test\_runner**: nix dead reporter code (Vas Sudanagunta) [#59700](nodejs/node#59700) - \[[`ff1fcabfc9`](nodejs/node@ff1fcabfc9)] - **(SEMVER-MINOR)** **test\_runner**: support expecting a test-case to fail (Jacob Smith) [#60669](nodejs/node#60669) - \[[`ade4fc2338`](nodejs/node@ade4fc2338)] - **tools**: copyedit Nix files (Antoine du Hamel) [#61447](nodejs/node#61447) - \[[`7c2242beb9`](nodejs/node@7c2242beb9)] - **tools**: validate release commit diff as part of `lint-release-proposal` (Antoine du Hamel) [#61440](nodejs/node#61440) - \[[`ca4ebed258`](nodejs/node@ca4ebed258)] - **tools**: use ad-hoc flag to lint Nix files (Antoine du Hamel) [#61405](nodejs/node#61405) - \[[`05ce2c87f3`](nodejs/node@05ce2c87f3)] - **tools**: fix vcbuild lint-js-build (Vladimir Morozov) [#61318](nodejs/node#61318) - \[[`41adb54a37`](nodejs/node@41adb54a37)] - **tools**: enforce trailing commas in `test/es-module` (Antoine du Hamel) [#60891](nodejs/node#60891) - \[[`eebd732a52`](nodejs/node@eebd732a52)] - **tools**: enforce trailing commas in `test/sequential` (Antoine du Hamel) [#60892](nodejs/node#60892) - \[[`8b73739e03`](nodejs/node@8b73739e03)] - **typings**: add typing for string\_decoder (Taejin Kim) [#61368](nodejs/node#61368) - \[[`e88dd012ad`](nodejs/node@e88dd012ad)] - **v8**: changing total\_allocated\_bytes to avoid ABI changes (Caio Lima) [#60800](nodejs/node#60800) - \[[`c75ad3d87d`](nodejs/node@c75ad3d87d)] - **v8**: add GCProfiler support for erm (Ilyas Shabi) [#61191](nodejs/node#61191) - \[[`611c179663`](nodejs/node@611c179663)] - **zlib**: validate write\_result array length (Ryuhei Shima) [#61342](nodejs/node#61342) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).

nodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. v25.x Issues that can be reproduced on v25.x or PRs targeting the v25.x-staging branch. labels Nov 21, 2025

This was referenced Nov 21, 2025

[v24.x backport] v8: adding total_allocated_bytes to HeapStatistics #60801

Open

deps: V8: backport fe81545e6d14 #60429

Merged

RafaelGSS approved these changes Nov 21, 2025

View reviewed changes

joyeecheung approved these changes Nov 22, 2025

View reviewed changes

joyeecheung added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 22, 2025

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 23, 2025

joyeecheung added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 8, 2025

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 8, 2025

caiolima force-pushed the backport-60573-to-v25 branch from 5669bd4 to f6b05d5 Compare January 6, 2026 13:59

aduh95 force-pushed the v25.x-staging branch from c57a40c to 19feace Compare January 9, 2026 23:32

aduh95 requested a review from a team as a code owner January 9, 2026 23:32

aduh95 force-pushed the v25.x-staging branch from 19feace to a8902ab Compare January 12, 2026 00:33

RafaelGSS force-pushed the v25.x-staging branch 2 times, most recently from 9f2e230 to 65696e4 Compare January 15, 2026 16:41

avivkeller added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Jan 16, 2026

github-actions bot added request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Jan 16, 2026

v8: changing total_allocated_bytes to avoid ABI changes

de5bbb2

caiolima force-pushed the backport-60573-to-v25 branch from bd255c7 to de5bbb2 Compare January 20, 2026 16:13

aduh95 removed the request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. label Jan 22, 2026

aduh95 merged commit e88dd01 into nodejs:v25.x-staging Jan 24, 2026
44 of 58 checks passed

github-actions bot mentioned this pull request Jan 25, 2026

2026-01-26, Version 25.5.0 (Current) #61519

Merged

caiolima deleted the backport-60573-to-v25 branch January 26, 2026 14:48

Uh oh!

[v25.x] v8: changing total_allocated_bytes to avoid ABI changes #60800

[v25.x] v8: changing total_allocated_bytes to avoid ABI changes #60800

Conversation

caiolima commented Nov 21, 2025

Uh oh!

nodejs-github-bot commented Nov 21, 2025

Uh oh!

RafaelGSS left a comment

Choose a reason for hiding this comment

Uh oh!

nodejs-github-bot commented Nov 23, 2025

Uh oh!

caiolima commented Nov 25, 2025

Uh oh!

caiolima commented Dec 1, 2025

Uh oh!

nodejs-github-bot commented Dec 8, 2025

Uh oh!

caiolima commented Dec 17, 2025

Uh oh!

github-actions bot commented Jan 16, 2026

Uh oh!

aduh95 commented Jan 20, 2026

Uh oh!

caiolima commented Jan 20, 2026

Uh oh!

caiolima commented Jan 21, 2026

Uh oh!

nodejs-github-bot commented Jan 22, 2026

Uh oh!

nodejs-github-bot commented Jan 23, 2026

Uh oh!

nodejs-github-bot commented Jan 23, 2026

Uh oh!

nodejs-github-bot commented Jan 23, 2026

Uh oh!

Uh oh!

aduh95 commented Jan 24, 2026

Uh oh!

caiolima commented Jan 26, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants