build: enable -DV8_ENABLE_CHECKS flag #61327

islandryu · 2026-01-09T11:37:00Z

I’ve made changes so that V8_ENABLE_CHECKS is enabled in debug builds.
In addition, I’ve fixed code that caused errors when V8_ENABLE_CHECKS is enabled.

nodejs-github-bot · 2026-01-09T11:37:06Z

Review requested:

@nodejs/startup

islandryu · 2026-01-09T11:39:01Z

configure.py

+def set_configuration_variable_and_defines(configs, name, define, release=None, debug=None):
+  set_configuration_variable(configs, name, release, debug)
+  if configs['Debug'].get('defines') is None:
+      configs['Debug']['defines'] = []
+  if configs['Release'].get('defines') is None:
+      configs['Release']['defines'] = []
+  configs['Debug']['defines'].append(define)
+  configs['Release']['defines'].append(define)
+


This might be a GYP issue, but it seems that variables defined inside a conditions block are not reflected when evaluating other conditions.
In this case, the value of v8_enable_v8_checks set in configure.py (https://github.com/nodejs/node/blob/main/configure.py#L1530-L1532
) does not appear to be used when evaluating the condition 'v8_enable_v8_checks==1' in tools/v8_gypfiles/features.gypi (https://github.com/nodejs/node/blob/main/tools/v8_gypfiles/features.gypi#L405-L407
).

Therefore, I’m setting the defines directly.

codecov · 2026-01-09T14:36:25Z

Codecov Report

❌ Patch coverage is 81.81818% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.80%. Comparing base (b7bf7fe) to head (8541332).
⚠️ Report is 21 commits behind head on main.

Files with missing lines	Patch %	Lines
src/node_util.cc	0.00%	0 Missing and 1 partial ⚠️
src/util-inl.h	83.33%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #61327      +/-   ##
==========================================
+ Coverage   89.79%   89.80%   +0.01%     
==========================================
  Files         672      672              
  Lines      203907   203913       +6     
  Branches    39196    39200       +4     
==========================================
+ Hits       183094   183121      +27     
+ Misses      13132    13116      -16     
+ Partials     7681     7676       -5

Files with missing lines	Coverage Δ
lib/util.js	`97.98% <100.00%> (+<0.01%)`	⬆️
src/heap_utils.cc	`79.93% <100.00%> (ø)`
src/node_builtins.cc	`76.19% <100.00%> (ø)`
src/node_util.cc	`80.95% <0.00%> (ø)`
src/util-inl.h	`81.69% <83.33%> (-0.03%)`	⬇️

... and 42 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

anonrig · 2026-01-09T15:56:03Z

lib/util.js

+  frameCount = MathFloor(frameCount);
  return binding.getCallSites(frameCount);


Suggested change

frameCount = MathFloor(frameCount);

return binding.getCallSites(frameCount);

return binding.getCallSites(MathFloor(frameCount));

Since this is experimental, would it make more sense to switch to validateInteger?

Agree, I switched to validateInteger to limit it to integers.

anonrig · 2026-01-09T15:56:30Z

src/node_builtins.cc

@@ -441,7 +442,7 @@ void BuiltinLoader::SaveCodeCache(const std::string& id, Local<Data> data) {
    new_cached_data.reset(
        ScriptCompiler::CreateCodeCache(mod->GetUnboundModuleScript()));
  } else {
-    Local<Function> fun = data.As<Function>();
+    Local<Function> fun = data.As<Value>().As<Function>();


Why do you need this?

When V8_ENABLE_CHECKS is enabled, Local::As() fails because v8::Function only supports Cast(Value*), causing a compile error.
https://github.com/nodejs/node/blob/main/deps/v8/include/v8-local-handle.h#L424.

anonrig · 2026-01-09T15:57:36Z

src/util-inl.h

    } else {
      CHECK(value->IsNumber());
+      v8::Isolate* isolate = v8::Isolate::GetCurrent();
+      v8::Local<v8::Context> context = isolate->GetCurrentContext();
+      v8::Maybe<uint32_t> maybe = value->Uint32Value(context);


in line 684 why don't you just check for IsUint32?

Because we need to accept signed values for some call sites (e.g. fs.chown), not only strict Uint32.

configure.py

Fixes: nodejs#61301

Co-authored-by: Yagiz Nizipli <yagiz@nizipli.com>

nodejs-github-bot · 2026-01-25T07:48:24Z

CI: https://ci.nodejs.org/job/node-test-pull-request/71013/

nodejs-github-bot · 2026-01-25T12:23:58Z

CI: https://ci.nodejs.org/job/node-test-pull-request/71021/

nodejs-github-bot · 2026-01-26T02:55:16Z

CI: https://ci.nodejs.org/job/node-test-pull-request/71036/

nodejs-github-bot · 2026-01-26T12:56:43Z

CI: https://ci.nodejs.org/job/node-test-pull-request/71042/

nodejs-github-bot · 2026-01-28T03:54:04Z

Commit Queue failed

- Loading data for nodejs/node/pull/61327 ✔ Done loading data for nodejs/node/pull/61327 ----------------------------------- PR info ------------------------------------ Title build: enable -DV8_ENABLE_CHECKS flag (#61327) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch islandryu:61301 -> nodejs:main Labels c++, build, lib / src, author ready, needs-ci Commits 6 - build: enable -DV8_ENABLE_CHECKS flag - fix lint - fix set_configuration_variable_and_defines - Update lib/util.js - validate frameCount is an integer - use options.debug for branching Committers 1 - islandryu <shimaryuhei@gmail.com> PR-URL: https://github.com/nodejs/node/pull/61327 Fixes: https://github.com/nodejs/node/issues/61301 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/61327 Fixes: https://github.com/nodejs/node/issues/61301 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> -------------------------------------------------------------------------------- ℹ This PR was created on Fri, 09 Jan 2026 11:37:00 GMT ✔ Approvals: 1 ✔ - Chengzhong Wu (@legendecas) (TSC): https://github.com/nodejs/node/pull/61327#pullrequestreview-3706160274 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2026-01-26T12:56:43Z: https://ci.nodejs.org/job/node-test-pull-request/71042/ - Querying data for job/node-test-pull-request/71042/ ✔ Build data downloaded ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD ✔ origin/main is now up-to-date - Downloading patch for 61327 From https://github.com/nodejs/node * branch refs/pull/61327/merge -> FETCH_HEAD ✔ Fetched commits as 150d154bf1ba..8541332a7637 -------------------------------------------------------------------------------- [main 7b7478a657] build: enable -DV8_ENABLE_CHECKS flag Author: islandryu <shimaryuhei@gmail.com> Date: Fri Jan 9 20:26:32 2026 +0900 6 files changed, 30 insertions(+), 6 deletions(-) [main 652080ab7b] fix lint Author: islandryu <shimaryuhei@gmail.com> Date: Fri Jan 9 20:40:14 2026 +0900 2 files changed, 3 insertions(+), 2 deletions(-) [main 633ced745a] fix set_configuration_variable_and_defines Author: islandryu <shimaryuhei@gmail.com> Date: Sat Jan 10 22:35:16 2026 +0900 1 file changed, 8 insertions(+), 5 deletions(-) [main 9b44f595b7] Update lib/util.js Author: Ryuhei Shima <65934663+islandryu@users.noreply.github.com> Date: Sat Jan 10 23:03:33 2026 +0900 1 file changed, 1 insertion(+), 2 deletions(-) Auto-merging doc/api/util.md [main fa4d3726fe] validate frameCount is an integer Author: islandryu <shimaryuhei@gmail.com> Date: Sat Jan 10 23:27:27 2026 +0900 3 files changed, 11 insertions(+), 13 deletions(-) [main 21f4afb2dc] use options.debug for branching Author: islandryu <shimaryuhei@gmail.com> Date: Tue Jan 13 18:24:59 2026 +0900 1 file changed, 5 insertions(+), 24 deletions(-) ✔ Patches applied There are 6 commits in the PR. Attempting autorebase. (node:2326) [DEP0190] DeprecationWarning: Passing args to a child process with shell option true can lead to security vulnerabilities, as the arguments are not escaped, only concatenated. (Use `node --trace-deprecation ...` to show where the warning was created) Rebasing (2/12) Executing: git node land --amend --yes ⚠ Found Fixes: https://github.com/nodejs/node/issues/61301, skipping.. --------------------------------- New Message ---------------------------------- build: enable -DV8_ENABLE_CHECKS flag

Fixes: #61301
PR-URL: #61327
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>

[detached HEAD 3cf8cea716] build: enable -DV8_ENABLE_CHECKS flag
Author: islandryu <shimaryuhei@gmail.com>
Date: Fri Jan 9 20:26:32 2026 +0900
6 files changed, 30 insertions(+), 6 deletions(-)
Rebasing (3/12)
Rebasing (4/12)
Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
fix lint

PR-URL: #61327
Fixes: #61301
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>

[detached HEAD b0c41b2414] fix lint
Author: islandryu <shimaryuhei@gmail.com>
Date: Fri Jan 9 20:40:14 2026 +0900
2 files changed, 3 insertions(+), 2 deletions(-)
Rebasing (5/12)
Rebasing (6/12)
Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
fix set_configuration_variable_and_defines

PR-URL: #61327
Fixes: #61301
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>

[detached HEAD 34499c93f3] fix set_configuration_variable_and_defines
Author: islandryu <shimaryuhei@gmail.com>
Date: Sat Jan 10 22:35:16 2026 +0900
1 file changed, 8 insertions(+), 5 deletions(-)
Rebasing (7/12)
Rebasing (8/12)
Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
Update lib/util.js

Co-authored-by: Yagiz Nizipli <yagiz@nizipli.com>
PR-URL: #61327
Fixes: #61301
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>

[detached HEAD d16d6412ff] Update lib/util.js
Author: Ryuhei Shima <65934663+islandryu@users.noreply.github.com>
Date: Sat Jan 10 23:03:33 2026 +0900
1 file changed, 1 insertion(+), 2 deletions(-)
Rebasing (9/12)
Rebasing (10/12)
Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
validate frameCount is an integer

PR-URL: #61327
Fixes: #61301
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>

[detached HEAD 6bc2400222] validate frameCount is an integer
Author: islandryu <shimaryuhei@gmail.com>
Date: Sat Jan 10 23:27:27 2026 +0900
3 files changed, 11 insertions(+), 13 deletions(-)
Rebasing (11/12)
Rebasing (12/12)
Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
use options.debug for branching

PR-URL: #61327
Fixes: #61301
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>

[detached HEAD 6029560cb6] use options.debug for branching
Author: islandryu <shimaryuhei@gmail.com>
Date: Tue Jan 13 18:24:59 2026 +0900
1 file changed, 5 insertions(+), 24 deletions(-)
Successfully rebased and updated refs/heads/main.

ℹ Add commit-queue-squash label to land the PR as one commit, or commit-queue-rebase to land as separate commits.

https://github.com/nodejs/node/actions/runs/21424254133

nodejs-github-bot · 2026-01-28T04:17:11Z

Landed in 74c3658

Fixes: #61301 PR-URL: #61327 Reviewed-By: Chengzhong Wu <legendecas@gmail.com>

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Jan 9, 2026

islandryu commented Jan 9, 2026

View reviewed changes

islandryu force-pushed the 61301 branch from bc06695 to a737f4f Compare January 9, 2026 12:26

anonrig reviewed Jan 9, 2026

View reviewed changes

legendecas reviewed Jan 12, 2026

View reviewed changes

configure.py Outdated Show resolved Hide resolved

legendecas added the build Issues and PRs related to build files or the CI. label Jan 12, 2026

legendecas mentioned this pull request Jan 12, 2026

build: infer cargo mode with gyp var build_type directly #61354

Merged

islandryu requested a review from a team as a code owner January 25, 2026 01:24

islandryu force-pushed the 61301 branch from 57ada9d to 6d5128c Compare January 25, 2026 01:26

islandryu and others added 6 commits January 25, 2026 10:28

build: enable -DV8_ENABLE_CHECKS flag

53c7e04

Fixes: nodejs#61301

fix lint

7cdc3a3

fix set_configuration_variable_and_defines

3a222f8

Update lib/util.js

6847a41

Co-authored-by: Yagiz Nizipli <yagiz@nizipli.com>

validate frameCount is an integer

ed19665

use options.debug for branching

8541332

islandryu force-pushed the 61301 branch from 6d5128c to 8541332 Compare January 25, 2026 01:29

islandryu removed the request for review from a team January 25, 2026 07:44

legendecas approved these changes Jan 26, 2026

View reviewed changes

legendecas added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Jan 26, 2026

nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Jan 28, 2026

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 28, 2026

nodejs-github-bot merged commit 74c3658 into nodejs:main Jan 28, 2026
78 checks passed

aduh95 pushed a commit that referenced this pull request Jan 28, 2026

build: enable -DV8_ENABLE_CHECKS flag

8f2083e

Fixes: #61301 PR-URL: #61327 Reviewed-By: Chengzhong Wu <legendecas@gmail.com>

		frameCount = MathFloor(frameCount);
		return binding.getCallSites(frameCount);

	frameCount = MathFloor(frameCount);
	return binding.getCallSites(frameCount);
	return binding.getCallSites(MathFloor(frameCount));

Uh oh!

build: enable -DV8_ENABLE_CHECKS flag #61327

build: enable -DV8_ENABLE_CHECKS flag #61327

Uh oh!

Conversation

islandryu commented Jan 9, 2026

Uh oh!

nodejs-github-bot commented Jan 9, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

codecov bot commented Jan 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

nodejs-github-bot commented Jan 25, 2026

Uh oh!

nodejs-github-bot commented Jan 25, 2026

Uh oh!

nodejs-github-bot commented Jan 26, 2026

Uh oh!

nodejs-github-bot commented Jan 26, 2026

Uh oh!

nodejs-github-bot commented Jan 28, 2026

Fixes: #61301 PR-URL: #61327 Reviewed-By: Chengzhong Wu <legendecas@gmail.com>

PR-URL: #61327 Fixes: #61301 Reviewed-By: Chengzhong Wu <legendecas@gmail.com>

PR-URL: #61327 Fixes: #61301 Reviewed-By: Chengzhong Wu <legendecas@gmail.com>

Co-authored-by: Yagiz Nizipli <yagiz@nizipli.com> PR-URL: #61327 Fixes: #61301 Reviewed-By: Chengzhong Wu <legendecas@gmail.com>

PR-URL: #61327 Fixes: #61301 Reviewed-By: Chengzhong Wu <legendecas@gmail.com>

PR-URL: #61327 Fixes: #61301 Reviewed-By: Chengzhong Wu <legendecas@gmail.com>

[detached HEAD 6029560cb6] use options.debug for branching Author: islandryu <shimaryuhei@gmail.com> Date: Tue Jan 13 18:24:59 2026 +0900 1 file changed, 5 insertions(+), 24 deletions(-) Successfully rebased and updated refs/heads/main.

Uh oh!

Uh oh!

nodejs-github-bot commented Jan 28, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

codecov bot commented Jan 9, 2026 •

edited

Loading

Fixes: #61301
PR-URL: #61327
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>

PR-URL: #61327
Fixes: #61301
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>

PR-URL: #61327
Fixes: #61301
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>

Co-authored-by: Yagiz Nizipli <yagiz@nizipli.com>
PR-URL: #61327
Fixes: #61301
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>

PR-URL: #61327
Fixes: #61301
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>

PR-URL: #61327
Fixes: #61301
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>

[detached HEAD 6029560cb6] use options.debug for branching
Author: islandryu <shimaryuhei@gmail.com>
Date: Tue Jan 13 18:24:59 2026 +0900
1 file changed, 5 insertions(+), 24 deletions(-)
Successfully rebased and updated refs/heads/main.