crypto: throw error in CipherBase::SetAutoPadding#9405
Closed
fanatid wants to merge 1 commit intonodejs:masterfrom
Closed
crypto: throw error in CipherBase::SetAutoPadding#9405fanatid wants to merge 1 commit intonodejs:masterfrom
fanatid wants to merge 1 commit intonodejs:masterfrom
Conversation
Member
|
Tagging this as |
Contributor
|
Needs docs and tests |
2cf16d8 to
abc29e8
Compare
Contributor
Author
|
updated |
cjihrig
reviewed
Nov 2, 2016
Contributor
There was a problem hiding this comment.
If you assert on the error message instead of just the Error constructor, it gives us better detection of things like error message changes (which are semver major). It also verifies that we got the error we planned for.
abc29e8 to
4c04d3e
Compare
jasnell
approved these changes
Nov 3, 2016
cjihrig
approved these changes
Nov 3, 2016
4c04d3e to
e06b6c2
Compare
Throw error after calling CipherBase#final
e06b6c2 to
2f83f0e
Compare
Contributor
Author
|
Rebased and fix lint errors. |
Member
Member
|
Landed in e90f382, thanks for the PR! |
addaleax
pushed a commit
that referenced
this pull request
Feb 7, 2017
Throw error after calling CipherBase#final PR-URL: #9405 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
krydos
pushed a commit
to krydos/node
that referenced
this pull request
Feb 25, 2017
Throw error after calling CipherBase#final PR-URL: nodejs#9405 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
bnoordhuis
added a commit
to bnoordhuis/io.js
that referenced
this pull request
Oct 29, 2017
The previous commit is a back-port of pull request nodejs#13821 to v6.x. Its regression test does not apply to the v6.x branch (depends on semver-major pull request nodejs#9405) so this commit adds a new test. Refs: nodejs#13821 Refs: nodejs#9405
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
crypto
Description of change
Throw error after calling
CipherBase#finalas inCipherBase::SetAAD,CipherBase::SetAuthTag,CipherBase::GetAuthTag.