Updated the README.md with overview details#32
Merged
yizha1 merged 25 commits intonotaryproject:mainfrom Aug 7, 2023
Merged
Conversation
yizha1
reviewed
Jun 12, 2023
TheFoxAtWork
suggested changes
Jun 12, 2023
Contributor
TheFoxAtWork
left a comment
There was a problem hiding this comment.
There are a few areas that need more clarity but this is a significant improvement, thank you!
I would like to call out that there is one line introduced in the change that provides (perhaps) the most clarification between Notary and Notary Project that should be conveyed throughout both repos
FeynmanZhou
reviewed
Jun 12, 2023
yizha1
previously approved these changes
Jun 15, 2023
iamsamirzon
suggested changes
Jun 15, 2023
FeynmanZhou
reviewed
Jun 19, 2023
|
+1 - I feel that this PR clarifies a lot of issues and thank you @toddysm. |
Contributor
TheFoxAtWork
left a comment
There was a problem hiding this comment.
I've provided several suggested changes to improve the readability and clarity of this PR. Thank you all for taking the time to capture, record, and improve upon the original content to ensure community members understand the differences between the repositories.
shizhMSFT
reviewed
Jun 25, 2023
yizha1
reviewed
Jul 20, 2023
Co-authored-by: Emily Fox <33327273+TheFoxAtWork@users.noreply.github.com> Signed-off-by: Toddy Mladenov <me@toddysm.com> Signed-off-by: Toddy Mladenov <toddysm@gmail.com>
Co-authored-by: Milind Gokarn <milind81@gmail.com> Signed-off-by: Toddy Mladenov <me@toddysm.com> Signed-off-by: Toddy Mladenov <toddysm@gmail.com>
Co-authored-by: Emily Fox <33327273+TheFoxAtWork@users.noreply.github.com> Signed-off-by: Toddy Mladenov <me@toddysm.com> Signed-off-by: Toddy Mladenov <toddysm@gmail.com>
Signed-off-by: Toddy Mladenov <toddysm@gmail.com>
Co-authored-by: Milind Gokarn <milind81@gmail.com> Signed-off-by: Toddy Mladenov <me@toddysm.com> Signed-off-by: Toddy Mladenov <toddysm@gmail.com>
Co-authored-by: Emily Fox <33327273+TheFoxAtWork@users.noreply.github.com> Signed-off-by: Toddy Mladenov <me@toddysm.com> Signed-off-by: Toddy Mladenov <toddysm@gmail.com>
Co-authored-by: Milind Gokarn <milind81@gmail.com> Signed-off-by: Toddy Mladenov <me@toddysm.com> Signed-off-by: Toddy Mladenov <toddysm@gmail.com>
Co-authored-by: Emily Fox <33327273+TheFoxAtWork@users.noreply.github.com> Signed-off-by: Toddy Mladenov <me@toddysm.com> Signed-off-by: Toddy Mladenov <toddysm@gmail.com>
Co-authored-by: Emily Fox <33327273+TheFoxAtWork@users.noreply.github.com> Signed-off-by: Toddy Mladenov <me@toddysm.com> Signed-off-by: Toddy Mladenov <toddysm@gmail.com>
Co-authored-by: Emily Fox <33327273+TheFoxAtWork@users.noreply.github.com> Signed-off-by: Toddy Mladenov <me@toddysm.com> Signed-off-by: Toddy Mladenov <toddysm@gmail.com>
Co-authored-by: Yi Zha <yizha1@microsoft.com> Signed-off-by: Toddy Mladenov <me@toddysm.com> Signed-off-by: Toddy Mladenov <toddysm@gmail.com>
Signed-off-by: Toddy Mladenov <toddysm@gmail.com>
Co-authored-by: Samir Kakkar <83560495+iamsamirzon@users.noreply.github.com> Signed-off-by: Toddy Mladenov <me@toddysm.com> Signed-off-by: Toddy Mladenov <toddysm@gmail.com>
Signed-off-by: Toddy Mladenov <toddysm@gmail.com>
Signed-off-by: Toddy Mladenov <toddysm@gmail.com>
Signed-off-by: Toddy Mladenov <toddysm@gmail.com>
Signed-off-by: Toddy Mladenov <toddysm@gmail.com>
Signed-off-by: Toddy Mladenov <toddysm@gmail.com>
f0af95d to
9a16ee3
Compare
Co-authored-by: Milind Gokarn <milind81@gmail.com> Signed-off-by: Toddy Mladenov <me@toddysm.com>
priteshbandi
reviewed
Aug 4, 2023
sajayantony
approved these changes
Aug 4, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@TheFoxAtWork and @mattfarina related to the notaryproject/specifications#262 we would like to have one central place where the overview is made and refer to it from the other repositories. Please let me know if this PR answers your question posted in notaryproject/specifications#262.
Adding also @iamsamirzon for review.