Merged
Conversation
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1145 +/- ##
==========================================
- Coverage 72.52% 72.38% -0.14%
==========================================
Files 50 50
Lines 3126 3125 -1
==========================================
- Hits 2267 2262 -5
- Misses 667 670 +3
- Partials 192 193 +1 ☔ View full report in Codecov by Sentry. |
shizhMSFT
requested changes
Jan 14, 2025
Contributor
shizhMSFT
left a comment
There was a problem hiding this comment.
Can you re-implement LoadConfigOnce using sync.OnceValues?
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
ghost
reviewed
Jan 14, 2025
ghost
left a comment
There was a problem hiding this comment.
Let's make
notation/internal/cmd/flags.go
Line 46 in 1118964
SetPflagSignatureFormat = func(fs *pflag.FlagSet, p *string) {
config, err := configutil.LoadConfigOnce()
if err != nil || config.SignatureFormat == "" {
fs.StringVar(p, PflagSignatureFormat.Name, envelope.JWS, PflagSignatureFormat.Usage)
return
}
// set signatureFormat from config
fs.StringVar(p, PflagSignatureFormat.Name, config.SignatureFormat, PflagSignatureFormat.Usage)
}
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
Contributor
Author
Updated. |
7h3-3mp7y-m4n
pushed a commit
to 7h3-3mp7y-m4n/notation
that referenced
this pull request
Mar 29, 2025
Fix: - the `LoadConfigOnce` function forgets the error and return a nil config and nil error next time. Updated to use `sync.OnceValues` to keep the returned values. Resolves notaryproject#1144 --------- Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
FeynmanZhou
pushed a commit
to FeynmanZhou/notation
that referenced
this pull request
May 15, 2025
Fix: - the `LoadConfigOnce` function forgets the error and return a nil config and nil error next time. Updated to use `sync.OnceValues` to keep the returned values. Resolves notaryproject#1144 --------- Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix:
LoadConfigOncefunction forgets the error and return a nil config and nil error next time. Updated to usesync.OnceValuesto keep the returned values.Resolves #1144